Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bess-mvpn-mib-06
Hiroshi Tsunoda <tsuno@m.ieice.org> Thu, 17 May 2018 15:22 UTC
Return-Path: <dr.h.t@ieee.org>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2ADC512EB0B for <bess@ietfa.amsl.com>; Thu, 17 May 2018 08:22:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.662
X-Spam-Level:
X-Spam-Status: No, score=-1.662 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ieee-org.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aWMtD0Zr45aG for <bess@ietfa.amsl.com>; Thu, 17 May 2018 08:22:23 -0700 (PDT)
Received: from mail-ot0-x244.google.com (mail-ot0-x244.google.com [IPv6:2607:f8b0:4003:c0f::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C0FE712DA16 for <bess@ietf.org>; Thu, 17 May 2018 08:22:23 -0700 (PDT)
Received: by mail-ot0-x244.google.com with SMTP id 77-v6so5487630otd.4 for <bess@ietf.org>; Thu, 17 May 2018 08:22:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Zy7v4xAh/w1FfmdWfO/COHRl3/NrfaHVumviIL97aeA=; b=beL+I6BJU9dyprCF8fXLLeGt/6yURIMy1IFCcv/8xuov91GVJd9EP89nVwdEkisPg0 IDCDbdfucnNo9fxv7Zo81cQOhe6bLxq8or74xwWnpJmfqVx4ibCsMXCd6Wo0DisvgfX/ la0JvFcEZz5QOuR7b/e4oSRZrWEVm5M3lxfJJiffXK4VfnFDr1zsm4/q4QNK3pHsbU3P E6Z1el/4rHzHr+6k8E/aWff28OVlHMkksfEhAoPxhVeA0/ErNKeZMq99hvF0o2FLFtj+ 7akcUbQySPsItlkZhGtkNX3XhB2vxjJcnVaGtg7UTBEkXBeNQ6tcixqgmezwIiJZ64LH wucg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Zy7v4xAh/w1FfmdWfO/COHRl3/NrfaHVumviIL97aeA=; b=mngqgziqh9tTlNooQBP0iEkvUmkH2Y5RZBKFK4CW89pbhirLtYpImRIq5GPGoR5UWf FbjmLbBSNKQDv+4GjrpQdFSQ+cbbbv9reQZQNsD7GNsSAvYunA1uOQB1QqYsBNbYYuJj Ydbk/w2PZ3VlkIgWg63ZqkPB2uk49rpbHyZIOBq5jc08hdgoRKvOoLR8s5ZfT7AA83qm vS5xCnLAuIrlkGuramlNUSdfZlhOkUBjXGMvMiClQSba6tmq09zZUK1LkmxM4JMhVt8V MRmVixOnP/Y0ipl5sNdQfO+521ELcV+vRNMFIq7KgTidoARZ57lvQgUaz0M+49cRviWK Gd2g==
X-Gm-Message-State: ALKqPwdGAa5aeZ/9EodgDFG6B7zzRYdut9uGnNojCgZruDzoZCI+Vluu dKrFO/dudKfyAfw3IY8+BrafLy/ydAiDi6xn5zcC+g==
X-Google-Smtp-Source: AB8JxZouclZNW5HAxJv5frTamK8dbBCcFWkNA3nLIVamo+H6/J8uaGzDgbd0YcdW3YBZZQDuNJ9cwwpetpgLbAfr104=
X-Received: by 2002:a9d:5134:: with SMTP id c49-v6mr4148175oth.174.1526570541186; Thu, 17 May 2018 08:22:21 -0700 (PDT)
MIME-Version: 1.0
Sender: dr.h.t@ieee.org
Received: by 2002:a9d:1a12:0:0:0:0:0 with HTTP; Thu, 17 May 2018 08:21:40 -0700 (PDT)
In-Reply-To: <0d9137fb-bf3f-7ffe-440d-d6c2ef939ca3@cysols.com>
References: <CAPbjwkzJi3xRr5cu5_6S_qHoqYcBTDYiUM_KcRA1opwedx4btQ@mail.gmail.com> <227a1df3-a65b-2f61-cf78-d57068953458@cysols.com> <70f776cd-f9c5-7031-eeaf-64c92e580cad@cysols.com> <0d9137fb-bf3f-7ffe-440d-d6c2ef939ca3@cysols.com>
From: Hiroshi Tsunoda <tsuno@m.ieice.org>
Date: Thu, 17 May 2018 22:21:40 +0700
X-Google-Sender-Auth: ULtFXDgXT63AXy_x-Kw6O3oyYmI
Message-ID: <CAPbjwkyKovUJA+T3JJ6TyFZkZBEBocotVFrsrKTu94Y7F72K-Q@mail.gmail.com>
To: Glenn Mansfield Keeni <glenn@cysols.com>
Cc: mib-doctors@ietf.org, Mach Chen <mach.chen@huawei.com>, bess@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/zHX4LXFyTxnlaUdxRy15By4-Lpo>
Subject: Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bess-mvpn-mib-06
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 May 2018 15:22:26 -0000
Dear Glenn, Thank you very much for your comprehensive review. I will reflect these comments to the next revision. Best regards, -- tsuno 2018-05-17 17:58 GMT+07:00 Glenn Mansfield Keeni <glenn@cysols.com>: > Hi Tsunoda, > I have completed a pass of the document. The document > is shaping up well.Once again thanks for the good work. > The comments follow. I would also recommend a closer check > for editorial nits in the next draft. > > Glenn > ---------------------------------------------------------- > > draft: draft-ietf-bess-mvpn-mib-06.txt > > 1. Please make the usages uniform. e.g. > "Multicast VPN (MVPN)" vs "Multicast VPN" (MVPN) > MVPN vs Multicast VPN > "Inclusive PMSI (I-PMSI)" vs "Inclusive PMSI" (I-PMSI) > > 2. Page 3, Sec 1, para 2 > This document describes managed objects to configure and/or monitor > MVPN. > s/MVPN/MVPNs/ > > 3. Page 3, Sec 1.1, para 3 > s/A PE uses to/A PE uses a P-tunnel to/ > 4. Page 3, Sec 1.1, para 5 > What is the minimum number of VRFs on a PE? 0? 1? Please update > the paragraph accordingly. > > 5. Page 4, Sec 3.1 Summary of MIB Module > > s/attribute informations of MVRFs of MVPNs/attributes of MVPNs/ > s/Configuring some timers/Monitoring and configuring some timers/ > s/Monitoring attribute informations of PMSIs/ > Monitoring PMSI attribute information/ > s/Monitoring advertisement exchanged/Monitoring statistics on > advertisements > exchanged/ > > 6. Table naming. > mvpnIpmsiAdvtTable, mvpnInterAsIpmsiAdvtTable, mvpnSpmsiAdvtTable > These are tables containing counters about advertisements received. > But the names seem to imply that they contain advertisements. Please > rename appropriately. > > > 7. Page 5, Sec 3.1 Summary of MIB Module (contd) > s/contain information of MVRFs of MVPNs/contain information of MVPNs/ > s/represetns/represents/ > s/Selective PMSI (S-PMSI)/S-PMSI/ > s/mvpnGeneralTable/mvpnGenericTable/ > s/mvpnSpmsiConfigTable/mvpnSpmsiTable/ > s/that is advertised/that are advertised/ > > 8. This MIB, particularly mvpnGenericTable, uses MPLS-L3VPN-STD-MIB. Please > mention this explicitly. > > 9. Page 62 Sec 4. > s/read- write/read-write/ > s/mvpnGenCmcastRouteProtocol, mvpnGenIpmsiInfo, > mvpnGenInterAsPmsiInfo, mvpnGenUmhSelection, > mvpnGenCustomerSiteType, mvpnGenSPTunnelLimit, mvpnBgpGenMode, > mvpnBgpGenVrfRtImport, mvpnPmsiEncapsulationType, > mvpnSpmsiThreshold, mvpnSpmsiPmsiPointer/ > mvpnBgpGenCmcastRouteWithdrawalTimer, > mvpnBgpGenSrcSharedTreeJoinTimer, > mvpnBgpGenMsgRateLimit, > mvpnBgpGenMaxSpmsiAdRoutes, > mvpnBgpGenMaxSpmsiAdRouteFreq, > mvpnBgpGenMaxSrcActiveAdRoutes, > mvpnBgpGenMaxSrcActiveAdRouteFreq, > mvpnSpmsiThreshold/ > 10. Please do the '[TBD]' > > > > > On 2018/05/13 18:56, Glenn Mansfield Keeni wrote: >> >> Hi Tsunoda, >> I have done a review of the MIB. The comments follow. >> Glenn >> >> draft: draft-ietf-bess-mvpn-mib-06.txt >> Only the MIB has been reviewed. >> >> COMMENTS: >> >> 1. Naming: Please review. >> MO: mvpnBgpGenVrfRouteImport: >> if it is a condition for import name accordingly >> >> 2. Usage: Please make the usages of the following uniform in the document >> MVPN/mvpn/MVRF >> tunnel type/Tunnel type >> Source AS/source-as >> >> >> 3. Units: The units for the following MOs are unspecified. >> Please check. >> MO: mvpnBgpGenCmcastRouteWithdrawalTimer >> MO: mvpnBgpGenSrcSharedTreeJoinTimer >> MO: mvpnBgpGenMsgRateLimit >> MO: mvpnBgpGenMaxSpmsiAdRoutes >> MO: mvpnBgpGenMaxSpmsiAdRouteFreq >> MO: mvpnBgpGenMaxSrcActiveAdRoutes >> MO: mvpnBgpGenMaxSrcActiveAdRouteFreq >> 4. Semantics: >> InetAddress and INetAddressType objects >> for several MOs, usage of InetAddressType unknown(0) >> is described. In all such cases the corresponding >> InetAddress MO value MUST be a string of length 0. >> Plese explain that case in the respective DESCRIPTIONs >> E.g. mvpnMrouteUpstreamNeighborAddr >> mvpnMrouteNextHopSourceAddr >> mvpnMrouteCmcastSourceAddr >> mvpnMrouteSourceAddr >> >> 5. mvpnSpmsiAdvtCmcastSourceAddr OBJECT-TYPE >> SYNTAX InetAddress >> ==> corresponding InetAddressType object >> mvpnSpmsiAdvtCmcastSourceAddrType is missing >> >> 6. Nits: >> MO: mvpnMrouteCmcastSourceAddrType OBJECT-TYPE >> DESCRIPTION >> "A value indicating the address family of the address >> contained in mvpnMrouteSourceAddr. >> s/mvpnMrouteSourceAddr/mvpnMrouteCmcastSourceAddr/ >> >> 7. Table descriptions: >> mvpnIpmsiAdvtTable >> mvpnSpmsiAdvtTable >> The DESCRIPTIONs are unclear. >> Do the tables 'contain' all advertisements or, >> Statistics related to the advertisements? >> >> >> 8. Additional suggestions: >> o For INDEX clauses of variable size where the size may potentially >> exceed 128 octets, a statement like the following will be good. >> Implementors need to be aware that if the total number of >> octets in MO1, MO2 and MO3 exceeds NNN, then OIDs of column >> instances in this row will have more than 128 sub-identifiers >> and cannot be accessed using SNMPv1, SNMPv2c, or SNMPv3. >> >> o In REFERENCES be more specific if possible. Eg. >> Current: >> mvpnPmsiTunnelIfIndex OBJECT-TYPE >> REFERENCE >> "RFC2863 >> Suggested: >> mvpnPmsiTunnelIfIndex OBJECT-TYPE >> REFERENCE >> "RFC2863 Sec. 3.1.5 >> >> >> >> On 2018/05/02 6:59, Glenn Mansfield Keeni wrote: >>> >>> Hi Tsunoda, >>> Thanks for the good work. >>> I will start reviewing this right away. >>> >>> Glenn >>> >>> On 2018/05/01 12:14, Hiroshi Tsunoda wrote: >>>> >>>> Dear Glenn, >>>> >>>> Thank you for waiting the update. >>>> I have submitted the updated version of >>>> draft-ietf-bess-mvpn-mib. >>>> >>>> Links to the draft and diff are as follows. >>>> >>>> URL: >>>> https://www.ietf.org/internet-drafts/draft-ietf-bess-mvpn-mib-06.txt >>>> Htmlized: https://tools.ietf.org/html/draft-ietf-bess-mvpn-mib-06 >>>> Htmlized: https://datatracker.ietf.org/doc/html/draft-ietf-bess-mvpn-mib >>>> Diff: https://www.ietf.org/rfcdiff?url2=draft-ietf-bess-mvpn-mib-0 >>>> >>>> This version contains some major changes as follows. >>>> I hope this update make the role and usage of the MIB clear for you. >>>> >>>> +----------------------------------------------------------+ >>>> Changes: >>>> >>>> 1. Support for row creation in all tables is removed >>>> >>>> Reason: The utility of row creation is dubious. >>>> It increases complexity of the MIB implementation. >>>> Unless an immediate need for row creation, we will go ahead >>>> with the current draft and review the need for row creation >>>> at a later date if and when it arises. >>>> >>>> 2. Added objects to make the role and usage of this MIB clear. >>>> >>>> Reason: This MIB will provide the following management functions. >>>> >>>> - Configuration of MVRF related timers >>>> >>>> - Generation of Notifications to indicate creation, deletion, >>>> and/or modification of MVRFs >>>> >>>> - Generation of Notification when a member joins or leaves a >>>> multicast group >>>> >>>> - Monitoring of the following >>>> - attributes of MVRFs of MVPNs >>>> - PMSIs >>>> - statistics of advertisements exchanged by a PE >>>> - routing entries in a MVRF >>>> - next-hops for a multicast destination in a MVRF >>>> +----------------------------------------------------------+ >>>> >>>> -- tsuno >>>> >>> >>> _______________________________________________ >>> MIB-DOCTORS mailing list >>> MIB-DOCTORS@ietf.org >>> https://www.ietf.org/mailman/listinfo/mib-doctors >> >> >> _______________________________________________ >> MIB-DOCTORS mailing list >> MIB-DOCTORS@ietf.org >> https://www.ietf.org/mailman/listinfo/mib-doctors >> >
- [bess] Update to draft-ietf-bess-mvpn-mib-06 Hiroshi Tsunoda
- Re: [bess] Update to draft-ietf-bess-mvpn-mib-06 Glenn Mansfield Keeni
- Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bes… Glenn Mansfield Keeni
- Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bes… Hiroshi Tsunoda
- Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bes… Glenn Mansfield Keeni
- Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bes… Hiroshi Tsunoda