Re: [Bier] Feedback on draft-eckert-bier-rbs-00

IJsbrand Wijnands <ice@braindump.be> Fri, 17 February 2023 13:09 UTC

Return-Path: <ice@braindump.be>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B7A2CC14CF05; Fri, 17 Feb 2023 05:09:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.887
X-Spam-Level:
X-Spam-Status: No, score=-6.887 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=mailprotect.be
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x_vIkQk8s1WA; Fri, 17 Feb 2023 05:09:45 -0800 (PST)
Received: from com-out001.mailprotect.be (com-out001.mailprotect.be [83.217.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D97A6C14CE25; Fri, 17 Feb 2023 05:09:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:reply-to:sender:bcc; bh=oPUTg2wjUqgWkHTzBC9jJ7TNehamQ6ZpWTMxlTXPJ2A=; b=GBUWvWbkvl2mQ/NcyicBWiCbFg HEG1J8ONSwb/OL6EuuFr0xBFzuS6JqRf8oZSWPEVmIDyRurqZJpzg23gGutJrDAErVxcclT/YEfGF AixSt5LqHmQXh3xapXSJIxC1EBn27GsQFZ/CrgxRbtFZLzwRhumwJN2GtH7vAB/1OO/n2yGyT3UW5 XqqiTRI7eclx5KgV0+7tg2llxoA0FVL2KqOB0mZedbdsmmyvkKEi5pALo3oOiFeBaCOv6dP7vU2c8 NRGqgJbLTuzagFSGsastC+KkprRQjJEHo321EMrozonPqenQ8OBcdRXkjqOnzUauiHoDdibXxGOry VFSewvyw==;
Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.92) (envelope-from <ice@braindump.be>) id 1pT0UC-0001gt-Dj; Fri, 17 Feb 2023 14:09:14 +0100
Received: from smtpclient.apple (29.225-241-81.adsl-static.isp.belgacom.be [81.241.225.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id E09CAC036B; Fri, 17 Feb 2023 14:09:10 +0100 (CET)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
From: IJsbrand Wijnands <ice@braindump.be>
In-Reply-To: <0DD084D4-429B-4126-AC47-22471BCBA7A9@braindump.be>
Date: Fri, 17 Feb 2023 14:09:10 +0100
Cc: draft-eckert-bier-rbs@ietf.org, BIER WG <bier@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F5ECC551-341C-4C5E-98BF-28E4D9F11C43@braindump.be>
References: <Y3NpPev+bIhWrtyS@faui48e.informatik.uni-erlangen.de> <0DD084D4-429B-4126-AC47-22471BCBA7A9@braindump.be>
To: Toerless Eckert <tte@cs.fau.de>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-Originating-IP: 178.208.39.159
X-SpamExperts-Domain: mailprotect.be
X-SpamExperts-Username: 178.208.39.128/27
Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be
X-SpamExperts-Outgoing-Class: ham
X-SpamExperts-Outgoing-Evidence: Combined (0.19)
X-Recommended-Action: accept
X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT8W2DeE0jdfKmcb8zZRFpghPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wqL5ce0izo3MEwlThXh+L+Eq1uToV35zEggExruXqwDns7 zmR8SrJBKoHsJAkCbDqD2rMopwoVQz84tBAdBLvFyQLfXoabdmF7Z8uHfA5hh4XMG/R1XzYMjIdZ 9KYo/doEybI1sOftHmSKUCHCvcq0TzZjnkrrL1mACMw/UF0G0bQ7KakNnWEuMvWMJYJgW0TFw0bE FdwXp9O4Isj1H4iiJYN6Crh9DXUDEtWWsjsNUWDlGPaDR+Aes7asAZpVFyfMODodi5MLJiAvrVIi QFNhc8S+HKYI1vbaqYoREZsvVKq8YZ9/SG1CqFB/T9oOuGkszjGcI+mbLJLuOAP016dVWgH88tf6 uZ3Odz3W94IkDNey7wEf3rBXwmzCivpMYSIRN1GWdLWiieE4sApt6oWVGSRxJYEqfHH6e3h3i3L5 b/siHDX/ZpgnR2L6ZSxUhuCgUnzQUUh7zrY+gccQHlvFRbojusghAHJVSwcPHv0z3JA5Fxib54ho r19Rav1EA3X0VjYiWyhWVAgRTI92lX0U8pjOFfnWL8N84Gl+TAvkmIQpRkKgWi6P+HuUVk3o3aTB eNDGo37FEc/C+HZkCypl2eHIgfodXOAsKprebW4raQ4yiMdx93ZmHZ6F/fkurvTM8EEWwUuixhw/ LT/ICoTq1C9SYHs1HVkNOVbBoq352rVtcQ+zTxxVZMQuWFZ1NemnYhV4s0WHRXGZZPQzDltIAHOu 27cKJle450MdBm594FVdc2K+waea2lUOnotr/fNQvy23SZXSfMZ7RzHGH1l2naPKc3yQvxQmzKsA iXiBbMNyh3yk9X5DMy2QxfCWvswf4ngLmK0LObbZiXBeyQEpViU4oE+ncQYpfHQGnNPTwauNrRqm dKI/mhaL/v8+Pmh326zBXCRRkPNZOeZhl83ItgZkcRkCnoMzps1w8ZlyWp5OlwYUQ1ejeQ1GJqZG MW0WCHtA05KYHui9AUj7nFxAZyCgxZHINA6A5+7T9o6byzvDwAcft/nzfIptzPRrK2/ShgkK/IUj CNCeBQgjifLRQVNUvx4T911LgXOuhzWRBTEvuGslKTrRIXcXpFg5ivY=
X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/A2IcW9lT3C6JazSAaTGBHWY37N0>
Subject: Re: [Bier] Feedback on draft-eckert-bier-rbs-00
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Feb 2023 13:09:49 -0000

Hey Toerless,

Do you have a timeline in mind to address my questions?

Thx,

Ice.

> On 23 Jan 2023, at 18:26, IJsbrand Wijnands <ice@braindump.be> wrote:
> 
> Hey Toerless,
> 
> Did you address the issues I raised below?
> 
> Thx,
> 
> Ice.
> 
> Sent from my iPhone
> 
>> On 15 Nov 2022, at 11:26, Toerless Eckert <tte@cs.fau.de> wrote:
>> 
>> Thanks, Ice - also Tony/Greg feedback/mails..
>> 
>> want to incooporate feedback into draft updates, hence no quick reply here,
>> as to other discus here.
>> 
>> Cheers
>>   Toerless
>> 
>> 
>>> On Thu, Nov 10, 2022 at 01:32:51AM +0000, IJsbrand Wijnands wrote:
>>> Dear Authors,
>>> 
>>> Here is some feedback on the RBS encoding. This is based on my understanding of the draft and discussion with Toerless today.
>>> 
>>> 1. It seems that when a BIER router is parsing the RecursiveUnit, the length of the BitString is derived from the length of the BIFT Table on the router processing the packet. To me that seems very tricky as the length of the BIFT table might change when interfaces/adjacencies get added and removed. There might always be transient cases where the length of the BitString in the packet might be different from the router’s BIFT Table. If that happens, the complete parsing of the RBS packet goes to sh*t. It would be good to somehow add the length of the BitString inside the RBS header to prevent these cases from happening and be more defensive.
>>> 
>>> 2. The BIFT table has a Recursive flag to indicate if a BIER node has downstream receivers. This is also required to correctly parse the RBS header. In my mind this should not be a property of the BIFT table. A bier node might have nodes connected to it, but that doesn’t mean they are part of the tree. The recursive flag should be part of the encoded tree inside the RBS header.
>>> 
>>> Thx,
>>> 
>>> Ice.
>>> 
>> 
>> -- 
>> ---
>> tte@cs.fau.de
> 
> _______________________________________________
> BIER mailing list
> BIER@ietf.org
> https://www.ietf.org/mailman/listinfo/bier