Re: [Bier] Initial Shepherd's comment regarding draft-ietf-bier-ping
Senthil Dhanaraj <senthil.dhanaraj.ietf@gmail.com> Mon, 26 November 2018 10:17 UTC
Return-Path: <senthil.dhanaraj.ietf@gmail.com>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7BD13130DE5; Mon, 26 Nov 2018 02:17:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h9RKRK7K6lna; Mon, 26 Nov 2018 02:17:28 -0800 (PST)
Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5DB2C130E9B; Mon, 26 Nov 2018 02:17:28 -0800 (PST)
Received: by mail-ed1-x532.google.com with SMTP id d39so15273357edb.12; Mon, 26 Nov 2018 02:17:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KRVaoSBXTDOcCyICHiqtMZdePUeKp+DU542DreXPw5Q=; b=MuWGKL+HiXgXUag6L9LFtGpRwvkGVJ/vbRR6hcPUwaQPBiCrqs2ZutlpLiCxliW1LO oN900y+76KHVX0190zOhHC8NsBQTQrbYRjXPZ+35Z7Ymg7q6si3pGm6xRk6xeZWHGDtv eDlS8IMTW9eLG8bi4fTm4/bblwZuMxL7ly4WbVtK3FaiKUU6+XyZl8DY4a2gnTISSXVB xm9okCDqBGczur1UugCW8hftQ8sfaXJt/+0sNDceohTcPH54nABuMC/bCJd2katcdUHw 51378kSPtlW5X8P0jeHHkL0ztgyRkZyHZ9coEKU6CREOGYUiezFNpjndTPHokMD8yjhJ Gr6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KRVaoSBXTDOcCyICHiqtMZdePUeKp+DU542DreXPw5Q=; b=HihifPOkMr3u53BjTrFZeAijvJTge3ltTk2zsrqX6veyzQWMh1o2+GJY3jjxl6jMpA ioZizx0CcCPLc586/hE8O7PsrBGoasE270sLSV685Q4/KyT5gvLJxiXkxZPTUA3Hya7x z14z/TEI01oyCCEMvGYYkhFWsJbQGi+2f9q2Jfs71RrhBz7ORYctqRkx/RvI/ZMn9BbU EnxKm0U2/OU8J7f+DTy3VsjDL+GnTgqIeR22TNOAQjCgtTmpI5R7o3RVZVXEBBsaqvnn ZLaQ+/BpK+nhnUkDMEAsGEI2Q+OCXbHg5kZm7OQ6Ex1Veyd8oL9THpN9az0c6aPp/421 NzIg==
X-Gm-Message-State: AGRZ1gJTsiQlv7AZApUQmabhX9E/czFByNS5+TLFfYRolWOlNqot0ip1 0D//b2i9XRcIpeagvCFo6b3GDoS/4ks5dFoxT4Hw/CCb
X-Google-Smtp-Source: AJdET5djyC9NTGx3f3S1Nr9HlzT9ngF3YrWY7Gyodj2bEhMer9m6YNuesWUtehnqQVb68xyUJsGvd8HmRfefzvtkbM8=
X-Received: by 2002:a17:906:198b:: with SMTP id g11-v6mr19974620ejd.166.1543227446769; Mon, 26 Nov 2018 02:17:26 -0800 (PST)
MIME-Version: 1.0
References: <751040AB-8603-4088-9482-7EE0492E0203@contoso.com>
In-Reply-To: <751040AB-8603-4088-9482-7EE0492E0203@contoso.com>
From: Senthil Dhanaraj <senthil.dhanaraj.ietf@gmail.com>
Date: Mon, 26 Nov 2018 15:48:26 +0530
Message-ID: <CAG9=0bJxm=ArN9=M1o8GNVxQpBiAyCh3c5tvjAO0L+_5QSyJrg@mail.gmail.com>
To: mankamis@cisco.com
Cc: draft-ietf-bier-ping@ietf.org, bier@ietf.org
Content-Type: multipart/alternative; boundary="000000000000c5bc8f057b8ea31a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/GrQXUOufKLrae0yYBpVtCFNWvYc>
Subject: Re: [Bier] Initial Shepherd's comment regarding draft-ietf-bier-ping
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Nov 2018 10:17:31 -0000
A comment/suggestion on the draft (Sorry to mix it up with the Shepherd's review chain) ! I believe, the mechanism prescribed by the draft would be applicable and can be used as is for non-MPLS networks as well (ex: BIER-ETH). Considering this, We should change the description "BIER-MPLS Label" (in various sections of the draft) to "BIFT-id" ? Thanks, Senthil On Sun, Oct 28, 2018 at 5:05 AM Mankamana Mishra (mankamis) < mankamis@cisco.com> wrote: > Hi Authors, > > This document is generally in good shape. Have few comments as part of > initial shepherd review. > > > > > > 3.1. BIER OAM message format > > Proto This field is used to define if there is any data packet immediately > following the OAM payload which is used for passive Kumar, et al. Expires > April 24, 2019 [Page 4] Internet-Draft BIER Ping October 2018 OAM > functionality. This field is set to 0 if there is no data packet following > OAM payload. > > > > *Comment*: Are we expecting to have different value for proto field in > future ? Can you please add some more detail here ? > > > > QTF Querier Timestamp Format. When set to 2, the Timestamp Sent field is > (in seconds and microseconds, according to the Initiator’s clock) in NTP > format [RFC5905]. When set to 3, the timestamp format is in IEEE 1588-2008 > (1588v2) Precision Time Protocol format. Any other value SHOULD be > considered as sanity check > > > > *Comment: In future, do we expect some other values here ? are we > registering this field also with IANA ? * > > > > Return subcode To Be updated. > > > > *Comment: Can you please update the document ? * > > > > 3.2. Return Code > > 10 DDMAP Mismatch > > > > *Comment: * > > 1. *Can you please add detail about what is this Return code ? * > 2. *If TTL expires, what would be return code used by intermediate > node ? * > > > > When I flag is set, the Responding BFR SHOULD include the Incoming > SI-BitString TLV in Echo Reply message. > > *Comment : I think MUST would be more appropriate instead of SHOULD here > ? * > > > > 3.3.4.1.1. Multipath Entropy Data > > *Comment: Here M flag is using left most bit where as I was in previous > section using right most bit of flag. Should it also not be right most bit > ? * > > > > 4. Procedures This section describes aspects of Ping and traceroute > operations. While this document explains the behavior when Reply mode is > "Reply via BIER packet", the future version will be updated with details > about the format when the reply mode is "Reply via IP/UDP packet". > > *Comment: Does it mean, new document in future ? or this document is going > to get updated more ?* > > > > [RFC8296] proposes the BIER header with Entropy field that can be > leveraged to exercise all ECMP paths. The Initiator/BFIR will use > traceroute message to query each hop about the Entropy information for each > downstream paths. To avoid complexity, it is suggested that the ECMP query > is performed per BFER by carrying required information in BIER OAM message. > > > > *Comment: Is this document not talking only about Ping ? I see some > mention of Traceroute in document. If traceroute procedure is also > expected to be in this document, can we add some moreo detail about > procedure ?* > > > > 4.4. Receiving BIER Echo Request Sending a BIER OAM Echo Request to > control plane for payload processing is triggered as mentioned in section > 4.1. Any BFR on receiving Echo Request MUST send Echo Reply with Return > Code set to "Malformed Echo Request received", if the packet fails sanity > check. If the packet sanity check is fine, it SHOULD initiate the below set > of variables: > > *Comment: Can you please add detail about what sanity check we are talking > here ? * > > > > 4.5. Sending Echo Reply If Reply-Flag=0; BFR MUST release the variables > and MUST not send any response to the Initiator. If Reply-Flag=1, proceed > as below: > > *Comment: You might want to consider to have subsection of each > reply-flag. * > > > > > > > > Thanks > > Mankamana > > > _______________________________________________ > BIER mailing list > BIER@ietf.org > https://www.ietf.org/mailman/listinfo/bier >
- [Bier] Initial Shepherd's comment regarding draft… Mankamana Mishra (mankamis)
- Re: [Bier] Initial Shepherd's comment regarding d… Senthil Dhanaraj
- Re: [Bier] Initial Shepherd's comment regarding d… Nagendra Kumar Nainar (naikumar)