[Bier] Shepherd's review of draft-ietf-bier-bar-ipa

Greg Mirsky <gregimirsky@gmail.com> Wed, 09 September 2020 16:56 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 553293A0AB8; Wed, 9 Sep 2020 09:56:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vI7LrT5-HV7R; Wed, 9 Sep 2020 09:56:26 -0700 (PDT)
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 68B533A0ABA; Wed, 9 Sep 2020 09:56:26 -0700 (PDT)
Received: by mail-lj1-x22a.google.com with SMTP id c2so4445234ljj.12; Wed, 09 Sep 2020 09:56:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=NdX7ImzCMcnzP8Gld3nxucxrACx34Dhnv35MBjaxZCo=; b=K3vGzeHw3y/hZtQJvd0U8vdZ+xzGYGxwPYz1lRYlfVX2PMLbNGT8sbPfkMdk7dk/hu Wz+faZfFZbK9v667n2iqLH7iyK6hFv+xs9+Cmxk3lB1KMBiW+PEpPOI10iGFBWmn+938 FWgzM024YnsQfj9xpIzqPRFu3DXWPzBt9ClN3+HvdctF6g3WtEcIsQLf/e+lmXU/zLW+ zmUxdkPQjh5pqwqex6wO2mjJ5XQ/4td5QGVYywoPMlXYri6UXLOFmTq4x6e0yfjCtNFq 2u0KW1SV9IwSnvRUaWfGxtSAkcGymce9mc1DkJ+q2uP02MZWwq43AInEaPTFku7Xw4I2 gO9w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NdX7ImzCMcnzP8Gld3nxucxrACx34Dhnv35MBjaxZCo=; b=bIPIrRvDnMgL/ZXpVRdx+v1fn3FgSzcGvloDvjoPvihEuqcIJW/5hhlyZkFWNK1ojj XJQfOmGijsLm/VOxjhuVgXb72SizonBD8WF2m5+ELwEMhzkECgSFJgZaw473Nl8bccJu ZsTu15gKuCu6zAn+Fj8wH78UhUBN7kVosMovkVPGOXSYmj2spboj6ReWoPocexIvGQwv RGNBHUSYh+OZYtGvPCTb67eyTP6wC/2WQyoQjonfQciZCapyopeFdAx4lfy9A4mKWIDY RHZ6KhesQ1pGs3Vlp9SCGt2aZtEGaZPpmFzT2nmo4/C8kRqL9xU6RusqIgKR8ZwyyJSV XzPg==
X-Gm-Message-State: AOAM5325LU7Y9YL+nkPdHYrFr7Zaw2Y2b3YtYs8wItEXhoYzrtcCz0tC DxHCFZyO6J6t2KULgpADNhGhDP8PtgKcmXI3pZ8NrWXAp1s=
X-Google-Smtp-Source: ABdhPJzaUopR/j9bo3Hk6UE4ZgKm8Cv0iM5CY0qWcpPGhNGshI5NrhPBcFlQczFMb/ZouwJTPsod1mxg+z0JuTACRCg=
X-Received: by 2002:a05:651c:102c:: with SMTP id w12mr2442847ljm.8.1599670584088; Wed, 09 Sep 2020 09:56:24 -0700 (PDT)
MIME-Version: 1.0
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Wed, 09 Sep 2020 09:56:12 -0700
Message-ID: <CA+RyBmVqh0dtkK-8Lai7CEhJ2SGPw2qQnHmpAzC-khgDxj6UpQ@mail.gmail.com>
To: draft-ietf-bier-bar-ipa@ietf.org, BIER WG Chairs <bier-chairs@ietf.org>, BIER WG <bier@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000ec1b9605aee454a4"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/HfFa4JGOr1VRRzPxtZ0AmOQUH4o>
Subject: [Bier] Shepherd's review of draft-ietf-bier-bar-ipa
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Sep 2020 16:56:28 -0000

Dear WG Chairs,
we're waiting for one author to respond to the IPR poll on the draft.

Dear Authors,
thank you for the well-written document. The proposed solution is elegant
and presented clearly. I have several comments and questions. Also a number
of nits that may be worth your attention. First, comments and questions:

   - In Section 2 the requirement to provision BAR and IPA values uses
   SHOULD:

   For a particular sub-domain, all routers SHOULD be provisioned with
   and signal the same BAR and IPA values.

Do you think that the MUST is more suitable and would not require a change
of the text that follows?


   - Could the following benefit from the use of the normative language?

   It is expected that both the BAR and IPA values could have both
   algorithm and constraints semantics.
>From the text that follows, it seems that both semantics are required for a
router to calculate the underlay path. Is that correct? Also, is there a
default value of a semantic? If that is the case, it would be helpful to
state that explicitly.


   - There is a pair of requirements in Section 2:

   When a new BAR value is defined, its corresponding BC/BA semantics
   MUST be specified.  For a new IGP Algorithm to be used as a BIER IPA,
   its RC/RA semantics MUST also be clear.
The last sentence can benefit from mode details of what is required to make
RC/RA semantics clear. Would s/clear/clearly specified/ be acceptable?

Nits:

   - AFAIK, references are not used in an abstract text, instead reference
   an RFC as text, e.g., "RFC 8444 and RFC 8401".
   - rules for introducing abbreviations (Section 3.6 RFC 7322
   <https://tools.ietf.org/html/rfc7322#section-3.6>) explain that:

   Abbreviations should be expanded in document titles and upon first
   use in the document.  The full expansion of the text should be
   followed by the abbreviation itself in parentheses.

Several cases, e.g., BAR and IPA, don't follow that rule.


   - BFR (Section 2) needs expansion on the first use.
   - s/a IPA/an IPA/
   - s/a RCRA/an RCRA/
   - s/with semantics/ with the semantics/
   - s/are augmented/is augmented/
   - s/secuity/security/
   - s/thanks/thank/


Regards,
Greg