IETF Logo Mail Archive

Re: [Bier] draft-ietf-bier-lsr-non-mpls-extensions-02 shepherd review

"Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net> Wed, 07 February 2024 13:11 UTC

Return-Path: <zzhang@juniper.net>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5CA6C151092; Wed, 7 Feb 2024 05:11:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.004
X-Spam-Level:
X-Spam-Status: No, score=-2.004 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b="iBNIimML"; dkim=pass (1024-bit key) header.d=juniper.net header.b="WmBtivd4"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EescY7355fyY; Wed, 7 Feb 2024 05:11:25 -0800 (PST)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 34401C14F5EB; Wed, 7 Feb 2024 05:11:04 -0800 (PST)
Received: from pps.filterd (m0108162.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 417AaiCC006520; Wed, 7 Feb 2024 05:11:03 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h= from:to:subject:date:message-id:references:in-reply-to :content-type:mime-version; s=PPS1017; bh=Q3szY5XtgfBe6InwNwPevF Zn7a6Xkz0ClHXZRlFTm2M=; b=iBNIimMLod+qWgaYMp1C3EJlSt1DTVZYaREC53 kh498y7uGlxllbH8tvXSjPJmVuST9bJpvpx+gwJsPkU/cLKXIA45vOgjePu+6qvL YLgKbVcvXdAvqnOfMma5S/z/VprmG98pR0/SI0x2qN1BFvdnYzkgqiEHX0cBp8YY D0itbLyoqeZviqc5H7yylfv8zIzfB51U6Jkwk0fq2bZqewvaajUmJxlcyMC29jhr fNsApcrx2+lmLx1RMFKZLNmsZ1zRRtnyeX3QTERNMTTAv2z+/GqJU/I0+tziyarx uUCuaXITqhRUofPNRM0xxfjfmFfsG9kumwFoUzMnKtegPdSg==
Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazlp17010002.outbound.protection.outlook.com [40.93.14.2]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3w3028hn2t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Feb 2024 05:11:02 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ba+d3RankVd81XdSGSynAYysv3rHnwzvck0k6zwcUX5/IYS1o5OssVc3leYpcuBGM1TCIaoczawmFnIt5pSdb6Z49AIsnMAkD6rttIgxMHE3qbO/y6VF/l5Yv/Y+2tXai1+AMbIIcgVvG6jT3BcdycwVgccbZ0CutfrrMExYQ4GCkWNXiNV8a4FXZh/tsnmL5c4fJchY01B2um1dCdKYMXUUBsFC9a9twRcNDeyTSBDsvX//X42+US/URyO4E4cHvCz8zdYagjEmlYQpXASvDWkoAPkr4Dea4JymtQLZoSbNlA6xB2kfL0WRhcMRlh7JA+hDuepLABstGz4nOJRgJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q3szY5XtgfBe6InwNwPevFZn7a6Xkz0ClHXZRlFTm2M=; b=Ok8zk2TqieX6T9+Rb5uV6PGcu2L0hWB2fU2FTmbdEbz+8cIOqyZfKWyFx3+M5A1fhW9lfYhNA+Q02mttwTTI2or45cjRdQB2L3CIQIkPZRecROlk0HYAGuCt3r+4ZTBg5e6p/5vgQsex2/PyDqKWph7AXmms/ApBUgjBqt9Ofs3S8FgoHq1QPYNPHUsQPu/DWwcIPBgXgOyjlM/P6Ruwn4m+N363CC/iJR9Y0ANvpw0JdXON4kdeSj6sVP8CsKih66tqyCoVs7+HitdFeTNMTceUP5Te922ePNqp2KwTIV59OUEs0Qgxy+Gsh4U3/yoqUotQZ2eYe6l1v6GZRsh0bg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q3szY5XtgfBe6InwNwPevFZn7a6Xkz0ClHXZRlFTm2M=; b=WmBtivd4m76UyPBVhObWM0sKMILs99RhK8bMY1ZdJfW1aJvZ1CMIGBL1AcxMicEBRMIAMhDXOa9r6jBgtxfPZaqpufQ6YTlO6nn4b++MPHZTtlomcbtXgaIsI9RjYfFnIthCnh3l7Ebd+/J8R+Mejlf/larDFZxcLzaxvf+c5fM=
Received: from IA1PR05MB9550.namprd05.prod.outlook.com (2603:10b6:208:426::16) by SA1PR05MB8047.namprd05.prod.outlook.com (2603:10b6:806:1a0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.38; Wed, 7 Feb 2024 13:11:00 +0000
Received: from IA1PR05MB9550.namprd05.prod.outlook.com ([fe80::4c5d:def9:3e54:e076]) by IA1PR05MB9550.namprd05.prod.outlook.com ([fe80::4c5d:def9:3e54:e076%4]) with mapi id 15.20.7249.035; Wed, 7 Feb 2024 13:10:59 +0000
From: "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>
To: Huaimo Chen <hchen.ietf@gmail.com>, "bier@ietf.org" <bier@ietf.org>, "draft-ietf-bier-lsr-non-mpls-extensions@ietf.org" <draft-ietf-bier-lsr-non-mpls-extensions@ietf.org>
Thread-Topic: [Bier] draft-ietf-bier-lsr-non-mpls-extensions-02 shepherd review
Thread-Index: AQHaWVUfPDzMI2MHnEKDJ0ZUhJ05l7D+2x9Q
Date: Wed, 07 Feb 2024 13:10:59 +0000
Message-ID: <IA1PR05MB9550D835E1DDC2BABA801EA6D4452@IA1PR05MB9550.namprd05.prod.outlook.com>
References: <CAHJHfp=Je1EiNC95Up6=xv9eu9LuP3Yg8AZy2xuzSxZg5uFHNg@mail.gmail.com>
In-Reply-To: <CAHJHfp=Je1EiNC95Up6=xv9eu9LuP3Yg8AZy2xuzSxZg5uFHNg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=e89ec514-ad2e-4447-97ec-58a5fbe8642a; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=0633b888-ae0d-4341-a75f-06e04137d755; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2024-02-07T13:09:33Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: IA1PR05MB9550:EE_|SA1PR05MB8047:EE_
x-ms-office365-filtering-correlation-id: 8c9431df-b049-4b0c-ca5a-08dc27de3a7d
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: GSB348JwQ/kyaXu8xDvQ6z2R1obhDK+W9hEWKS7+b9mL3IIOcseUNEu17yVMCVwxO2pn4VaINj6RFAYsH9XsiTfVHXQxI+eTI2nNUXRzULsvQDmUQQJPehfpOKvgmwvIOpOERugSQqJbYb3hJ83sv2h02qZNtPrK5wTB/KU8mi9/uhpNAeRETikg6S18BzpCIUn2xQr55mi5aIfWd2QxYTCyx3IWlXtEprQTb9Mc5uRilJVbelLfFC/DoSZfmtC1D1kLCZv7xmJ2LfZHgSlSHPPF5RHIaArI2H8tr4vFFsnDBjvy+sv786PL5/tpEksNHBg6OJ5MsQqnjq3RGyT36CV4WMhUnZsxYHSXjnAUFeRjI4i2E69anoFCFagZsKYWbMy8jjcAcUn0o3yL1KLmFjdXoBLt7vMEgpETbAOEVTeHzU8VLvvgwn2sCTukjMN00irGya7sZLe/DJo10ZizBw85lg/sc5OAkgsDCpxmYgE6QIZh2ig26lyGyWpMaLGnFidmslP//8LeYTr0EbVFcMI01czJjBA0in2GbgdQYQBr2u7Eh1IK3C1G/vprh+VZ+BViXWlQBYp0NYfcBT5B7wxWApMQGjTJNx87n7GljlA=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR05MB9550.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(366004)(39860400002)(346002)(396003)(230922051799003)(230273577357003)(64100799003)(186009)(451199024)(1800799012)(2906002)(5660300002)(52536014)(55016003)(41300700001)(83380400001)(38100700002)(26005)(122000001)(86362001)(6506007)(9686003)(7696005)(66476007)(64756008)(53546011)(110136005)(66446008)(316002)(71200400001)(33656002)(478600001)(66556008)(966005)(66946007)(76116006)(166002)(9326002)(8676002)(8936002)(38070700009); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 4dC2HdpRRnuMuNye+E7mESD7d4AwBpKiYvTO6fbgUl37sgvjHJsFCMqmPwdvtH+XVsPYY5sUE8HKMXvRUBuKpWrsHuiM23tmyYsy7IqJC8CYNbUCAHlirAB1hH03eMNrA5GzFPcWBa6WrBwbxak17Jye7jrxISFRaY7hwhNw4Ct8yIrCaogXHv54OR+cvmh9oMBD6NYNOA8E5GV2Kbo4fACso7StokClXXUa6fanUS29hQ5SrZEWqklRiHE+w1m4R7f9nq5RmXZtH4uBIzliQ1Py5KgSjN/1UOFcx88At7TgJbnfHtkRBjc6jXatEKJu5U7Td6u9mgwZ4MK51z2rPmjNx0uiKjYAYbRGLkdiioOgICJXV75yt/RiTq5v9G+46Vx63PIE3PhkHtMdGr9tYcZVYRu10oQrzaWSbLU0FLJQl9c8Mztwo1YOWZYiZ8YBrSsm6v6t+d8Ymg7u68Ntrg4OJBKBptuP0ef4j64CD+i3wwwctvROdWoOmMYiHX3yUPISy/ICu4edJtrx6jxhjcZENFQIk3gjB4uRX0k4i+EgfByoqBourrAq7VIwXRGs1QRJMFJ+hwcBXPpIdEoo2HW5gw7cGaUV0ZtZ7zVyc1/W1rn1IKJs6Um8CBF2P6b2uwpJ68QWaWWlFOthSqEiRfoLdYUgeghOEmE8SV3dB4GimuwVVzLbj4/LJvovZ4/OW3QIAZ94FFR7A5tqAbDkhoS/3arI18LQ2GWWUoM4FY5E6ztJ14JB/fvN5KdjxySINGKeddNSl5lxA8zJ/bK+JbOJ0E7OfAlUn2YQGPQhVNwaqJ4hPddk+WFadqYXZdZOHp/1YA52BgKBVdZorW9XIHVcEcO9M1QPSzZ7rC2Cy9YVPTannXCCKRaoOtRzcK+WnKGElKurMdGk1F137F7Ik+Xm08FUXZ844vTdfB9+G0DSXWXya9Q2uwcDuk06Kx+Oc+QAfQjl3lkEcZBeL1cIuwkcex5xDZScI/yAjkX78IlkgmZgIYSOuYbVCTSnIABLsVBqqQoWlBHLGCvUT7JM4btW4jDU1Uzw6bDLCNc5UQEVUyPoGwUB3z86AhyFY12VyT6s4WJsfeLWiobtzCsfiMLmGU6m+u5ja7KR1+WLuqVz/nh7PB8X9rZSrkSNJACBOqmoluvlZlto2cv5MsKD9U3VXN0jWPHq+L6Uowzdu8Qvwe7QHhlUUOjg8Z/nS3YGc+gYGurApAHY55E+vVnQupPbans4dU7RkH/T6/A+Tx6sxL9a/NXpA79kyTEoYtCr5J+bvJyRBuEkG/Xtu+8ZRYAsp5VXXd3MUbkaWH0H5G9FTlOpzP6+Fz3iz+bNzNwynKp+7U7w9EGsK7LZKQmfza4oa4JG7pz64H/h7rRSXCvs5bm8f/XyioGD4LOx1hSRpnrEpj37vF9GOPZ0BPGADzIQZ4MmfSfg3v5veEiEg6gh2N38P/BuvMSYRym7w4LrPSTHRhypDKt3kh/yyFQXADTMigrX9KfzGY6GCdsjFU2Eu0EUSlwBnl1VsmgK9C9RzP7hOep0aT23pUBmD4OVDYz20R6qZdgxBTjrXj051RIWOU/h4HEegzMtB6zMdN6Y
Content-Type: multipart/alternative; boundary="_000_IA1PR05MB9550D835E1DDC2BABA801EA6D4452IA1PR05MB9550namp_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR05MB9550.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c9431df-b049-4b0c-ca5a-08dc27de3a7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2024 13:10:59.7265 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o8cheuNmHEm9eGQddleAwIwxj0dOj5A0vsjt32ie5OgZ9iELVN+Y41LbdWxmM+ad+xJyY2vWWPfdifVJKS8NoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR05MB8047
X-Proofpoint-ORIG-GUID: LmRnJxMMDaQ3VRLr_g80q6Bl62cAd8B-
X-Proofpoint-GUID: LmRnJxMMDaQ3VRLr_g80q6Bl62cAd8B-
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-07_04,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 clxscore=1015 impostorscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402070098
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/TVIVvjS9LODHO3HMkigvqRvN9m0>
Subject: Re: [Bier] draft-ietf-bier-lsr-non-mpls-extensions-02 shepherd review
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2024 13:11:29 -0000

Hi Huaimo,

Thank you for your review and write-up. I have addressed your comments below and fixed an idnit reported in your shepherd’s writeup in the latest revision -03.

Jeffrey



Juniper Business Use Only
From: BIER <bier-bounces@ietf.org> On Behalf Of Huaimo Chen
Sent: Tuesday, February 6, 2024 6:35 PM
To: bier@ietf.org; draft-ietf-bier-lsr-non-mpls-extensions@ietf.org
Subject: [Bier] draft-ietf-bier-lsr-non-mpls-extensions-02 shepherd review

[External Email. Be cautious of content]

Hi Authors,

    I have reviewed the document and written the initial shepherd review.
https://datatracker.ietf.org/doc/draft-ietf-bier-lsr-non-mpls-extensions/shepherdwriteup/<https://urldefense.com/v3/__https:/datatracker.ietf.org/doc/draft-ietf-bier-lsr-non-mpls-extensions/shepherdwriteup/__;!!NEt6yMaO-gk!DPcDeqS50UUKoOQ7zzl7crhCCPSNefpROOnQ5SUDzTwIfw0xoRp1dSdzQYgZh_x89j3BHF_d26lYCJnA6RAB$>

    The document is straight forward. I have some comments below:
     1) In Section 4.  Security Considerations, it is better to add some
        texts about security concerns for the extensions to OSPFv3.
     2) For IS-IS Sub-Sub-TLV, sub-sub-TLV and Sub-sub-TLV are used in the document.
        It seems better to use one format consistently.
        In IS-IS TLV codepoints, Sub-Sub-TLV is used.
        For IS-IS Sub-TLV, it is similar.
     3) For OSPF Sub-TLV, Sub-TLV and sub-TLV are used in the document.
        It is better to use one format consistently.

Best Regards,
Huaimo

v2.23.0 | Report a Bug | By Email