[Bier] draft-ietf-bier-lsr-non-mpls-extensions-02 shepherd review
Huaimo Chen <hchen.ietf@gmail.com> Tue, 06 February 2024 23:35 UTC
Return-Path: <hchen.ietf@gmail.com>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F040EC14F69A; Tue, 6 Feb 2024 15:35:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UmGchHwyE_iE; Tue, 6 Feb 2024 15:34:59 -0800 (PST)
Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C5412C14F618; Tue, 6 Feb 2024 15:34:59 -0800 (PST)
Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-dc730e5d8bdso27301276.0; Tue, 06 Feb 2024 15:34:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707262499; x=1707867299; darn=ietf.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=LWM1YcuxErB6l6S0yWvGlzZ3qucw6FNkJD7GyvpaWn8=; b=br9Czncy6+hBKQhvP0pudmdksAPrfajfrSFseqk3EC91z77EVPyxA9uDz8lbelo2M8 tK2szNPbrphSjGJV4i/WNjXId/fTQ84ZFvcKUVh7aGe30OZwgQsem7qLDp67BFnsjao+ 6HrVdQA44QVVj9GK2Lz91AqUjww1P5wi74SIqw2VTAj8Gktsw7og04YuwTuc4SseevP7 DsHBUdvJ3xT5BYQF3hR6UeQtaB6aPvID6iex7zH33eO+cVdvLmsxG9JnM/jNUsaV6tw8 J4nWQGm/df24PH7twCw3U47OnYbjOPKdyNYKg5AmJ/HfvnH5eE8nVbwFn6QdjRUsd44e VNNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707262499; x=1707867299; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LWM1YcuxErB6l6S0yWvGlzZ3qucw6FNkJD7GyvpaWn8=; b=OMKukUHessCXLz05e1bhoN/ngfD4Uyy3n8vTWgk0VKeK6Hvt9GSg+dbmSGADML+uvj 60dOiPXhWMzWRCMoJyIHwVka8YhVqtMwUmDDFbZCrnp1SqqW5s7WyifzquaagptxBPpy yIfmw4OBEhMkK5LvlFFWJOGXGPhSke4mqrV5SrLZlR2rueOcK6tnKv4lXvBVb2MxkkSA i2+cd1BWjopQEECOAScyYMDGPzAHFDS5DebKfFzs6Iq5R5p6SNMYVEbA6F3aaZQLm1TR F7H9Mm/Vdy4wGo4UZuan8+ys3CCE/VgR/H0d2VpGmKOjF32iQt0zxzhwa/PEznKtHoof iDvw==
X-Gm-Message-State: AOJu0YwnnDCh3QQPmxQn+DKEkxis6x3tgZBcuYvGSQnuBEnp32FR0Xs/ DoAPW56z6sbQz7BM1R4b4/gNyi3i+WqeUQtUZEW5ulEgYDb7f4gtQR0VNsyzJ3cLXvBKvtGgq7D ClHcp0eJ21hp69NOI0vVZQQCSqoe5gYu3Nj8=
X-Google-Smtp-Source: AGHT+IGmSy7LQLv7uqemQIJIqBAm+jzzfYBJmtwGZJ7h2a8Cil8IIIVjboYKlQ2swN21TJ4kQMXEkfaTrZKDTeZrk9U=
X-Received: by 2002:a25:ad23:0:b0:dc6:4713:bbf1 with SMTP id y35-20020a25ad23000000b00dc64713bbf1mr3066300ybi.21.1707262498603; Tue, 06 Feb 2024 15:34:58 -0800 (PST)
MIME-Version: 1.0
From: Huaimo Chen <hchen.ietf@gmail.com>
Date: Tue, 06 Feb 2024 18:34:47 -0500
Message-ID: <CAHJHfp=Je1EiNC95Up6=xv9eu9LuP3Yg8AZy2xuzSxZg5uFHNg@mail.gmail.com>
To: bier@ietf.org, draft-ietf-bier-lsr-non-mpls-extensions@ietf.org
Content-Type: multipart/alternative; boundary="000000000000c487510610bf06fd"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/pIIOuW5-fenS8ueMvhM3l1aAVLE>
Subject: [Bier] draft-ietf-bier-lsr-non-mpls-extensions-02 shepherd review
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Feb 2024 23:35:02 -0000
Hi Authors,
I have reviewed the document and written the initial shepherd review.
https://datatracker.ietf.org/doc/draft-ietf-bier-lsr-non-mpls-extensions/shepherdwriteup/
The document is straight forward. I have some comments below:
1) In Section 4. Security Considerations, it is better to add some
texts about security concerns for the extensions to OSPFv3.
2) For IS-IS Sub-Sub-TLV, sub-sub-TLV and Sub-sub-TLV are used in the
document.
It seems better to use one format consistently.
In IS-IS TLV codepoints, Sub-Sub-TLV is used.
For IS-IS Sub-TLV, it is similar.
3) For OSPF Sub-TLV, Sub-TLV and sub-TLV are used in the document.
It is better to use one format consistently.
Best Regards,
Huaimo
- [Bier] draft-ietf-bier-lsr-non-mpls-extensions-02… Huaimo Chen
- Re: [Bier] draft-ietf-bier-lsr-non-mpls-extension… Jeffrey (Zhaohui) Zhang
- Re: [Bier] draft-ietf-bier-lsr-non-mpls-extension… Huaimo Chen