IETF Logo Mail Archive

Re: [Bier] Comments on draft-chh-bier-bier-yang-00

hu.fangwei@zte.com.cn Thu, 23 July 2015 12:46 UTC

Return-Path: <hu.fangwei@zte.com.cn>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1613D1AC3B9; Thu, 23 Jul 2015 05:46:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.76
X-Spam-Level:
X-Spam-Status: No, score=-101.76 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_CHARSET_FARAWAY=2.45, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4ymg2971wKCe; Thu, 23 Jul 2015 05:46:29 -0700 (PDT)
Received: from mx5.zte.com.cn (mx5.zte.com.cn [63.217.80.70]) by ietfa.amsl.com (Postfix) with ESMTP id 966EE1AC3B3; Thu, 23 Jul 2015 05:46:28 -0700 (PDT)
Received: from zte.com.cn (unknown [192.168.168.119]) by Websense Email Security Gateway with ESMTP id 04063DD4A9A45; Thu, 23 Jul 2015 20:46:22 +0800 (CST)
Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Websense Email Security Gateway with ESMTPS id 2E0C498D1EB0A; Thu, 23 Jul 2015 20:46:22 +0800 (CST)
Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id t6NCkKY5021098; Thu, 23 Jul 2015 20:46:20 +0800 (GMT-8) (envelope-from hu.fangwei@zte.com.cn)
In-Reply-To: <D1D69FF7.DA1A2%rrahman@cisco.com>
References: <D1D69FF7.DA1A2%rrahman@cisco.com>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
MIME-Version: 1.0
X-KeepSent: 10287296:9505B2D3-48257E8B:0045E836; type=4; name=$KeepSent
X-Mailer: Lotus Notes Release 8.5.3 September 15, 2011
Message-ID: <OF10287296.9505B2D3-ON48257E8B.0045E836-48257E8B.0046291E@zte.com.cn>
From: hu.fangwei@zte.com.cn
Date: Thu, 23 Jul 2015 20:46:17 +0800
X-MIMETrack: Serialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2015-07-23 20:46:20, Serialize complete at 2015-07-23 20:46:20
Content-Type: multipart/alternative; boundary="=_alternative 0046291B48257E8B_="
X-MAIL: mse01.zte.com.cn t6NCkKY5021098
Archived-At: <http://mailarchive.ietf.org/arch/msg/bier/YdRrVdBfkwnS21DqRHkIEySDH24>
Cc: "draft-chh-bier-bier-yang@tools.ietf.org" <draft-chh-bier-bier-yang@tools.ietf.org>, "bier@ietf.org" <bier@ietf.org>, BIER <bier-bounces@ietf.org>
Subject: Re: [Bier] Comments on draft-chh-bier-bier-yang-00
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2015 12:46:32 -0000

Hi, Rahman,

Thanks for your comments, we will correct it based on your suggestion.

Regards
Fangwei.




"Reshad Rahman (rrahman)" <rrahman@cisco.com> 
发件人:  "BIER" <bier-bounces@ietf.org>
2015-07-23 19:43

收件人
"draft-chh-bier-bier-yang@tools.ietf.org" 
<draft-chh-bier-bier-yang@tools.ietf.org>, 
抄送
"bier@ietf.org" <bier@ietf.org>
主题
[Bier] Comments on draft-chh-bier-bier-yang-00






Hi authors,
I tried to pyang the model in the draft and ran into quite a few errors. I 
stopped after the 4 below (these are basic YANG errors, wasn’t even using 
strict/ietf option)
Once you fix these errors please compile with ―ietf option (sricter rules 
regarding ordering of statements, requiring description etc etc)
Please follow RFC6087 guidelines e.g. use of <CODE BEGINS>, <CODE ENDS> 
etc
Finally, please use the validator @ http://www.yangvalidator.com/

Regards,
Reshad.

ERRORS

No “” for the contact
ietf-bier.yang:34: error: unterminated statement definition for keyword 
"contact", looking at L

Extra “ in "reference "draft-chen-bier-bier-yang-00”;
59: error: unterminated statement definition for keyword "reference", 
looking at d

Missing ; in key "sub-domain-id"
125: error: unterminated statement definition for keyword "key", looking 
at l

Missing ; in type if:interface-ref
154: error: unterminated statement definition for keyword "type", looking 
at }


_______________________________________________
BIER mailing list
BIER@ietf.org
https://www.ietf.org/mailman/listinfo/bier

v2.23.0 | Report a Bug | By Email