IETF Logo Mail Archive

[Bier] Comments on draft-chh-bier-bier-yang-00

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Thu, 23 July 2015 11:43 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BF8071AC445 for <bier@ietfa.amsl.com>; Thu, 23 Jul 2015 04:43:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VXPvIL-ljKJz for <bier@ietfa.amsl.com>; Thu, 23 Jul 2015 04:43:28 -0700 (PDT)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49B1D1AC438 for <bier@ietf.org>; Thu, 23 Jul 2015 04:43:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3400; q=dns/txt; s=iport; t=1437651804; x=1438861404; h=from:to:cc:subject:date:message-id:mime-version; bh=c7uPK3+VO07Id60p5mrAooXVmyCKOQc6po/y2A93QzU=; b=h1KVkXuyOR2eavz8WJjFAjAXbej6LiLbqXU5tQ97qsxaRY39DkVgzuej lWd5P4OmHTll91N4aIPpk4fmy/lr8XywllxlUn9U9Ymp7Th8W1ZmcJ0ZV +VjPGK563wxAwUzh3FLVFudsR6yu80eq83d5ACkGwui8hBTc7ghnRJu2A o=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AlBQBp0rBV/5JdJa1bgkhNVG+7XoFxhgWBSToSAQEBAQEBAX8LhCYEeRIBDANxJwQOiDPLJQEBAQEBBQEBAQEBAQEBGpAbNxCEIwWRZIJ8AYw5gUSEHZM6JoN8gXUlHIEEAQEB
X-IronPort-AV: E=Sophos;i="5.15,530,1432598400"; d="scan'208,217";a="171578268"
Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by alln-iport-4.cisco.com with ESMTP; 23 Jul 2015 11:43:23 +0000
Received: from xhc-rcd-x14.cisco.com (xhc-rcd-x14.cisco.com [173.37.183.88]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id t6NBhNxR032669 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 23 Jul 2015 11:43:23 GMT
Received: from xmb-rcd-x03.cisco.com ([169.254.7.176]) by xhc-rcd-x14.cisco.com ([173.37.183.88]) with mapi id 14.03.0195.001; Thu, 23 Jul 2015 06:43:23 -0500
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: "draft-chh-bier-bier-yang@tools.ietf.org" <draft-chh-bier-bier-yang@tools.ietf.org>
Thread-Topic: Comments on draft-chh-bier-bier-yang-00
Thread-Index: AQHQxTzHluN4ZST+lE6TfyMLQZNpsA==
Date: Thu, 23 Jul 2015 11:43:23 +0000
Message-ID: <D1D69FF7.DA1A2%rrahman@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.5.2.150604
x-originating-ip: [10.86.251.23]
Content-Type: multipart/alternative; boundary="_000_D1D69FF7DA1A2rrahmanciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/bier/ZnO1-Ugx8bh8UGRkOPUWS4jOWZo>
Cc: "bier@ietf.org" <bier@ietf.org>
Subject: [Bier] Comments on draft-chh-bier-bier-yang-00
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2015 11:43:34 -0000

Hi authors,

  *   I tried to pyang the model in the draft and ran into quite a few errors. I stopped after the 4 below (these are basic YANG errors, wasn’t even using strict/ietf option)
  *   Once you fix these errors please compile with —ietf option (sricter rules regarding ordering of statements, requiring description etc etc)
  *   Please follow RFC6087 guidelines e.g. use of <CODE BEGINS>, <CODE ENDS> etc
  *   Finally, please use the validator @ http://www.yangvalidator.com/

Regards,
Reshad.

ERRORS

No “” for the contact
ietf-bier.yang:34: error: unterminated statement definition for keyword "contact", looking at L

Extra “ in "reference "draft-chen-bier-bier-yang-00”;
59: error: unterminated statement definition for keyword "reference", looking at d

Missing ; in key "sub-domain-id"
125: error: unterminated statement definition for keyword "key", looking at l

Missing ; in type if:interface-ref
154: error: unterminated statement definition for keyword "type", looking at }

v2.23.0 | Report a Bug | By Email