Re: [Bier] Lars Eggert's No Objection on draft-ietf-bier-evpn-12: (with COMMENT)

["Jeffrey (Zhaohui) Zhang" <[e-mail]>]

Hi Lars,

Thanks for your review and comments. I've posted the -13 revision that addresses comments from you and Rob: https://author-tools.ietf.org/iddiff?url1=draft-ietf-bier-evpn-12&url2=draft-ietf-bier-evpn-13&difftype=--html.

Please see zzh> below for some clarifications.


Juniper Business Use Only
-----Original Message-----
From: Lars Eggert via Datatracker <[e-mail]>
Sent: Thursday, November 30, 2023 5:28 AM
To: The IESG <[e-mail]>
Cc: [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]
Subject: Lars Eggert's No Objection on draft-ietf-bier-evpn-12: (with COMMENT)

[External Email. Be cautious of content]


Lars Eggert has entered the following ballot position for
draft-ietf-bier-evpn-12: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://urldefense.com/v3/__https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/__;!!NEt6yMaO-gk!HB1vm0e_jI4iCEmqAH11hVqltLD1wzYbdOOpYK18-epUYRKxJJfmNpFwcAgic2h3wT_dF5T2GrqX3hQ$
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://urldefense.com/v3/__https://datatracker.ietf.org/doc/draft-ietf-bier-evpn/__;!!NEt6yMaO-gk!HB1vm0e_jI4iCEmqAH11hVqltLD1wzYbdOOpYK18-epUYRKxJJfmNpFwcAgic2h3wT_dF5T2LZZ-SQ0$



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-bier-evpn-12

CC @larseggert

## Comments

### Section 2, paragraph 4
```
     *  "Tunnel Type".  The same codepoint 0x0B that IANA has assigned for
        BIER for MVPN [RFC8556] is used for EVPN as well.
```
Should this document update RFC8556? It reuses the 0x0B codepoint, but the definition of "MPLS label" (and "Flags"?) seems to be broader/different than that in RFC8556?

Zzh> I tend to think it does not update RFC8556 (for IP VPN). The encoding and semantics are the same, even though in RFC8556 the label identifies a L3vpn and in this document (for Ethernet VPN) it identifies an ethernet vpn (Bridge Domain specifically).

### Section 2, paragraph 3
```
     *  "Tunnel Identifier".  This field contains three subfields for
        BIER.  The text below is exactly as in [RFC8556].
```
It would be better to normatively cite the relevant section in RFC8556 rather than to replicate its text here. (If that part of RFC8556 is ever updated by another RFC, the copy here will be inconsistent.)

Zzh> That's what I would like to do as well, but I've seen comments the other way before for another document 😊

## Nits

All comments below are about very minor potential issues that you may choose to address in some way - or ignore - as you see fit. Some were flagged by automated tools (via https://urldefense.com/v3/__https://github.com/larseggert/ietf-reviewtool__;!!NEt6yMaO-gk!HB1vm0e_jI4iCEmqAH11hVqltLD1wzYbdOOpYK18-epUYRKxJJfmNpFwcAgic2h3wT_dF5T2NIu9VI4$ ), so there will likely be some false positives. There is no need to let me know what you did with these suggestions.

### Typos

#### Section 4.1.1, paragraph 2
```
-        packet after the ethernet header, the IMET route originated for
-                         ^
+        packet after the Ethernet header, the IMET route originated for
+                         ^
```
Zzh> Fixed in the -13 revision.
Zzh> Thanks a lot!
Zzh> Jeffrey

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the [`ietf-comments` tool][ICT] to automatically convert this review into individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://urldefense.com/v3/__https://github.com/mnot/ietf-comments/blob/main/format.md__;!!NEt6yMaO-gk!HB1vm0e_jI4iCEmqAH11hVqltLD1wzYbdOOpYK18-epUYRKxJJfmNpFwcAgic2h3wT_dF5T2lJzNDEg$
[ICT]: https://urldefense.com/v3/__https://github.com/mnot/ietf-comments__;!!NEt6yMaO-gk!HB1vm0e_jI4iCEmqAH11hVqltLD1wzYbdOOpYK18-epUYRKxJJfmNpFwcAgic2h3wT_dF5T2j_u1IwY$
[IRT]: https://urldefense.com/v3/__https://github.com/larseggert/ietf-reviewtool__;!!NEt6yMaO-gk!HB1vm0e_jI4iCEmqAH11hVqltLD1wzYbdOOpYK18-epUYRKxJJfmNpFwcAgic2h3wT_dF5T2NIu9VI4$