Re: [bmwg] I-D Action: draft-ietf-bmwg-ipflow-meth-06.txt

Paul Aitken <paitken@cisco.com> Sun, 22 January 2012 17:35 UTC

Return-Path: <paitken@cisco.com>
X-Original-To: bmwg@ietfa.amsl.com
Delivered-To: bmwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 42AE421F8533 for <bmwg@ietfa.amsl.com>; Sun, 22 Jan 2012 09:35:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.28
X-Spam-Level:
X-Spam-Status: No, score=-10.28 tagged_above=-999 required=5 tests=[AWL=0.319, BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wU2jjNvY8ZjT for <bmwg@ietfa.amsl.com>; Sun, 22 Jan 2012 09:35:53 -0800 (PST)
Received: from ams-iport-2.cisco.com (ams-iport-2.cisco.com [144.254.224.141]) by ietfa.amsl.com (Postfix) with ESMTP id 3389C21F853C for <bmwg@ietf.org>; Sun, 22 Jan 2012 09:35:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=paitken@cisco.com; l=1262; q=dns/txt; s=iport; t=1327253753; x=1328463353; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=jvTN/Rcy4QvNOtjx9lfj4kvLHu1/DceVWEVSWXo1GzE=; b=Pn1x+wrXSdBqMp07VXp3hX6LjT24XUkXsMAQpk3GUi/Ro+D7FXE0W5A4 /unSQLfHOc5fEvAMIBNMoqRy+x9M0QoFHkwLenfeodHP6dagXHRsTrpdy 0kFTdTksEpxjKjNBQD6HKbrU+jla7N7e7TqyLWMn+hjsEbc1XHxEh9fh1 M=;
X-IronPort-AV: E=Sophos;i="4.71,552,1320624000"; d="scan'208";a="64310296"
Received: from ams-core-4.cisco.com ([144.254.72.77]) by ams-iport-2.cisco.com with ESMTP; 22 Jan 2012 17:35:52 +0000
Received: from [10.61.98.151] (dhcp-10-61-98-151.cisco.com [10.61.98.151]) by ams-core-4.cisco.com (8.14.3/8.14.3) with ESMTP id q0MHZpq6010408; Sun, 22 Jan 2012 17:35:52 GMT
Message-ID: <4F1C48F8.7020402@cisco.com>
Date: Sun, 22 Jan 2012 17:35:52 +0000
From: Paul Aitken <paitken@cisco.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Lightning/1.0b2 Thunderbird/3.1.16
MIME-Version: 1.0
To: "Jan Novak (janovak)" <janovak@cisco.com>, Al Morton <acmorton@att.com>
References: <20120122124957.12111.97214.idtracker@ietfa.amsl.com> <C95CC96B171AF24CA1BB6CA3C52D0BA001868247@XMB-AMS-212.cisco.com>
In-Reply-To: <C95CC96B171AF24CA1BB6CA3C52D0BA001868247@XMB-AMS-212.cisco.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: bmwg@ietf.org
Subject: Re: [bmwg] I-D Action: draft-ietf-bmwg-ipflow-meth-06.txt
X-BeenThere: bmwg@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Benchmarking Methodology Working Group <bmwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bmwg>, <mailto:bmwg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/bmwg>
List-Post: <mailto:bmwg@ietf.org>
List-Help: <mailto:bmwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bmwg>, <mailto:bmwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Jan 2012 17:35:54 -0000

Jan,

Thanks for the revised draft.

I have three minor editorial comments arising from the additional edits 
you made.
These could potentially be handled in the AUTH48 review. See below.


Al,

I'm happy to approve this draft. Thanks to Jan for all his hard work and 
patience.


P.



In 4.3.6, please re-add the deleted "a":

   "The MPLS forwarding performance document [RFC5695] specifies a number"
                                                                 ^


In 4.5, where you change the text to:

     "situations without packet, flow or export sampling",

Please use a serial (Oxford) comma to avoid ambiguity: "situations 
without packet, flow, or export sampling",

See http://en.wikipedia.org/wiki/Serial_comma#Ambiguity



Immediately above section 5.2, please re-add the deleted "the":

     "if the implementation follows the [IPFIX-CONFIG] document"
                                    ^^^




On 22/01/12 12:53, Jan Novak (janovak) wrote:
> Hi,
> I have just posted a new version addressing
> the comments from the latest review.
>
> Jan
>
> The climate of Edinburgh is such that the weak succumb young ....
> and the strong envy them.
>                                   Dr. Johnson