IETF Logo Mail Archive

Re: [calsify] Benjamin Kaduk's No Objection on draft-ietf-calext-jscalendar-31: (with COMMENT)

Neil Jenkins <neilj@fastmailteam.com> Thu, 15 October 2020 04:01 UTC

Return-Path: <neilj@fastmailteam.com>
X-Original-To: calsify@ietfa.amsl.com
Delivered-To: calsify@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 37FDA3A0858; Wed, 14 Oct 2020 21:01:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmailteam.com header.b=WyRFfuBQ; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=KsI/NUJG
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id go1VxjZ-1BJT; Wed, 14 Oct 2020 21:01:01 -0700 (PDT)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 62C483A0869; Wed, 14 Oct 2020 21:01:01 -0700 (PDT)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 8D51A5C0191; Thu, 15 Oct 2020 00:01:00 -0400 (EDT)
Received: from imap7 ([10.202.2.57]) by compute3.internal (MEProxy); Thu, 15 Oct 2020 00:01:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= fastmailteam.com; h=mime-version:message-id:in-reply-to :references:date:from:to:cc:subject:content-type; s=fm3; bh=Jc8P yhFCXmRbtal/FE3pSxEuhT1BmrpUKbAnGzvfdgU=; b=WyRFfuBQ3KE9E8Smc4z/ umyz1O94rdQDfdPZswk3XlO7eGMwUOo7BQbFKZaSQFkdLuVwN3B72xwL9yK/O+Yt q89GIzyeA4rrbsoHG28Uz/kFCl8XoffVIVIe1kzAi67FfX42XGj3vNp2PhbO62pW rSnI6MfiQ6aOaVre1U4JISgSVCANrlPwnYzKZnp4OHzCR61Lj3RCrRp8QwSAwwho ASamwnYp9HpmtlpBDi9YnJLSrhsuIW7gqhMmX47rN1t+zYu/fXmbG46WooC0ISR1 gHlBS3LChws2YGmdz87QidsAxd65xQLb5RXk4A6bi+nRwyuIAPz69b2BWN0fqLs/ vw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Jc8Pyh FCXmRbtal/FE3pSxEuhT1BmrpUKbAnGzvfdgU=; b=KsI/NUJGA9z/qW5a0eypfw p3b7sN2lhc5TiUc/niHMjQ0Qn6o2gUF0EiQgAPxu/+NXOcnzBbKJw2RzIjWahz2s VDjIUGTzQg2uh0kKTsg1qMqr4W7GaWWpfAUbjubBaWJ54IM8rUnVf4ZVkYwraG37 Ys+JhInRsbVy6bv7wHiLELi8yPYHjKO7R26qnWgu1uY3shxWvX10iLTrpLt821XV J+eAFGZhzjij6lItQFPNySaqPNhpLrUfkQnSbExUShf+khEbBMqlT7c0sZVJZZI7 FPCRDdBiScNCXSN4Fi5QX6EdMFT+PjIp1pM4dELTPiTPQaHrrQaPWR0pOrQNfQbw ==
X-ME-Sender: <xms:e8mHX4ce8Fb9meSVgNxEVXyCn6y5oMmyf0YujpClpF1YrMXpnC61OA> <xme:e8mHX6NlFD4tnXOcINXgH-Yz-_EbTJG7Vg9WFNCMNLBreKCRibNWlC5kQWPSAcreu AMxjxL2fUWrLQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedriedvgdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsegrtderreerreejnecuhfhrohhmpedfpfgvihhl ucflvghnkhhinhhsfdcuoehnvghilhhjsehfrghsthhmrghilhhtvggrmhdrtghomheqne cuggftrfgrthhtvghrnhepheeuhfdujedtieevkedvhfffgfelfeelhfefkeehhfekleek hfefueefveffjeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepnhgvihhljhesfhgrshhtmhgrihhlthgvrghmrdgtohhm
X-ME-Proxy: <xmx:e8mHX5gQpMUQ8kf6O_C4cZL_hoBgkEydNiluv7FKWh8iRGUmadFIRQ> <xmx:e8mHX98Mx-54EQC9FHXngw56-Z61dulbPMn2eC-9fTdoTj9t6P6FIQ> <xmx:e8mHX0uZKPwRPCJeTKvY9dC1bguyDwoSbBgBHYejuTYxhcLhqEebRA> <xmx:fMmHX2IcJdugpW0x7L_zFVk2VJsjJAjcFscfnmpnZqhLTzwXNyqRaQ>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id ADCFA18009D; Thu, 15 Oct 2020 00:00:59 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.3.0-489-gf39678d-fm-20201011.001-gf39678d0
Mime-Version: 1.0
Message-Id: <c94cdbca-e24c-47eb-91c7-8d5ecb45aa19@dogfood.fastmail.com>
In-Reply-To: <160264415431.16518.1057616138324026764@ietfa.amsl.com>
References: <160264415431.16518.1057616138324026764@ietfa.amsl.com>
Date: Thu, 15 Oct 2020 15:00:59 +1100
From: Neil Jenkins <neilj@fastmailteam.com>
To: Benjamin Kaduk <kaduk@mit.edu>, iesg <iesg@ietf.org>
Cc: draft-ietf-calext-jscalendar@ietf.org, calext-chairs@ietf.org, calsify@ietf.org, Daniel Migault <daniel.migault@ericsson.com>, daniel.migaultf@ericsson.com
Content-Type: multipart/alternative; boundary="2cb8d200652a4448842b87351cf7b65b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/calsify/bBnFAhN-XKsjByi7KpYPDON8dwk>
Subject: Re: [calsify] Benjamin Kaduk's No Objection on draft-ietf-calext-jscalendar-31: (with COMMENT)
X-BeenThere: calsify@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <calsify.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/calsify>, <mailto:calsify-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/calsify/>
List-Post: <mailto:calsify@ietf.org>
List-Help: <mailto:calsify-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/calsify>, <mailto:calsify-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Oct 2020 04:01:06 -0000

Thanks for the further review, I've adopted all these suggestions.

> It looks like the change in location Id for the virtualLocation entry
> was unintentional, since the localizations property contains a patch
> object that still references the old Id. 

The change was intentional (because I wanted an example that wasn't a UUID to help reinforce that this is permitted), however the patch path in the localizations property should have been updated to match. I have now done this (which conveniently makes it fit on one line too). Good spot!

Cheers,
Neil.

v2.23.0 | Report a Bug | By Email