Re: [calsify] AD review of draft-ietf-calext-ical-relations-05

Michael Douglass <mikeadouglass@gmail.com> Tue, 15 December 2020 20:53 UTC

Return-Path: <mikeadouglass@gmail.com>
X-Original-To: calsify@ietfa.amsl.com
Delivered-To: calsify@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1AF6E3A18EB; Tue, 15 Dec 2020 12:53:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ePw5LCJZXsLG; Tue, 15 Dec 2020 12:53:53 -0800 (PST)
Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E92D43A176B; Tue, 15 Dec 2020 12:53:33 -0800 (PST)
Received: by mail-qv1-xf36.google.com with SMTP id l14so10289528qvh.2; Tue, 15 Dec 2020 12:53:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=8u2e8JX+t98dk1xnbMJPBvFBrsJ3E7wkv6dudk1OAn4=; b=L4gyuQ0BzcPaYn9skz1IfKcA4jF1JXqed2Z0CNrcd3cuOJuDL6tgZCbAUZqc9ijSLR Zg3tcF5HcZOPE4EgwUeYHlpToBbipIdqNqQd/jSzOdkbMsoQ/QF7YfBW2+Q6MoiW8qAG LzqarlhoaG+6ZYeGaFJnbPc6DpGJZB7Eu8CoFM8pGxLVz4M7ZIyucHABLvI8LihuoAvn d/j/Xa+oCd1VUSOujCZy24hr7jX5qAEt9gOwWz5BsQZ+q60JoZZ6obhzbl01oYzvupHH rWBoTLlbLrJ7lC/QvFmP59/ZfrK4gdtKPzG1QyAKYx+2CgBWby6xdHvS5pbiGEzyqsyr nuUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=8u2e8JX+t98dk1xnbMJPBvFBrsJ3E7wkv6dudk1OAn4=; b=j1qzyMbyvODI47EaCmEIOVIlF+rusP51LYOFXvFu/5MttqOr8hXNR+tvQ8J6l5Iy57 Q/O9x6QWgV6KvUSGlHtawjgEPYdp7KzomJhZA5BcWC3knDhnUq8eQpzsjCSEH63YjvKE 21ZsZGAATXEAXaxLBKqWz+uENuEgxt0cM180mPvwmzM9pdp4lBiNaw4suftOUZDnaAoL SimNyxec0JfWGpZSE6gbygv13tBKXcJTt2TR97YHtfW9DgwcUMsPvJkQMUfFJqTpJZYj 7qD7Ody08hs/JqyXNu6Hjaj1lVUVXZS/fL3ukFmj/u+x01hb6my+TQYxr5LEwUMOKhkk 8uJA==
X-Gm-Message-State: AOAM531owTUu5wowRQBj9yDUcsnHQf8oLKl1guSAEhoN36jyVZQ3+OuH WamT/rbfAUxkTpMkIh6rce5qSOciSildZg==
X-Google-Smtp-Source: ABdhPJz0DUcc5rkhqfKiILhsrYb0muYdwVHzIUxzCa1TmsKlXUCCtRtUBt/vswoe4+hc47p//9ZOsw==
X-Received: by 2002:a05:6214:14ee:: with SMTP id k14mr1798998qvw.36.1608065612642; Tue, 15 Dec 2020 12:53:32 -0800 (PST)
Received: from MacBook-Pro-2019.local (cpe-74-70-70-237.nycap.res.rr.com. [74.70.70.237]) by smtp.googlemail.com with ESMTPSA id d16sm14964984qkb.42.2020.12.15.12.53.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 12:53:31 -0800 (PST)
To: Barry Leiba <barryleiba@computer.org>, draft-ietf-calext-ical-relations.all@ietf.org
Cc: calsify@ietf.org
References: <CALaySJKAMbY8ggUCCiG4hDL7wzD9RpW8Zx3z719VhTypX6cKjg@mail.gmail.com>
From: Michael Douglass <mikeadouglass@gmail.com>
Message-ID: <de01785b-c8b0-cd83-8ab5-5bcf1f93bbe2@gmail.com>
Date: Tue, 15 Dec 2020 15:53:30 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <CALaySJKAMbY8ggUCCiG4hDL7wzD9RpW8Zx3z719VhTypX6cKjg@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------9AA75616291252BFDDD4723A"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/calsify/yoSmGfxc9kwM5P6IoPSaFHK4qZo>
Subject: Re: [calsify] AD review of draft-ietf-calext-ical-relations-05
X-BeenThere: calsify@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <calsify.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/calsify>, <mailto:calsify-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/calsify/>
List-Post: <mailto:calsify@ietf.org>
List-Help: <mailto:calsify-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/calsify>, <mailto:calsify-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Dec 2020 20:54:01 -0000

Just dealing with the abnf issues. Can I try out a suggestion for 
section 8.1 - The RELATED-TO abnf

On 11/19/20 14:08, Barry Leiba wrote:
> — Section 8.1 —
>
>        definition here extends the definition in Section 3.8.4.5. of
>        [RFC5545]
>
> Also here: remove the dot at the end of the section number.
>
> For the ABNF in this section I have the same comments as for the ABNF
> in Section 7.1.  In addition, this defines “relparam”, but “relparam”
> is already defined in Section 5.1.  That needs to be fixed.
>

OLD

related    = "RELATED-TO" relparam ( ":" text ) /
              (
                ";" "VALUE" "=" "UID"
                ":" uid
              )
              (
                ";" "VALUE" "=" "URI"
                ":" uri
              )
              CRLF

relparam   = *(
             ;
             ; The following are OPTIONAL,
             ; but MUST NOT occur more than once.
             ;
             (";" reltypeparam) /
             (";" gapparam) /
             ;
             ; The following is OPTIONAL,
             ; and MAY occur more than once.
             ;
             (";" other-param)
             ;
             )

NEW

related    = "RELATED-TO" relparam ( ":" text ) /
              (
                ";" "VALUE" "=" "UID"
                ":" uid
              ) /
              (
                ";" "VALUE" "=" "URI"
                ":" uri
              )
              CRLF

relparam   = ; the elements herein may appear in any order,
              ; and the order is not significant.
              [";" reltypeparam]
              [";" gapparam]
              *(";" other-param)

END

I'm not sure that this construct is still the best way to relate a VALUE 
parameter to a specific value type. It still seems to constrain the order.

Does this work better?

START

related    = "RELATED-TO" relparam ":"
              ( uid /  ; for VALUE=UID
                uri /  ; for VALUE=URI
                text ) ; for VALUE=TEXT or default
              CRLF

relparam   = ; the elements herein may appear in any order,
              ; and the order is not significant.
              [";" ("VALUE" "=" "UID" /
                    "VALUE" "=" "URI" /
                    "VALUE" "=" "TEXT")]
              [";" reltypeparam]
              [";" gapparam]
              *(";" other-param)

END

This seems to do the job - if it works I can redo the abnf for the other 
properties (and for eventpub)