Re: [Captive-portals] Benjamin Kaduk's No Objection on draft-ietf-capport-architecture-09: (with COMMENT)

Kyle Larose <kyle@agilicus.com> Tue, 22 September 2020 12:54 UTC

Return-Path: <kyle@agilicus.com>
X-Original-To: captive-portals@ietfa.amsl.com
Delivered-To: captive-portals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB5673A1677 for <captive-portals@ietfa.amsl.com>; Tue, 22 Sep 2020 05:54:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=agilicus.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hlrGqIT88uFG for <captive-portals@ietfa.amsl.com>; Tue, 22 Sep 2020 05:54:51 -0700 (PDT)
Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1C9F53A0E19 for <captive-portals@ietf.org>; Tue, 22 Sep 2020 05:54:50 -0700 (PDT)
Received: by mail-io1-xd33.google.com with SMTP id j2so19364840ioj.7 for <captive-portals@ietf.org>; Tue, 22 Sep 2020 05:54:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agilicus.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YGaRfr1Zy0+4/4a/c51ZyL4OKC9fNij3qYU8KOUPlyw=; b=OST//wZ/2qGD/reOgW0lGxdI9YSnYEwVL+547XnOY2Q0Bx0FT0aPR7oU0LGpw7JUt5 m1FupE7q9CcWKyYi73ynyOF5s883ZhLSPWaEJwZyPhusZRA/drh2a2av0odjUQoHk4Hq H24lr6aYM3EJ2RxTZ+Zy+643v3p7tQNzu27cjae4upHK625wQ334Uj/UWzcmYFtleF6Q zDIoLnKCdkcX40QNw0qklZLbaiCNAlUx+GoIVHTuqSF84HmJs30qeCDvR8BjMPz2ANo9 jj9ZndZMnGK/NlFiw98Uns1IwQabrmdyAW7x4g2I7XwwxIReTvmoRx74TNExh6Z3hTn6 rRtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YGaRfr1Zy0+4/4a/c51ZyL4OKC9fNij3qYU8KOUPlyw=; b=ZehvANHoRMqWkd/OOW19mq3dM81jbA7vdojXogSJZfn2hNYgkNaRKxKY4MmQVonI8K Zr2wEg0+h6RBftP2gcqt99aBKhcrRTuXC+TDyguedKz6lHXtwaD6Y4+g1OoQxpBeds+E YKBRh863UfMfD7iVDK+aZ68YyoQjGpP2rUBUmnfNrL/ZjYwjgOg6i5Q9JCIC9swqa1Rd 82yZ+vgyDMnbQeNrE+Diu4vg1VcKWyT+tglcBpr8ayxCtqp7uqAQy6GYr2Hvxqqmgbbv HqqUdE/nVdJJtxGMRGtJk0zv6XNnYPCiZaNCWNNx6i20f9bg/SBvRDsgbWYESc6Bu57L dx7Q==
X-Gm-Message-State: AOAM530yKsEbDZV/2bQM1T6vqsD39sJn05N0sdzr5ErSV04LRZfoFXwA 8DElj3yZRmfV06Z43s2jEIStcQesOxVoQ8LMi21R
X-Google-Smtp-Source: ABdhPJyBdHTD4K7l2OFW4AWCtvNkfQTec1PhuUoz51FXl5n5wjqttNQHaeHRV+RcgoTAYTEPhdjXBB3T+hYR0q5yJqs=
X-Received: by 2002:a6b:6c0c:: with SMTP id a12mr3213582ioh.40.1600779290203; Tue, 22 Sep 2020 05:54:50 -0700 (PDT)
MIME-Version: 1.0
References: <160012670268.20035.5295583799658667206@ietfa.amsl.com>
In-Reply-To: <160012670268.20035.5295583799658667206@ietfa.amsl.com>
From: Kyle Larose <kyle@agilicus.com>
Date: Tue, 22 Sep 2020 08:54:39 -0400
Message-ID: <CACuvLgzuuhAc85XP2M+kJ4yx49wTHsvK8tRpyaOaqvVwJhdM_Q@mail.gmail.com>
To: Benjamin Kaduk <kaduk@mit.edu>
Cc: The IESG <iesg@ietf.org>, draft-ietf-capport-architecture@ietf.org, capport-chairs@ietf.org, captive-portals <captive-portals@ietf.org>, Martin Thomson <mt@lowentropy.net>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/captive-portals/sQcmjpLBH6qquxojNIoPVz8a1Go>
Subject: Re: [Captive-portals] Benjamin Kaduk's No Objection on draft-ietf-capport-architecture-09: (with COMMENT)
X-BeenThere: captive-portals@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of issues related to captive portals <captive-portals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/captive-portals/>
List-Post: <mailto:captive-portals@ietf.org>
List-Help: <mailto:captive-portals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2020 12:54:53 -0000

Hi Benjamin,

Thanks for the review. Responses inline below.

On Mon, 14 Sep 2020 at 19:38, Benjamin Kaduk via Datatracker
<noreply@ietf.org> wrote:
>
> Benjamin Kaduk has entered the following ballot position for
> draft-ietf-capport-architecture-09: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-capport-architecture/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Thank you for addressing my Discuss (and comment!) points.
>
> A few new notes on the -09:
>
> Section 1.2 has a new instance of "Captive Network" that didn't get caught
> up in the renaming of "Captive Network" to "Captive Portal"
>
> Section 2.1
>
> Maybe s/navigate the User Portal/navigate to the User Portal/?
>

These have been fixed
(https://github.com/capport-wg/architecture/pull/162). Thanks for
pointing them out. There were quite a few missing captive networks. I
think I got them all now.

> Dave's suggested rewording
> (https://mailarchive.ietf.org/arch/msg/captive-portals/nMLJv4gzGjBQZN_5-TJyrfZZbkI/)
> is correct but not parallel to how we discuss the DNS-ID case.
> I'd recommend either rewording both cases or neither, but don't
> have much of a stance on which is preferred.
>

I think we should leave this as-is, unless someone else objects. I
don't think what we have is wrong, and I prefer to minimize churn at
this point.


Thanks,

Kyle