IETF Logo Mail Archive

Re: [Cbor] Benjamin Kaduk's No Objection on draft-ietf-cbor-network-addresses-09: (with COMMENT)

Michael Richardson <mcr+ietf@sandelman.ca> Thu, 07 October 2021 18:56 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B13D3A0DBF; Thu, 7 Oct 2021 11:56:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h4tN3N_Px_Yl; Thu, 7 Oct 2021 11:56:04 -0700 (PDT)
Received: from tuna.sandelman.ca (tuna.sandelman.ca [IPv6:2607:f0b0:f:3:216:3eff:fe7c:d1f3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 343E53A03EB; Thu, 7 Oct 2021 11:56:04 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by tuna.sandelman.ca (Postfix) with ESMTP id 4558E18094; Thu, 7 Oct 2021 15:04:14 -0400 (EDT)
Received: from tuna.sandelman.ca ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ur-Okc1SSIUn; Thu, 7 Oct 2021 15:04:08 -0400 (EDT)
Received: from sandelman.ca (obiwan.sandelman.ca [IPv6:2607:f0b0:f:2::247]) by tuna.sandelman.ca (Postfix) with ESMTP id B586E18035; Thu, 7 Oct 2021 15:04:08 -0400 (EDT)
Received: from localhost (localhost [IPv6:::1]) by sandelman.ca (Postfix) with ESMTP id 5E9904D2; Thu, 7 Oct 2021 14:55:55 -0400 (EDT)
From: Michael Richardson <mcr+ietf@sandelman.ca>
To: Benjamin Kaduk <kaduk@mit.edu>
cc: Carsten Bormann <cabo@tzi.org>, draft-ietf-cbor-network-addresses@ietf.org, Barry Leiba <barryleiba@computer.org>, cbor@ietf.org, The IESG <iesg@ietf.org>, cbor-chairs@ietf.org
In-Reply-To: <20211006211924.GI4103@kduck.mit.edu>
References: <163337270139.24096.2858053457546637595@ietfa.amsl.com> <54845F41-869A-43CE-BF02-825CB728A2CA@tzi.org> <21159.1633552900@localhost> <20211006211924.GI4103@kduck.mit.edu>
X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 26.1
X-Face: $\n1pF)h^`}$H>Hk{L"x@)JS7<%Az}5RyS@k9X%29-lHB$Ti.V>2bi.~ehC0; <'$9xN5Ub# z!G,p`nR&p7Fz@^UXIn156S8.~^@MJ*mMsD7=QFeq%AL4m<nPbLgmtKK-5dC@#:k
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha512"; protocol="application/pgp-signature"
Date: Thu, 07 Oct 2021 14:55:55 -0400
Message-ID: <10753.1633632955@localhost>
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/swHYrGId7eWACZK6MXur9BYbSTQ>
Subject: Re: [Cbor] Benjamin Kaduk's No Objection on draft-ietf-cbor-network-addresses-09: (with COMMENT)
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Oct 2021 18:56:10 -0000

Benjamin Kaduk <kaduk@mit.edu> wrote:
    > On Wed, Oct 06, 2021 at 04:41:40PM -0400, Michael Richardson wrote:
    >>
    >> Carsten Bormann <cabo@tzi.org> wrote:
    >> >> unused_bits = (8 - (prefix_length_in_bits & 7)) % 8;
    >>
    >> > Well, I for one don’t like making the “simply” more complicated (*).
    >>
    >> I have no strong preference.
    >> If I didn't have to read/write C again in my life, that would be fine.

    > I'm sure many share that sentiment :)

okay, so
  unused_bits = (8 - (prefix_length_in_bits % 8);

produces the wrong answer (8) when it's a multiple of 8 and the answer should
be 0.

  unused_bits = (8 - (prefix_length_in_bits % 8) % 8;

gives the right answer.  Can I use that?

--
Michael Richardson <mcr+IETF@sandelman.ca>   . o O ( IPv6 IøT consulting )
           Sandelman Software Works Inc, Ottawa and Worldwide

v2.23.0 | Report a Bug | By Email