Re: [CCAMP] WG last call on draft-ietf-ccamp-mw-topo-yang-05

Italo Busi <Italo.Busi@huawei.com> Thu, 06 July 2023 16:08 UTC

Return-Path: <Italo.Busi@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 807DBC1524DD; Thu, 6 Jul 2023 09:08:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.896
X-Spam-Level:
X-Spam-Status: No, score=-6.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id suiQrek_C37w; Thu, 6 Jul 2023 09:08:19 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE757C151994; Thu, 6 Jul 2023 09:08:18 -0700 (PDT)
Received: from frapeml100005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QxhDy3KRYz6D8Vt; Fri, 7 Jul 2023 00:04:50 +0800 (CST)
Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100005.china.huawei.com (7.182.85.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 6 Jul 2023 18:08:15 +0200
Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.027; Thu, 6 Jul 2023 18:08:15 +0200
From: Italo Busi <Italo.Busi@huawei.com>
To: Scott Mansfield <scott.mansfield@ericsson.com>, tom petch <ietfc@btconnect.com>, Zhenghaomian <zhenghaomian=40huawei.com@dmarc.ietf.org>, "ccamp@ietf.org" <ccamp@ietf.org>
CC: CCAMP Working Group <ccamp-chairs@ietf.org>
Thread-Topic: [CCAMP] WG last call on draft-ietf-ccamp-mw-topo-yang-05
Thread-Index: AQHZrqnQGnDyHB63GmJaomUgdb9nAa+s5pDw
Date: Thu, 06 Jul 2023 16:08:15 +0000
Message-ID: <69e8eecd21dc4637b21732ed2ee8489d@huawei.com>
References: <dc38679a753249ffa207f4328c909a20@huawei.com> <AM7PR07MB62486F96A71740E498736C37A05BA@AM7PR07MB6248.eurprd07.prod.outlook.com> <AM7PR07MB6248F5EA4DE65F01875EC1FAA058A@AM7PR07MB6248.eurprd07.prod.outlook.com> <AM7PR07MB624868812F15EF720E8C4DA8A05DA@AM7PR07MB6248.eurprd07.prod.outlook.com> <BL0PR1501MB4130112F0D8420B2F96228BE8B2EA@BL0PR1501MB4130.namprd15.prod.outlook.com>
In-Reply-To: <BL0PR1501MB4130112F0D8420B2F96228BE8B2EA@BL0PR1501MB4130.namprd15.prod.outlook.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.81.210.62]
Content-Type: multipart/alternative; boundary="_000_69e8eecd21dc4637b21732ed2ee8489dhuaweicom_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/04wzoYKvNH4B-JnmAr1wzUw9GHE>
Subject: Re: [CCAMP] WG last call on draft-ietf-ccamp-mw-topo-yang-05
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jul 2023 16:08:23 -0000

Hi all,

I have read the document (as contributor) and I think it is ready to move forward

I just have a couple of comments that IMHO could be addressed as part of the WG LC together with the comments below:

1)      While reading the comment below about the 'mw-tp-option' and the 'mw-link-option' choices, I have realized that also this model would be impacted by the on-going discussion we are having within CCAM WG about the possibility to support a single multi-technology topology instance

      I would suggest to align this model to follow the guidelines we are planning to propose in the upcoming updates for flexi-grid and OTN topology drafts

      In particular, if the proposed guidelines are agreed by the CCAMP WG, I would propose to:
*       Add a 'mw-node' presence container to indicate that the node is MW-capable
*       Update the 'mw-link-choice' container to 'mw-link" presence container to indicate that the link is a MW link: the mw-link-option can then be marked as mandatory as proposed by the editors below
*       Update the 'mw-tp-choice' container to 'mw-tp' presence container to indicate that the TP is a MW TP: the mw-tp-option can then be marked as mandatory as proposed by the editors below

2)      The units "Kbps" for the mw-bandwidth attribute is sometimes ambiguous: it is better to be more specific using "kilobits" or "kilobytes"

      Moreover, for alignment with other YANG models in IETF, please consider also the possibility to change the measurement unit from "Kbps" to "bits/second" (see e.g., RFC 8343)

Thanks, Italo

> -----Original Message-----
> From: Scott Mansfield <scott.mansfield@ericsson.com>
> Sent: martedì 4 luglio 2023 15:41
> To: tom petch <ietfc@btconnect.com>; Zhenghaomian
> <zhenghaomian=40huawei.com@dmarc.ietf.org>; ccamp@ietf.org
> Cc: CCAMP Working Group <ccamp-chairs@ietf.org>
> Subject: Re: [CCAMP] WG last call on draft-ietf-ccamp-mw-topo-yang-05
>
> Tom,
> Thank you for your comprehensive review of the last-call draft.  Please see
> comments and resolutions to your comments inline below (marked by
> <editors></editors>
>
> Let us know if this is satisfactory, or if there is more clarification needed.
>
> Regards,
> -scott.
>
> Snip...
>
> <tp3>
> A follow up to an earlier comment of mine relating to
>        leaf actual-transmitted-level {
>           type decimal64 {
>             fraction-digits 1;
>             range "0..99";
> I was unsure if the maximum value was then 99.9 or 99.0 so I asked on the
> NETMOD list and the answer is 99.0.  I note that the same construct is used in
> RFC8561 so I assume that 99.0 is a magic number in microwave.
>
> <editors>
> The leaf actual-transmitted-level is read-only data, that can take on several
> different values including negative values.  So, since this is not configuration
> data, the editors suggest simply removing the range statement, and modifying
> the description to provide guidance on how to interpret the value.
> </editors>
>
>
> <tp2>
> One more thought.  The Appendices would benefit from a reference to RFC8792.
>
> <editors>
> Agreed, since the tool to fold the text in the examples is used.  Add {{?RFC8792}}
> </editors>
>
>
> <tp>
> 8561 is an import so must be a Normative reference
>
>   "ETSI EN 302 217-1 -
>   "ETSI EN 301 129   -
> need adding as references as a URL so I can see if they are accessible
>
> <editors>
> Add {{!RFC8561}}
>
> Add the following to the markdown for the ETSI references to the Normative
> reference section:
>   EN 302 217-1:
>     title: Fixed Radio Systems; Characteristics and requirements for point-to-point
> equipment and antennas; Part 1: Overview, common characteristics and
> requirements not related to access to radio spectrum
>     author:
>       org: ETSI
>     date: June 2021
>     seriesinfo: ETSI EN 302 217-1
>     target:
> https://www.etsi.org/deliver/etsi_en/302200_302299/30221701/03.03.00_20<https://www.etsi.org/deliver/etsi_en/302200_302299/30221701/03.03.00_20/en_30221701v030300a.pdf>
> /en_30221701v030300a.pdf
>
>   EN 301 129:
>     title: Transmission and Multiplexing (TM); Digital Radio Relay Systems (DRRS);
> Synchronous Digital Hierarchy (SDH); System performance monitoring
> parameters of SDH DRRS
>     author:
>       org: ETSI
>     date: May 1999
>     seriesinfo: ETSI EN 301 129
>     target:
> https://www.etsi.org/deliver/etsi_en/301100_301199/301129/01.01.02_60/e<https://www.etsi.org/deliver/etsi_en/301100_301199/301129/01.01.02_60/en_301129v010102p.pdf>
> n_301129v010102p.pdf
>
> </editors>
>
> 1.1
> should include
> ctp
> rlt
> rltp
> snir
> <editors>
> ctp: Carrier Termination Point
> rlt: Radio Link terminal
> rltp: Radio Link Termination Point
> snir: Signal Noise Interference Ratio
> </editors>
>
> carries, in various configurations/modes.  T perhaps 'carriers'
>
> .  The supporting carriers are identified by its termination points /its/their/
> <editors> Yes, fix the typos.
> </editors>
>
> s.3.3
> L2 ethernet
> Is there an Ethernet that is a different layer?
> <editors>
> There is a distinction between L2 ethernet and L1 ethernet in the microwave
> area, so suggest no change to the use of L2 ethernet.
> </editors>
>
> s.3.4
> augmented by the microwave topology model a reference would be useful
> <editors> The microwave topology model is the model being defined by this ID.
> So no reference is needed. Maybe change the wording to "augmented by THIS
> microwave topology model"  (note: all caps only for emphasis, not for draft)
> </editors>
>
> module
> snir
>             fraction-digits 1;
>             range "0..99";
> I imagine that that excludes 99.9 or 99.1 etc
>
> actual transmitted level
> ditto
> <editors>
> For snir and action-transmitted-level:  Same as point 1, remove the range
> statement and update the description statement.
> </editors>
>
> when choices specify mw-tp mw-link is one of the choice mandatory?
> <editors>
> Agreed, should make each choice statement mandatory, that would enforce one
> option to be chosen when configuring.
> </editors>
>
> apply only for networks with an          microwave network topology type
> /an/a/
> <editors>
> Fix typo
> </editors>
>
> A.1
> 10.10.10.1
> is not an address for documentation use
> A.2
> dirro
> B.1
> ditto
> <editors>
> Agreed, use https://www.rfc-editor.org/rfc/rfc3330.txt, so addresses like
> 192.0.2.1 & 192.0.2.2 in the examples.
> </editors>
>
> The authors would like to thank ...
> <editors>
> We will add thanks and acknowledgements.
> </editors>
>
> Regards,
> -scott. (on the behalf of the Authors of the microwave topology draft)
>