[CCAMP] Yangdoctors last call review of draft-ietf-ccamp-flexe-yang-cm-02

Ladislav Lhotka via Datatracker <noreply@ietf.org> Mon, 14 August 2023 08:49 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ladislav Lhotka via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: ccamp@ietf.org, draft-ietf-ccamp-flexe-yang-cm.all@ietf.org, last-call@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <169200294783.29198.10599275810060363083@ietfa.amsl.com>
Reply-To: Ladislav Lhotka <ladislav.lhotka@nic.cz>
Date: Mon, 14 Aug 2023 01:49:07 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/1jXK4vbZG0q6iMmV6gNYwWAcMvs>
Subject: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-flexe-yang-cm-02

Reviewer: Ladislav Lhotka
Review result: Ready with Issues

**** General comments

The ietf-flexe module is a relative small YANG module based on an
implementation agreed upon by the OIF Forum. From the YANG point of view, the
only problem of the module that I found is that all configuration leaves in the
"flexe-client" container are mandatory, which eventually makes the top-level
container "ietf-flexe:flexe" mandatory. This violates the requirement in sec.
4.10 of RFC 8407: Top-level data node MUST NOT be mandatory.

**** Specific comments

***** Section 2
- The list of requirements would be better formatted as a definition list
(<dl>) of xml2rfc v3. - A spurious character entity representing Unicode
character U+12289 appears at the end of the requirement R-Group-02.

***** Appendices
- It would be useful to indicate (at least schematically) that <port-num>
leaves are references (leafrefs) to interfaces defined using the
ietf-interfaces module.

[CCAMP] Yangdoctors last call review of draft-iet… Ladislav Lhotka via Datatracker
Re: [CCAMP] Yangdoctors last call review of draft… wangminxue@chinamobile.com