Re: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-flexe-yang-cm-02
"wangminxue@chinamobile.com" <wangminxue@chinamobile.com> Tue, 12 September 2023 09:07 UTC
Return-Path: <wangminxue@chinamobile.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 90BAAC13AE33; Tue, 12 Sep 2023 02:07:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.596
X-Spam-Level:
X-Spam-Status: No, score=-2.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TOv2F-muKSbU; Tue, 12 Sep 2023 02:07:33 -0700 (PDT)
Received: from cmccmta1.chinamobile.com (cmccmta1.chinamobile.com [221.176.66.79]) by ietfa.amsl.com (Postfix) with ESMTP id BB6CBC1524B3; Tue, 12 Sep 2023 02:07:23 -0700 (PDT)
X-RM-TagInfo: emlType=0
X-RM-SPAM-FLAG: 00000000
Received: from spf.mail.chinamobile.com (unknown[172.16.121.85]) by rmmx-syy-dmz-app03-12003 (RichMail) with SMTP id 2ee365002a46e3d-25ec5; Tue, 12 Sep 2023 17:07:19 +0800 (CST)
X-RM-TRANSID: 2ee365002a46e3d-25ec5
X-RM-TagInfo: emlType=0
X-RM-SPAM-FLAG: 00000000
Received: from LAPTOP-0963S9S1 (unknown[10.2.147.228]) by rmsmtp-syy-appsvrnew03-12028 (RichMail) with SMTP id 2efc65002a41866-458a1; Tue, 12 Sep 2023 17:07:18 +0800 (CST)
X-RM-TRANSID: 2efc65002a41866-458a1
Date: Tue, 12 Sep 2023 17:07:18 +0800
From: "wangminxue@chinamobile.com" <wangminxue@chinamobile.com>
To: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, ccamp <ccamp@ietf.org>, last-call <last-call@ietf.org>, "Pengshuping (Peng Shuping)" <pengshuping@huawei.com>, Ladislav Lhotka <ladislav.lhotka@nic.cz>
Cc: "draft-ietf-ccamp-flexe-yang-cm.all" <draft-ietf-ccamp-flexe-yang-cm.all@ietf.org>
References: <169200294783.29198.10599275810060363083@ietfa.amsl.com>
X-Priority: 3
X-Has-Attach: no
X-Mailer: Foxmail 7.2.20.269[cn]
Mime-Version: 1.0
Message-ID: <2023091217071812524018@chinamobile.com>
Content-Type: multipart/alternative; boundary="----=_001_NextPart817363540655_=----"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/vyXb0JcJYMwcw5A6mPB8uUI8U_8>
Subject: Re: [CCAMP] Yangdoctors last call review of draft-ietf-ccamp-flexe-yang-cm-02
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Sep 2023 09:07:35 -0000
Hi Ladislav ,Shuping and CCAMP, Thank you for the comments. The authors update the I-D, please check the links below to see whether the new 03-revision is satisfactory. Regards, Minxue The IETF datatracker status page for this draft is: https://datatracker.ietf.org/doc/draft-ietf-ccamp-flexe-yang-cm/ There is also an htmlized version available at: https://datatracker.ietf.org/doc/html/draft-ietf-ccamp-flexe-yang-cm A diff from the previous version is available at: https://author-tools.ietf.org/iddiff?url2=draft-ietf-ccamp-flexe-yang-cm-03 ------------------------------------- 王敏学/ Wang Minxue 中国移动通信研究院 基础网络技术研究所 / China Mobile Research Institute 地址: 北京市西城区宣武门西大街32号创新大厦,100053 电话: 010-15801696688-33202 传真：010-63601087 Email: wangminxue@chinamobile.com ------------------------------------- From: Ladislav Lhotka via Datatracker Date: 2023-08-14 16:49 To: yang-doctors@ietf.org CC: ccamp; draft-ietf-ccamp-flexe-yang-cm.all; last-call Subject: Yangdoctors last call review of draft-ietf-ccamp-flexe-yang-cm-02 Reviewer: Ladislav Lhotka Review result: Ready with Issues **** General comments The ietf-flexe module is a relative small YANG module based on an implementation agreed upon by the OIF Forum. From the YANG point of view, the only problem of the module that I found is that all configuration leaves in the "flexe-client" container are mandatory, which eventually makes the top-level container "ietf-flexe:flexe" mandatory. This violates the requirement in sec. 4.10 of RFC 8407: Top-level data node MUST NOT be mandatory. **** Specific comments ***** Section 2 - The list of requirements would be better formatted as a definition list (<dl>) of xml2rfc v3. - A spurious character entity representing Unicode character U+12289 appears at the end of the requirement R-Group-02. ***** Appendices - It would be useful to indicate (at least schematically) that <port-num> leaves are references (leafrefs) to interfaces defined using the ietf-interfaces module.
- [CCAMP] Yangdoctors last call review of draft-iet… Ladislav Lhotka via Datatracker
- Re: [CCAMP] Yangdoctors last call review of draft… wangminxue@chinamobile.com