Re: [CCAMP] Comments on draft-ietf-ccamp-wson-signaling-05

Leeyoung <leeyoung@huawei.com> Thu, 14 March 2013 01:26 UTC

Return-Path: <leeyoung@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E64B611E80E6 for <ccamp@ietfa.amsl.com>; Wed, 13 Mar 2013 18:26:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.599
X-Spam-Level:
X-Spam-Status: No, score=-6.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Q5HcItiM4VV for <ccamp@ietfa.amsl.com>; Wed, 13 Mar 2013 18:26:55 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) by ietfa.amsl.com (Postfix) with ESMTP id C923A11E80E2 for <ccamp@ietf.org>; Wed, 13 Mar 2013 18:26:54 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml204-edg.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.5-GA FastPath queued) with ESMTP id AQP65509; Thu, 14 Mar 2013 01:26:50 +0000 (GMT)
Received: from LHREML403-HUB.china.huawei.com (10.201.5.217) by lhreml204-edg.china.huawei.com (172.18.7.223) with Microsoft SMTP Server (TLS) id 14.1.323.7; Thu, 14 Mar 2013 01:26:15 +0000
Received: from DFWEML405-HUB.china.huawei.com (10.193.5.102) by lhreml403-hub.china.huawei.com (10.201.5.217) with Microsoft SMTP Server (TLS) id 14.1.323.7; Thu, 14 Mar 2013 01:26:48 +0000
Received: from dfweml511-mbs.china.huawei.com ([169.254.15.217]) by dfweml405-hub.china.huawei.com ([10.193.5.102]) with mapi id 14.01.0323.007; Wed, 13 Mar 2013 18:26:42 -0700
From: Leeyoung <leeyoung@huawei.com>
To: "Giovanni Martinelli (giomarti)" <giomarti@cisco.com>, "Margaria, Cyril (NSN - DE/Munich)" <cyril.margaria@nsn.com>
Thread-Topic: [CCAMP] Comments on draft-ietf-ccamp-wson-signaling-05
Thread-Index: Ac4f9fHWZRxXufGDRkGdO9Y5p2fdaAAeYW8AAAdWyjA=
Date: Thu, 14 Mar 2013 01:26:41 +0000
Message-ID: <7AEB3D6833318045B4AE71C2C87E8E17291183C3@dfweml511-mbs.china.huawei.com>
References: <8DC6547C806B644F998A0566E79E15920F7DFFCC@DEMUMBX006.nsn-intra.net> <0D7F95913F470A4B83AB5F5833A4390D293158@xmb-rcd-x14.cisco.com>
In-Reply-To: <0D7F95913F470A4B83AB5F5833A4390D293158@xmb-rcd-x14.cisco.com>
Accept-Language: en-US, zh-CN
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.47.148.28]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Cc: CCAMP <ccamp@ietf.org>, "draft-ietf-ccamp-wson-signaling@tools.ietf.org" <draft-ietf-ccamp-wson-signaling@tools.ietf.org>
Subject: Re: [CCAMP] Comments on draft-ietf-ccamp-wson-signaling-05
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Mar 2013 01:26:56 -0000

Hi Cyril,

Thanks for your thorough review the draft. I concur with Giovanni on the comments. 

I have some comments in-line. 

Regards,
Young

-----Original Message-----
From: ccamp-bounces@ietf.org [mailto:ccamp-bounces@ietf.org] On Behalf Of Giovanni Martinelli (giomarti)
Sent: Wednesday, March 13, 2013 6:51 PM
To: Margaria, Cyril (NSN - DE/Munich)
Cc: CCAMP; draft-ietf-ccamp-wson-signaling@tools.ietf.org
Subject: Re: [CCAMP] Comments on draft-ietf-ccamp-wson-signaling-05

Hi Cyril,

thx for careful review, pls see inline

On Mar 13, 2013, at 10:20 , "Margaria, Cyril (NSN - DE/Munich)" <cyril.margaria@nsn.com> wrote:

> 
> Dear authors,
> 
> I have the following comments on draft-ietf-ccamp-wson-signaling-05:
> 
> Comment 1:
> The document considers bidirection RB set and limit 2 RBInformation per hop.  However per RFC3473 section 8.1.1 and RFC3471, using different interface id for the upstream and downstream direction. The current definition does not support that.
> The following change would allow it.
> Section 4.2
> 
> OLD:
> "If more than two objects are encountered, two
>   MUST be processed and the rest SHOULD be ignored."
> 
> NEW:
> "If more than two objects per direction are encountered, two
>   MUST be processed and the rest SHOULD be ignored."
> 

GM> ok

> Section 4
> 
> OLD:
> "The usage of <WSON Processing> object for the bidirectional case is
>   the same as per unidirectional. When an intermediate node uses
>   information from this object to instruct a node about wavelength
>   regeneration, the same information applies to both downstream and
>   upstream directions."
> 
> NEW:
> "The usage of <WSON Processing> object for the bidirectional case is
>   the same as per unidirectional. When an intermediate node uses
>   information from this object to instruct a node about wavelength
>   regeneration, the same regeneration information should applies to both downstream and
>   upstream directions."

GM> I assume you meant section 5. Ok. Just wondering if worth spending some words on usage of I|E flags vs directions

YOUNG>> Simple grammar check with your suggested text: 

OLD: "...should applies to both downstream and upstream directions."
NEW: "...should apply to both downstream and upstream directions." 

> 
> Comment-2: Section 4.2 :
> I think the restriction on the RB Set identifier processing is maybe too strong.
> I would like to suggest the following modification:
> 
> remove
> "RB Set Field MAY contain more than one RB Indetifier. Only the first
>   one MUST be processed, the others SHOULD be ignored.
> "
> In all case, consider the Typo

GM> fine with me no problem in relaxing constrain (btw thx for catching the typo)

> Comment-3 :
> The restriction on the OIC and other parameters are also too strong, only considering one does not allows signaling to pick the one RB among several.
> Please consider the following change
> Remove
> " The Optical Interface Class List, Input Bit Range List and
>   Processing Capability List MAY contain more than one element. Only
>   the first MUST be processed, the others SHOULD be ignored.
> "
> 

GM> same as comment above

thx again for reading!

Cheers
G

> 
> 
> 
> Mit freundlichen Grüßen / Best Regards
> Cyril Margaria
> 
> Nokia Siemens Networks Optical GmbH
> St.Martin-Str. 76
> D-81541 München
> Germany
> mailto:cyril.margaria@nsn.com
> Phone: +49-89-5159-16934
> Fax:   +49-89-5159-44-16934
> ----------------------------------------------------------------
> Nokia Siemens Networks Optical GmbH
> Geschäftsleitung / Board of Directors: Gero Neumeier, Dr. Rolf Nauerz
> Sitz der Gesellschaft: München / Registered office: Munich
> Registergericht: München / Commercial registry: Munich, HRB 197143
> 
> 
> 
> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp

_______________________________________________
CCAMP mailing list
CCAMP@ietf.org
https://www.ietf.org/mailman/listinfo/ccamp