Re: [CCAMP] [RTG-DIR] RtgDir review: draft-ietf-ccamp-general-constraint-encode-16.txt

Leeyoung <leeyoung@huawei.com> Mon, 19 January 2015 22:54 UTC

Return-Path: <leeyoung@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2BB4A1B2D13; Mon, 19 Jan 2015 14:54:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.21
X-Spam-Level:
X-Spam-Status: No, score=-3.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YKCfPflU-jON; Mon, 19 Jan 2015 14:54:32 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 011B31B2D0A; Mon, 19 Jan 2015 14:54:30 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml404-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BRN15525; Mon, 19 Jan 2015 22:54:29 +0000 (GMT)
Received: from DFWEML702-CHM.china.huawei.com (10.193.5.72) by lhreml404-hub.china.huawei.com (10.201.5.218) with Microsoft SMTP Server (TLS) id 14.3.158.1; Mon, 19 Jan 2015 22:54:28 +0000
Received: from DFWEML706-CHM.china.huawei.com ([10.193.5.225]) by dfweml702-chm ([10.193.5.72]) with mapi id 14.03.0158.001; Mon, 19 Jan 2015 14:54:19 -0800
From: Leeyoung <leeyoung@huawei.com>
To: Tomonori Takeda <tomonori.takeda@ntt.com>, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
Thread-Topic: [RTG-DIR] RtgDir review: draft-ietf-ccamp-general-constraint-encode-16.txt
Thread-Index: AdAyVmdKICzu0mt5SZ+spYC7d3T1cAB2eNGw
Date: Mon, 19 Jan 2015 22:54:18 +0000
Message-ID: <7AEB3D6833318045B4AE71C2C87E8E1729C7B111@dfweml706-chm>
References: <EB0F2EAC05E9C64D80571F2042700A2A6C46DC@C0010I0.coe.ntt.com>
In-Reply-To: <EB0F2EAC05E9C64D80571F2042700A2A6C46DC@C0010I0.coe.ntt.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.192.11.120]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <http://mailarchive.ietf.org/arch/msg/ccamp/9Z99S3ELlZWZvUShbQRTpCZ6MiQ>
Cc: "'rtg-dir@ietf.org'" <rtg-dir@ietf.org>, "'draft-ietf-ccamp-general-constraint-encode.all@tools.ietf.org'" <draft-ietf-ccamp-general-constraint-encode.all@tools.ietf.org>, "'ccamp@ietf.org'" <ccamp@ietf.org>
Subject: Re: [CCAMP] [RTG-DIR] RtgDir review: draft-ietf-ccamp-general-constraint-encode-16.txt
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2015 22:54:35 -0000

Hi Tomonori,

Thanks for providing good comments. Here's my response. Please see in-line.

Regards,
Young

-----Original Message-----
From: rtg-dir [mailto:rtg-dir-bounces@ietf.org] On Behalf Of Tomonori Takeda
Sent: Saturday, January 17, 2015 7:59 AM
To: rtg-ads@tools.ietf.org
Cc: 'rtg-dir@ietf.org'org'; 'draft-ietf-ccamp-general-constraint-encode.all@tools.ietf.org'org'; 'ccamp@ietf.org'
Subject: [RTG-DIR] RtgDir review: draft-ietf-ccamp-general-constraint-encode-16.txt

Hello, 

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir 

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. 

Document: draft-ietf-ccamp-general-constraint-encode-16.txt 
Reviewer: Tomonori Takeda
Review Date: 17 January, 2015
IETF LC End Date: 17 January, 2015
Intended Status: Standards Track

Summary:

This document is basically ready for publication, but has nits that should be considered prior to publication.

Comments:

This document specifies protocol-agnostic encodings for general information elements described in draft-ietf-ccamp-rwa-info.
I think the document is in good shape but there are a few points that should be clarified for better understanding.

Major Issues:

None

Minor Issues:

None

Nits:

1) In section 1.2, label continuity constraint (e.g., wavelength continuity in WSON) is mentioned. However, I am not sure whether information elements for which this document specifies encodings can describe such constraint. My reading is that information element such as Port Label Restriction is rather for describing wavelength tuning capabilities/restrictions.

YOUNG>> Label continuity constraints can be inferred from the two places in the draft: (i) Port Label Restriction, which gives the set of labels (wavelengths) that may not be available on certain links including tuning range/restriction; (ii) Available/Shared Backup Label Fields (section 2.4 & section 2.5). There is no encoding for label continuity constraint per se. The aforementioned constraints are encoded to give a node or a PCE to be able to compute a path (i.e., path with wavelength continuity) subject to these constraints. 

2) In section 2.1, it says "two matrices will not have the same {src port, src label, dst port, dst label}". To be precise, I guess this should be "two matrices will not have the same {src port, src label}, and two matrices will not have the same {dst port, dst label}"?

YOUNG>> I think your suggestion may be too restrictive. For instance, if we have one source (port 1) and one destination (port 2) with two labels each. Then we would have: {(1,1,2,1), (1,1,2,2), (1,2,2,1), (1,2,2,2)} I think with the current statement, we can send this info in any combination of multiple matrices, which I think perfectly fine. With your suggestion, I would not be able send (1,1,2,1) and (1,1,2,2) together. Why would this not be made possible? My take is as long as each submatrix represents a set of disjoint quadruples, that should be allowed. 

3) In section 2.1, it says "The value of 0xFF is reserved for use with port wavelength constraints". I think "port wavelength constraints" should be "port label restriction".

YOUNG>> Yes, thanks. 

4) In section 2.1, for Link Set A dir=bidirectional, Link Set B dir=bidirectional, if any signal on an input link X is output on a link Y, then any signal on an input link Y is output on a link X (after cross-connect)? Or any constraint on such signal flow (after cross-connect) is out of scope?

YOUNG>> I am not sure what "after cross-connect" is meant. 

5) In section 2.2.1, it says "In this case the accompanying label set indicates the labels permitted on the port." I think "port" should be "port/matrix".

YOUNG>> Yes, thanks. 

6) In section 2.2.2, it would be better to describe the type (e.g., integer) for MaxNumChannels.
This also applies for MaxLabelRange (in section 2.2.3) and Num Labels (in section 2.6).

YOUNG>> OK. 

7) In section 2.6, it says "Label Set Field is used within the <AvailableLabels> or the <SharedBackupLabels>". But I think Label Set Field is also used within SIMPLE_LABEL, LABEL_RANGE and SIMPLE_LABEL & CHANNEL_COUNT.

YOUNG>> Yes, it is used in multiple places. 

How about:
OLD: Label Set Field is used within the <AvailableLabels> or the
   <SharedBackupLabels>, which is defined in Section 2.4. and 2.5.,
   respectively.
NEW: Label Set Field is used within the <AvailableLabels> or the
   <SharedBackupLabels>, which is defined in Section 2.4. and 2.5.,
   respectively. It is also used within the <SIMPLE_LABEL>, 
   <LABEL_RANGE>, <SIMPLE_LABEL> or <CHANNEL_COUNT>, which is defined
   in Sections 2.1.1 - 2.1.4, respectively. 


Thanks,
Tomonori