Re: [CCAMP] John Scudder's Yes on draft-ietf-ccamp-mw-topo-yang-10: (with COMMENT)

[Scott Mansfield <[e-mail]>]

Thank you, please see inline...

Marked with
<scott> </scott>


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thanks for this document. I have some minor comments below, that I hope may be
helpful. Also, thanks to Éric for being special guest AD, and to Daniele for
the shepherd write-up.

### Section 1.1, unused terms

MSDC is defined but only used once... prior to this section, and with in-line
expansion already. So, I think the abbreviation can be removed.

Same for PNC.

<scott> I will remove MSDC and PNC. </scott>

### Section 1.2, incorrect xref

“A simplified graphical representation of the data model is used in chapter 3.1
of this document.”

RFCs don’t have “chapters”, they have “sections”, but more importantly this
document doesn’t have a section (or chapter) 3.1. I guess you need to update
your cross reference. Probably you mean Section 2.1?

<scott> This was a typo, I changed the wording to use what we have used in other RFCS/I-Ds.

   Tree diagrams used in this document follow the notation defined in [RFC8340].

</scott>

### Appendices

Thank you for the clear diagrams, they’re very helpful. Just curious, what tool
did you use to produce them? (Assuming the different renderings weren't
hand-crafted that is.)

<scott>
I used ascii art and then used this https://github.com/martinthomson/aasvg to make the svg.  The example https://github.com/martinthomson/aasvg/blob/main/example.svg and the corresponding ascii version here https://github.com/martinthomson/aasvg/blob/main/example.txt was the inspiration and amazing helpful to getting the svg right.

I tried using inkscape, but the svg was too complex apparently and I couldn't get it to render, so Martin told me about aasvg and that worked great.  If this is helpful information, I can add it to the acknowledgement section.

I use kramdown, so I let the make file generate the xml file, then I edited the xml file to add an artset so that txt files would use the ascii and the html and pdfs will use svg.  I had to add this..  /*-[0-9][0-9].xml  to my .gitignore file so that the make process didn't delete the xml file automatically.
 
</scott>