Re: [CCAMP] Robert Wilton's Yes on draft-ietf-ccamp-l1csm-yang-25: (with COMMENT)

[Zhenghaomian <[e-mail]>]

Thank you Mahesh, I am good with the proposed changes.
Let's wait for Rob's feedback:)

Best wishes,
Haomian

From: Mahesh Jethanandani [mailto:[e-mail]]
Sent: Friday, March 29, 2024 5:30 AM
To: Zhenghaomian <[e-mail]>
Cc: Robert Wilton <[e-mail]>; The IESG <[e-mail]>; [e-mail]; [e-mail]; [e-mail]; LUIS MIGUEL CONTRERAS MURILLO <[e-mail]>
Subject: Re: Robert Wilton's Yes on draft-ietf-ccamp-l1csm-yang-25: (with COMMENT)

Hi Haomian,

I will let Robert comment (if he still wants to :-)), but for my observations see inline:


On Mar 28, 2024, at 1:45 AM, Zhenghaomian <zhenghaomian=[e-mail]<mailto:zhenghaomian=[e-mail]>> wrote:

Hi Robert,

Thank you for the comments, see inline:)

Best wishes,
Haomian

-----Original Message-----
From: Robert Wilton via Datatracker [mailto:[e-mail]]
Sent: Friday, February 23, 2024 10:52 PM
To: The IESG <[e-mail]<mailto:[e-mail]>>
Cc: [e-mail]<mailto:[e-mail]>; [e-mail]<mailto:[e-mail]>; [e-mail]<mailto:[e-mail]>; [e-mail]<mailto:[e-mail]>; [e-mail]<mailto:[e-mail]>
Subject: Robert Wilton's Yes on draft-ietf-ccamp-l1csm-yang-25: (with COMMENT)

Robert Wilton has entered the following ballot position for
draft-ietf-ccamp-l1csm-yang-25: Yes

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-ccamp-l1csm-yang/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Hi,

Thanks for publishing this document and YANG module.  It looks good to me, with
just one minor comment:

(1) p 2, sec 1.  Introduction

  The primary focus of this document is to describe L1CSM YANG model
  required for the instantiation of point-to-point L1 connectivity
  services, to provide Layer 1 connectivity between two or more
  customer sites where the customer has some control over the
  establishment and type of the connectivity.  The L1CSM specified in
  this document supports the point-to-point connectivity services
  defined in [RFC4847].

I'm struggling to parse the first sentence in paragraph above.  Perhaps the
following is clearer?

  The primary focus of this document is to describe the L1CSM YANG
  model that is used for the instantiation of point-to-point L1
  connectivity services, which provide Layer 1 connectivity between
  two or more customer sites where the customer has some control
  over the establishment and type of the connectivity.

[Haomian] I am okay with the wording, of the first sentence. For the second sentence see the next.

It also wasn't really clear to me how the YANG model relates to the 3 different
abstract services models that you described.  Is it possible for the
relationship to be a bit more clearly explained please.

[Haomian] The original motivation is to indicate the support of all the 3 types L1 connections in RFC4847. The YANG model itself are generic and does not differentiate the types/mode. So for the second sentence, would the following proposal work?

OLD:
The L1CSM specified in this document supports the point-to-point connectivity services defined in [RFC4847].

NEW:
The L1CSM specified in this document provides generic support on service models defined in [RFC4847].

[mj] Could be more specific. How about this?

NEW:
The L1CSM specified in this document is generic, and provides support for the three different service models defined in [RFC4847].



Regards,
Rob




Mahesh Jethanandani
[e-mail]<mailto:[e-mail]>