Re: [Cellar] Erik Kline's No Objection on draft-ietf-cellar-ffv1-17: (with COMMENT)

Jerome Martinez <jerome@mediaarea.net> Tue, 22 September 2020 15:57 UTC

Return-Path: <jerome@mediaarea.net>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1B4283A16B6 for <cellar@ietfa.amsl.com>; Tue, 22 Sep 2020 08:57:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.921
X-Spam-Level:
X-Spam-Status: No, score=-1.921 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UHoD3TXgdU1V for <cellar@ietfa.amsl.com>; Tue, 22 Sep 2020 08:56:58 -0700 (PDT)
Received: from 13.mo4.mail-out.ovh.net (13.mo4.mail-out.ovh.net [178.33.251.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 112203A1050 for <cellar@ietf.org>; Tue, 22 Sep 2020 08:56:57 -0700 (PDT)
Received: from player698.ha.ovh.net (unknown [10.108.42.170]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id BABFD24E3AB for <cellar@ietf.org>; Tue, 22 Sep 2020 17:56:55 +0200 (CEST)
Received: from mediaarea.net (p548f92df.dip0.t-ipconnect.de [84.143.146.223]) (Authenticated sender: jerome@mediaarea.net) by player698.ha.ovh.net (Postfix) with ESMTPSA id E961B16623EB0; Tue, 22 Sep 2020 15:56:47 +0000 (UTC)
Authentication-Results: garm.ovh; auth=pass (GARM-103G0051531b214-729a-427a-b19c-d8d90048421d, 718808425E05DC05DB325B3072315A76E660D1E1) smtp.auth=jerome@mediaarea.net
To: Erik Kline <ek.ietf@gmail.com>, The IESG <iesg@ietf.org>
Cc: draft-ietf-cellar-ffv1@ietf.org, cellar-chairs@ietf.org, cellar@ietf.org, Michael Richardson <mcr+ietf@sandelman.ca>, "Peter B." <pb@das-werkstatt.com>
References: <160075274666.1307.15063603679468881336@ietfa.amsl.com>
From: Jerome Martinez <jerome@mediaarea.net>
Message-ID: <7c1e4bdd-2b9a-d51d-381b-fbe9cf27490f@mediaarea.net>
Date: Tue, 22 Sep 2020 17:56:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <160075274666.1307.15063603679468881336@ietfa.amsl.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Ovh-Tracer-Id: 2217741345573507181
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrudeggdelhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpeflvghrohhmvgcuofgrrhhtihhnvgiiuceojhgvrhhomhgvsehmvgguihgrrghrvggrrdhnvghtqeenucggtffrrghtthgvrhhnpeekhfdvgfeuhffggefhfffhtdehfffhudeuveejtdfgjefgleelueejheetfffgjeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppedtrddtrddtrddtpdekgedrudegfedrudegiedrvddvfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrheileekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepjhgvrhhomhgvsehmvgguihgrrghrvggrrdhnvghtpdhrtghpthhtoheptggvlhhlrghrsehivghtfhdrohhrgh
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/0z6eMHIUgEH2eJaVN9jEu54KeAk>
Subject: Re: [Cellar] Erik Kline's No Objection on draft-ietf-cellar-ffv1-17: (with COMMENT)
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2020 15:57:00 -0000

Hi Erik,

Thank you for your feedback.
I handled the issues in the following PR:
https://github.com/FFmpeg/FFV1/pull/229
And it is being reviewed by other FFV1 spec authors.

Jérôme

On 22/09/2020 07:32, Erik Kline via Datatracker wrote:
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> [[ comments ]]
>
> [ section 3.3 ]
>
> * Suggest either defining colorspace_type value and coder_type values
>    before using them, or provide a reference in this section (i.e. just
>    include a reference to sections 4.2.3 and 4.2.5).
>
>
> [[ nits ]]
>
> [ section 3.2 ]
>
> * In the description of Figure 3:
>    "relatively positions" -> "relatively positioned", I think.
>
> [ section 3.3 ]
>
> * "signed 16-bit signed integer": choose any one instance of 'signed', I'd say
>
> [ section 3.7.2 ]
>
> * "and then if used transparency" -> "and then, if used, transparency"