[Cellar] Re: Mike Bishop's Discuss on draft-ietf-cellar-tags-20: (with DISCUSS and COMMENT)
Mike Bishop <mbishop@evequefou.be> Tue, 13 January 2026 22:14 UTC
Return-Path: <mbishop@evequefou.be>
X-Original-To: cellar@mail2.ietf.org
Delivered-To: cellar@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 43489A742B3E; Tue, 13 Jan 2026 14:14:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (1024-bit key) header.d=evequefou.be
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b2vC4fBhdXs3; Tue, 13 Jan 2026 14:14:05 -0800 (PST)
Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11023078.outbound.protection.outlook.com [40.93.201.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id 86888A742B2E; Tue, 13 Jan 2026 14:14:05 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jzEXkCoSMC6KuBD/HdsBNESsOFmKxXbMfdxuLfe8TrtIEf/SyTz/bRxImwSxYgrnlu5rMkZlndZPU6+7P/rxYnq+W4mNZyfYkr8Nnlz9baoHxJ1JYc9W9RQiDXw3BY/lDWJjTf9xMb4fHEnPBM55dc9wjDEesDclTxaee35X7/pV8C6vtpLUJyW14fC4ZXhIOxejIHAqAJt4sXD7gS1XUZ0PcOpjbhZr+YHfJtY9uqxn+g0/5xvX2jEBRydLf6czEO/Qv/TqoBl764UfVbqp8nPLnkews3Oiap5hFl/0zeMtGWzFU8AJIBRiUdpLV0tocxnWJ2iHCPkvk4cpywMDqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CAynxvFU6ety5smMMYLzEyQ7vG7kVO8HNbBNfshn5ZE=; b=H5scXCRqClyiUerWhsw3GSVFfuxOkFeCWQ1juF7bpsOmuPKLRbmXugpXOISeSNwS7bGmjZW9tYAUNh5APzpa8/VEtieKgd4L91YT9U2j116jETHWx1KV5utrFoI0QRdV/styonxltpy35HrboWgTEcRyQV8bZqZayGq5ccWQwD5HGLbGp0KQhHvlCM53yg8Y1lijmBR8aFC5RKMxJbFv8LGjwN+shn/4WpYLB+uxEd2AHDb+DFrIlGr0AFVh0cOpX+va+bDFdhxv6DJbmGcNLYgbvjSXWfgClXA8imUwOh7eqZc5bey/W7cfhuNg6QoKDneWrpJC74l3wazB5qzaAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=evequefou.be; dmarc=pass action=none header.from=evequefou.be; dkim=pass header.d=evequefou.be; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evequefou.be; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CAynxvFU6ety5smMMYLzEyQ7vG7kVO8HNbBNfshn5ZE=; b=eINfBr0yS+zmrfud8lHjZ1rUYYIT9lvqStd24hdqCSuUfYTLqaO7tHhh0rigmT4CrauNEhx7q/H/Boqisjf4AfueZrfcefpAAgx4E/wSflCNHNtDimsmpsZYPwsz4Bd9wp/zGxAqeYEzg5zS2drbs8tUuqXSHIGddyjbabcFCsc=
Received: from IA0PPF726CD7A1F.namprd22.prod.outlook.com (2603:10b6:20f:fc04::d2b) by MW4PR22MB3738.namprd22.prod.outlook.com (2603:10b6:303:1b9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Tue, 13 Jan 2026 22:13:55 +0000
Received: from IA0PPF726CD7A1F.namprd22.prod.outlook.com ([fe80::b39:2a4:130d:7f99]) by IA0PPF726CD7A1F.namprd22.prod.outlook.com ([fe80::b39:2a4:130d:7f99%3]) with mapi id 15.20.9520.003; Tue, 13 Jan 2026 22:13:53 +0000
From: Mike Bishop <mbishop@evequefou.be>
To: Steve Lhomme <slhomme@matroska.org>
Thread-Topic: Mike Bishop's Discuss on draft-ietf-cellar-tags-20: (with DISCUSS and COMMENT)
Thread-Index: AQHcf0Clm3xkoxvM20eFbb7oXonZvrVNBMKAgAOps9A=
Date: Tue, 13 Jan 2026 22:13:53 +0000
Message-ID: <IA0PPF726CD7A1F3C7E339F7302E3566EE3DA8EA@IA0PPF726CD7A1F.namprd22.prod.outlook.com>
References: <176772679572.3594202.16235812320538184444@dt-datatracker-5656579b89-p6k4r> <355BF3D4-C14B-4AF6-9717-C1F7B71F1E34@matroska.org>
In-Reply-To: <355BF3D4-C14B-4AF6-9717-C1F7B71F1E34@matroska.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=evequefou.be;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: IA0PPF726CD7A1F:EE_|MW4PR22MB3738:EE_
x-ms-office365-filtering-correlation-id: 1c0582aa-e18f-4185-976b-08de52f109b2
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|10070799003|366016|376014|38070700021|7053199007|13003099007|8096899003;
x-microsoft-antispam-message-info: z/JwmtHmG5clGcqAXNEx3WS7uthDgi+jW5h7yMCXnwFgmoSLHMhvOd0W8Bv1sDAjb5OFfaKdHIq9+3+XGvSHxzhmPARV5AMsgUHL288S7OWCWNgVqypXTKXZ+TrGIHe5XUaJwKxVjpraQuYiqrdeTsZml12IcYl6Wez1A+v4DnfZ7p0wpxR6NvGbWCAZOWP9V8h6DVT7xFHB0TUMmaFCd/x+YF83SGv1naLz4ey+wA0H4cKbLqxYzP7ZCuq9iujBdIcFTssOf5Kwu3olvps2hVnzRz7xkEgaT0XclhCpQANnSxdL2OW85e9ywbywmrfdod5ughT5ep5Y+88QgFR3CCHgW1kD5mnUyuJDIGdu7tm3fgHlYKdho/z1pYY+knElEo4q3nuVapJL6Z2i0xN+Krq4sqyfwIFYrQ1tjgAjWjgwExln1TF0x5jtdGv6Ti7BWx2OFfPHwYHsMPoxNJncdMP/L5IQBgML5VMtJ/1sbuzJT/MD5FejgS7TL76gk0o+I8eV/7tGDQCh+5agxqkukQZn714la60L/BQHML7DfI11GnxuWOerm3MJldKzgA9jo3PvFXcp0zYACVhmjpWD/DsAwOM82w+0fnyrqrgePYzasm+kHC8nieOuwgGWcnwPrX0FthzYVPYAZ9EYpXlwE45fQ5Wpr+BSg6Sze2HIhVUp1BEEO2UY1yq9srmZEvS9TfPtQ/wrLBJ8dZz7QjXVK86vQi4xvDVSmMhhdSJ6Hmv7d9oxQYZLlGTUBPwUz1qfz6PfTazcZKuOFUEyItQhAZHLUUxWeyG6PzhSTvosOvVfKnxps+ow3v6agPgaRcvnngv8DtTTTsxl6upbxQxCmd0PPS+QfNbCyzDqgiyu0T8QPy1onS35zlGok9rm7stP0QxYsYEA3ZjeuiKwroogYs2rjrF3bSEOdHzhwoM+2M0jtGvs9TppF5Sdf/Fod3tAdDAgRzVsYM1TpmKRMbUJanwBSs1LV5NBGhDy6fHnvFczdFuW8d58HxDO9lynKdba7gsObz+2e/GRC+fJNY7j2kXY6Nbeb9g/Ih/UNqTlha7OmWiGV/MxhhBVcEjAfqQhvh8eOLAw7lJNdMtefDgSzn2S789qVhQwpZpDMaaWpAvfAwI1sqYjktcjIL83BVCLT4GB7MULC3aPAS0nc0m94QsDDvhaI5l3YjZGquLOeaxvEwvmPYmNycLs3vLXYkByB2oylEZcuTjESeQAVUwtVVlgIF6KvcVtSANLn89FKmCLzQvyBC+RC/b3n7ADUPD/U3crlJ7Hdu95TLaPPGUt4kpLVomt2YaBbjkq2Xg7KjomeqAAhiJ2fuJFep57PQ24yTF9cJSWcyVigVVy/IMdqAmlgN8TAuN0I9VlB87VBbpizzC/HaFD3dtrBqgqL5fMc29c7ipOr9krBplVXVemGRlfKDPOpErnWVMgcPfFJOb46gC+TlZm6cRzFQgBJ4mF8Mt71zZZKTwsYfj9KRYhXA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PPF726CD7A1F.namprd22.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(10070799003)(366016)(376014)(38070700021)(7053199007)(13003099007)(8096899003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: FBMfA1hbXG6vZ+LYRcpHD/ibbeQnQuWymZ2/jkCGtXSAbzzZJtaACx3RIJrwO9WZcqk8ZaB1owJpAP/VLkRW9O/i8NC6YQ4ycPaBDLsFG4Jfv7pBvkct2I6l1vuTpbudsrqQJqmXMqJgXG66goF85gh3Nc3RXq5hdBGZWqi2wS3pH8xsK5fXrsrI3AulcTpp1T51AKExqftV7E7Vnb8ncdxFL9rx0DFMfjgCsiYP5GKU+/4KGjL7c+36l3zxro9DVQefjoAndFU6pjnHPy4DkHHzfoUQJ35iGGu5q2DHqGnMYtu9dk0sLoFeqdSi1Mrfy8xEllvszkCVW5SEq0o3aq034yywhQEW+q1st2y1liqHDObie3ukBSFB1v7pzQFrEPhJtozxuLbCWzNtO2qWDDMxFo3Ci17fbcfq7pLAs0L+m1dDAKRlXTmBOKKuGK71yRYS2H7ZZAC1t75fUbGPLzWM70mE5908y3TZ6t8UTeIf7nHWSe+GStrVy5wt6R7i9TbyUIJARRBCDiSTCM3pA6I3YUrWSmC1LKsgFNXNh7g0vyyThxpnLSL0os9s55/k01oHnhk7jEP7IIqHtLpCgYmKfB3mCcllCkenQI4/8+VJFENoIloQR5TLVCgekiOLKCtufO4OQ+I9/5r3BIIR0O5tPN66sC+juOUISfn5CMR1F6EM+s6sawrKbkiFOdL9nTxwGsPYLFoCDBfi/OBMSBGWUik04THw6b3HN0T0t5fWKbSAc9dOaq2xF4UwxDVZ3PW0er4jOJ74yBwLpew0QdylBvTsvb0LwpAEazPIB8myCIUR5UHA9UwaAmeRQ8TyGnWwYzKB2+whfCS+2yIP4Jv6I2eaBcUGppEo5nd7kPsHPWUXAPB6jlo6WnihnSTdYqO9EhArFJD3tjHJYk+nB5gyWLE6C+dD5WOwnxknOhsJy9wYzbzbYZVbcCzVt/km6C1FbSLZNc6CH+w0pfoWSsDKhjfQy1HySa4Gl31aMfzTmensDEyq2sE9rUf/CInQ7EthAfiaGcq71R9la39RS3gAg5LiUfPjZJ7UwBwvgXqvZSB/aM5+gn0XNAwMO2h5WVuw7kb5GIJWhesb/o6mToG0i8mKfk7XYLDeSB+8COzUHvjxM2A0MRoEP+N4vL+2kVW3LB0r++WwyZQzn+9IlXN/XaInIgcC2jC5+ueuyFjqQatBTQzlpk8XOYIsYDFgW023dBmwDbjxMCZZbhefGBBGZ+q1Z0pl0aQW9fVVXCJ4zcvaNaPL5DDkXs1+C1pYK6X3IiNaCoXYeyI5JVel8ANiVkZNAOxuJnY2OD1yT82nMYxPV+xeL/9gJKZZw5jVHjoaTG6JX9A+UoUOQzRz9wKYx28AdXZFriNfs/YoFAOKl7h8U8iN15hYIUf3lPxg5S1dZTxZOuNU9meS1Ibk0fzmTFvW7u/3YYlfNS7NCualQs963YXC17DWLs4ivY/LlOsbwtlDwRq9zOZOrm8oKCryImXvmblGtmKxmL4CBABUBvXcmbdDUw43hwN4D7QEMLg2czOAWRQkThghHvzsACRaq4IZdjVhKrccFhFxNlxahgFcIwpw2OLNs8WmHcrermChrxaMwDEETCY1Hqjj6eTvWd5QU2HYaEB7F6Fqv9l++zY3j4hfXK/B8aKaCuqj5oPwMN0S0v5kFxn6DY9dWc5HF2YQ23HczoEccZ3jqkQvuagXqDeybpb7J8rQPeYRtaGKSXhWJLfBtuTJvq1dJsG/f7nPZSGQRiCYNDGI26TOw4rk16OAOwT/v9lyQ97u
Content-Type: multipart/alternative; boundary="_000_IA0PPF726CD7A1F3C7E339F7302E3566EE3DA8EAIA0PPF726CD7A1F_"
MIME-Version: 1.0
X-OriginatorOrg: evequefou.be
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA0PPF726CD7A1F.namprd22.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c0582aa-e18f-4185-976b-08de52f109b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2026 22:13:53.6001 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 41eaf50b-882d-47eb-8c4c-0b5b76a9da8f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 17J1UancmawcNslGoWl/iC2e0UbS0yiUXNrBK1Np4mMcY44qwe8vLUV82r78DdmFO62L4zGN4YunYMew28zb7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR22MB3738
Message-ID-Hash: 4XM274W3UCP6HFZAXX5RT4VWLSRUYEKX
X-Message-ID-Hash: 4XM274W3UCP6HFZAXX5RT4VWLSRUYEKX
X-MailFrom: mbishop@evequefou.be
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-cellar.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: The IESG <iesg@ietf.org>, "cellar-chairs@ietf.org" <cellar-chairs@ietf.org>, "cellar@ietf.org" <cellar@ietf.org>, "draft-ietf-cellar-tags@ietf.org" <draft-ietf-cellar-tags@ietf.org>, "spencerdawkins.ietf@gmail.com" <spencerdawkins.ietf@gmail.com>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [Cellar] Re: Mike Bishop's Discuss on draft-ietf-cellar-tags-20: (with DISCUSS and COMMENT)
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/mlawqtw6jwC1nBJi1BteM1GY2tI>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Owner: <mailto:cellar-owner@ietf.org>
List-Post: <mailto:cellar@ietf.org>
List-Subscribe: <mailto:cellar-join@ietf.org>
List-Unsubscribe: <mailto:cellar-leave@ietf.org>
Some comments inline with [MB]. ________________________________ From: Steve Lhomme <slhomme@matroska.org> Sent: Sunday, January 11, 2026 8:53 AM To: Mike Bishop <mbishop@evequefou.be> Cc: The IESG <iesg@ietf.org>; cellar-chairs@ietf.org <cellar-chairs@ietf.org>; cellar@ietf.org <cellar@ietf.org>; draft-ietf-cellar-tags@ietf.org <draft-ietf-cellar-tags@ietf.org>; spencerdawkins.ietf@gmail.com <spencerdawkins.ietf@gmail.com> Subject: Re: Mike Bishop's Discuss on draft-ietf-cellar-tags-20: (with DISCUSS and COMMENT) Hi Mike, Thanks a lot for your review. My comments are inline below. On 6 Jan 2026, at 20:13, Mike Bishop via Datatracker <noreply@ietf.org> wrote: Mike Bishop has entered the following ballot position for draft-ietf-cellar-tags-20: Discuss When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-cellar-tags/ ---------------------------------------------------------------------- DISCUSS: ---------------------------------------------------------------------- # IESG review of draft-ietf-cellar-tags-20 CC @MikeBishop ## Discuss ### Focus on interoperability Throughout the draft, but especially in Section 3.1, there are justifications given for the use of "Official" tags. Setting that term aside, there's a word for this problem: it's usually a bad idea to use custom or exotic tags because you will probably be the only person to use this information even though everyone else could benefit from it It's called lack of interoperability. Rephrasing all of this to talk about That’s is indeed a much better and precise word. optimizing for interoperable use of tags would help. For example, in Section 3.1 consider: An application intended for advanced users might permit the insertion of any tag in a file. While this provides maximum flexibility, custom or exotic tags generally limit interoperable use. Well-known tags improve the ability of others to read and reuse them; most applications will therefore use a small list of useful tags. I replaced part of that long paragraph with your text: https://github.com/ietf-wg-cellar/matroska-specification/pull/1058 [MB] Looks good. ### What is "official"? I share others' issues with the term "Official". Enough has been said at enough length, I think. It should be “assigned” instead as in https://github.com/ietf-wg-cellar/matroska-specification/pull/1048 [MB] That's a better term, yes. ### Section 3.2.1, paragraph 1 These are the requirements for a TagName to be registered; focus on the registration. This might be good guidance for a Designated Expert. The IANA section also references this with more consistency using https://github.com/ietf-wg-cellar/matroska-specification/pull/1056 [MB] I think the pieces to separate are: * What is a syntactically valid tag? If my tag is "🤑🤷♂️ Cool story", but I'm not attempting to register it, that's fully compliant with the current text of 3.2.1. (Because I'm not attempting to register it, so the three MUST statements don't attach; the fourth is a RECOMMENDED, so it's not mandatory.) 3.2.1 should focus on syntactic validity. * What tags will be accepted in the registry? If IANA is directed only to register / not to register a certain subset of the tag space, such as saying that registration of tags that begin with an underscore will not be permitted, that belongs in the IANA considerations. ### IANA This document seems to have unresolved IANA issues. Holding a DISCUSS for IANA, so we can determine next steps during the telechat. ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- ## Comments ### Section 3.1 This section could use significant reworking, both for tone and style. ``` There is a debate between people who think all tags should be free and those who think all tags should be strict. Our recommendations are in between. ``` First, you're inviting the "free as in beer / free as in speech" question, when you actually mean neither -- I believe you actually mean "free-form". Yes. See https://github.com/ietf-wg-cellar/matroska-specification/pull/1057 [MB] Looks good. Second, RFCs should generally avoid the first-person. Maybe "This document's"? Consider removing the first/second-person usage throughout the document. Yes, this have been changed in https://github.com/ietf-wg-cellar/matroska-specification/pull/1052 [MB] That addresses three instances, but the document is filled with second-person. You can be much more brief about the ability to register new tags. For example: New tags can be added to the Matroska Tags Names registry (Section 6.1). However, this registry is not meant to have every possible piece of information; many attributes would be better stored on a website and retrieved using an identifier for the content. The discussion of which new tags might not be appropriate seems more geared to a Designated Expert than to someone attempting to implement the specification. Consider moving that elsewhere. For the more generic tag names, because it’s free-form and we have a ton of legacy values, I think First Come First Served is the preferred policy. [MB] That's reasonable, assuming your registration requirements are crisp enough that IANA can enforce them without consultation. ### Section 3.2.2, paragraph 1 ``` should be used so everyone can agree on how to use the value. ``` ...so as to improve interoperability. Added to https://github.com/ietf-wg-cellar/matroska-specification/pull/1058 ### Section 3.2.2.2, paragraph 3 "Consider" is not an interoperability requirement. This is the behavior that a reader SHOULD (or MAY) employ to handle such legacy tags. Indeed, I fixed the word in https://github.com/ietf-wg-cellar/matroska-specification/pull/1059 “A `Matroska Reader` **SHOULD** use the following character handling to parse such legacy formats" [MB] Looks good. ### Section 3.3, paragraph 7 This can be condensed; consider: This means that if an album has the same artist for all tracks, the "ARTIST" tag with TargetTypeValue 50 (ALBUM) is sufficient. It is not necessary to repeat the value for each track with TargetTypeValue 30 (TRACK) unless there are exceptions. If some tracks of that album have no known "ARTIST", the value MUST be set to an empty string ("") as detailed in Section 24.2 of [RFC9559], so that the album "ARTIST" doesn't apply. It is actually longer than the original. Also that means we would need even more text to define the exceptions. [MB] So it is -- sorry. ### Section 3.3, paragraph 8 Or below? Presumably stopping a value at one level also cascades. From the rule in the previous paragraph, the value for a given TagName applies to all below levels, unless that TagName is set to a different value. ### Section 3.3.1, paragraph 9 Does the use of a real album add to the understanding of the example? Please review the final paragraph of the [IESG Statement on Assignable Codepoints for Examples in IETF Specifications](https://datatracker.ietf.org/doc/statement-iesg-statement-on-assignable-codepoints-for-examples-in-ietf-specifications/). I changed this in https://github.com/ietf-wg-cellar/matroska-specification/pull/1045 [MB] Looks good. ### Section 3.3.1, paragraph 9 Consider moving these examples to an appendix. I think having the examples next to the rules explanations is better for readability. ### Section 4.10, paragraph 1 "usually" implies that they're not always. What do you do if they aren't? Until recently, when we added the EBU loudness values, there was only one binary Tag, and it’s not in this section. If they aren’t they must be parsed according to the description. At least for the values that need to be used for playback like replaygain. ### DOWNREFs Many possible DOWNREFs from this Standards Track doc to `[ID3v2.4]`, `[EBU-TECH.3342]`, `[ISRC]`, , `[EBU-TECH.3341]`, `[EBU-R.128]`, `[ReplayGain]`, `[IMDb]`, `[ISBN]`, `[GS1]`, `[MovieDB]`, `[ID3v2.3]`, `[ISO4217]`, `[IEEE.754]`, `[TheTVDB]`, `[LCCN]`. These all look appropriate in context, but the IESG may need to approve these. Given to interpret the values of these tags we need to have these specifications, I think they are normative. ## Nits All comments below are about very minor potential issues that you may choose to address in some way - or ignore - as you see fit. Some were flagged by automated tools (via https://github.com/larseggert/ietf-reviewtool) so there will likely be some false positives. There is no need to let me know what you did with these suggestions. Unless commented below I put your suggestions in this (big) Pull Request: https://github.com/ietf-wg-cellar/matroska-specification/pull/1061 ### Typos #### Section 3, paragraph 14 ``` - In this way, it becomes possible to store any SimpleTag as attributes - - + In this way, it becomes possible to store any SimpleTag as an attribute + +++ ``` #### Section 3.2.1, paragraph 4 ``` - '_' for non official tags that are not meant to be added to the list - --- + '_' for unofficial tags that are not meant to be added to the list + + ``` This has been turned into unassigned in https://github.com/ietf-wg-cellar/matroska-specification/pull/1048 #### Section 3.2.2, paragraph 3 ``` - but given there is no defined delimiters they cannot be easily split - ^^ + but given there are no defined delimiters, they cannot be easily split + ^^^ + ``` #### Section 3.2.2, paragraph 4 ``` - Due to the varied nature of tag sources it may also not always - ----- + Due to the varied nature of tag sources it may not always be + +++ ``` This paragraph is a followup to the varied sources in the previous paragraph. So I think “also” works here. #### Section 3.2.2.1, paragraph 2 ``` - To store less accurate dates, parts of the date string are removed - ^ ^^ + To store less accurate timestamps, parts of the date string are removed + ^^^^^^ ^^ ``` Given “date string” is used right after it’s odd to use timestamps here when it’s not used anywhere else. #### Section 3.3, paragraph 3 ``` - For human readability a TargetType string can be added next to the + For human readability, a TargetType string can be added next to the + + ``` #### Section 3.3, paragraph 9 ``` - Multiple SimpleTag with the same TagName can be used at a given + Multiple SimpleTags with the same TagName can be used at a given + + ``` #### Section 3.3.1, paragraph 6 ``` - For example if you have an album with 10 tracks and you want to tag - the second track from it. You set "TOTAL_PARTS" to "10" at - ^^^^ -------- + For example if an album has 10 tracks, + the second track can indicate this. "TOTAL_PARTS" is set to "10" at + ^^^ +++++ ++++++ +++++++ ``` I reworded your suggestion a little: “For example if an album has 10 tracks, tag the second track from it, you set "TOTAL_PARTS" to "10" at `TargetTypeValue` 50 (ALBUM)." #### Section 3.3.1, paragraph 6 ``` - that is specified in the file. So, if it's TargetTypeValue = 30 - ------------ ``` I prefer to keep this to make it less abstract. #### Section 3.3.1, paragraph 6 ``` - (TRACK), then that means the album contains 10 tracks. If - - ^^^^^^^^^ - ^^^^^ - TargetTypeValue is 20 (MOVEMENT), that means the album contains 10 - ^^ - ^^^^ - - movements, etc. And since it's the second track within the album, - ^^^^^^^^^^^^^^ + (TRACK) would mean the album contains 10 tracks, + ^^^^^ ^ + TargetTypeValue = 20 (MOVEMENT) would mean the album contains 10 + ^ ^^^^^ + movements, etc. For the second track within the album, + ^^^ ``` ### Section 3.3.1, paragraph 7 Consider a bulleted list here. This list of tags is quite dense. #### Section 3.3.1, paragraph 7 ``` - If the parts are split into multiple logical entities, you can also - use "PART_OFFSET". For example you are tagging the third track of - the second CD of a double CD album with a total of 10 tracks the - ^ + the second CD of a double-CD album with a total of 10 tracks the + ^ ``` Form what I understand you’re suggesting to remove the part that talks about PART_OFFSET. This would be odd given that’s the point of that paragraph. #### Section 3.3.1, paragraph 8 ``` - When a TargetTypeValue level doesn't exist it MUST NOT be specified + When a TargetTypeValue level doesn't exist, it MUST NOT be specified + + ``` #### Section 3.4, paragraph 2 ``` - words the tags apply to each entity defined by a UID. This is the + words, the tags apply to each entity defined by a UID. This is the + + ``` #### Section 4.1, paragraph 2 ``` - | | | tags) to country specific information | - ^ ^ -- + | | | tags) with country-specific information | + ++ ^ ^ ``` #### Section 4.9, paragraph 2 ``` - | | | number is between 0 and 5 with stored | - ^^^^^ + | | | number is between 0 and 5, stored | + ^ ``` #### Section 5, paragraph 6 ``` - contain a URL. Bogus or altered URLs may direct the user to unwanted - ^ - + contain a URL. Malicious or altered URLs may direct the user to unwanted + ^^^^^^ ``` A URL may be bogus without it being a malicious intent. #### Section 5, paragraph 7 ``` - add some limits to the amount of nesting possible to avoid such - --------- ---- ``` If I remove that whole block sentence becomes “A host app **MAY** issues" That does not seem right. ### URLs These URLs in the document can probably be converted to HTTPS: * http://wiki.hydrogenaud.io/index.php?title=Replay_Gain_specification Fixed in https://github.com/ietf-wg-cellar/matroska-specification/pull/1060 ### Grammar/style #### Section 3.2.2.2, paragraph 1 ``` on-number character are found, they are be ignored, * if only one "." charact ^^^^^^ ``` Consider using either the present participle "are being" or "are to be" here. I used “are ignored”. It matches with the other sentences. #### Section 3.3, paragraph 2 Consider reworking this to be more concise. For example, To relate information (e.g., "TITLE") to a certain scope (CD title or track title), TargetTypeValue values and TargetType names can be used. The same tag name can have different meanings depending on its TargetTypeValue. It is more concise but it’s less clear that for each level (that you call scope) we need a set of TargetTypeValue and TargetType. And that’s why the TargetTypeValue is impossible for each TargetType. #### Section 3.3, paragraph 9 ``` etTypeValue 30 (TRACK) is "3", and the the "PART_OFFSET" at TargetTypeValue 3 ^^^^^^^ ``` Possible typo: you repeated a word. #### Section 4.10, paragraph 2 ``` | | (track, album, etc). | +-------------------------------- ^^^ ``` In American English, abbreviations like "etc." require a period. #### Section 4.10, paragraph 2 ``` | | (track, album, etc). | +-------------------------------- ^^^ ``` In American English, abbreviations like "etc." require a period. #### Section 4.10, paragraph 2 ``` OC of | | | | the CDROM that this item was taken | | ^^^^^ ``` Consider using "CD-ROM". #### Section 4.11, paragraph 1 ``` e diffusion of files containing these information. 6. IANA Considerations 6.1 ^^^^^^^^^^^^^^^^^ ``` The plural determiner "these" does not agree with the singular noun "information". Indeed, in English information cannot be counted whereas in French it can. I would use “informations” but it doesn’t seem correct: https://en.wiktionary.org/wiki/informations#English I used "pieces of information", although I always find this concept very odd. #### Section 5, paragraph 4 and 5 ``` - String tags that are parsed like "REPLAYGAIN_GAIN" or - ^^^^ - "REPLAYGAIN_PEAK" defined in Section 4.10 or string tags following - ^^^ - the rules from Section 3.2.2 or string tags following other strict - formats like URLs may cause issues when the string is bogus or in an - --------- + String tags that are parsed (such as "REPLAYGAIN_GAIN" or + ^^^^^^^^ + "REPLAYGAIN_PEAK", defined in Section 4.10), string tags following + ^ ^^ + the rules from Section 3.2.2, or string tags following other strict + + ``` ``` - Binary tags that need to be parsed like "MCDI" defined in - ^^^^ - Section 4.11 may cause issues when the data is bogus or incomplete. - ^^^^^ + Binary tags that need to be parsed (such as "MCDI", defined in + ^^^^^^^^ + + Section 4.11) may cause issues when the data is invalid or incomplete. + + ^^^^^^^ ``` Using "like" here is ambiguous as to whether you're referring to tags which require parsing (and these are examples) or to the set of tags whose parsing method is similar to that of these tags.
- [Cellar] Mike Bishop's Discuss on draft-ietf-cell… Mike Bishop via Datatracker
- [Cellar] Re: Mike Bishop's Discuss on draft-ietf-… Steve Lhomme
- [Cellar] Re: Mike Bishop's Discuss on draft-ietf-… Spencer Dawkins at IETF
- [Cellar] Re: Mike Bishop's Discuss on draft-ietf-… Mike Bishop
- [Cellar] Re: Mike Bishop's Discuss on draft-ietf-… Steve Lhomme
- [Cellar] Re: Mike Bishop's Discuss on draft-ietf-… Spencer Dawkins at IETF
- [Cellar] Re: Mike Bishop's Discuss on draft-ietf-… Mike Bishop
- [Cellar] Re: Mike Bishop's Discuss on draft-ietf-… Steve Lhomme
- [Cellar] Re: Mike Bishop's Discuss on draft-ietf-… Mike Bishop