Re: [Cellar] [Gen-art] Genart last call review of draft-ietf-cellar-ffv1-16

Alissa Cooper <alissa@cooperw.in> Thu, 24 September 2020 02:31 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7FAE3A1718; Wed, 23 Sep 2020 19:31:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.119
X-Spam-Level:
X-Spam-Status: No, score=-2.119 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=KE11sHY0; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=RuG4YkX0
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MImJm7Mz8YZN; Wed, 23 Sep 2020 19:31:07 -0700 (PDT)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DF1683A1717; Wed, 23 Sep 2020 19:31:06 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 222455C00FB; Wed, 23 Sep 2020 22:31:06 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 23 Sep 2020 22:31:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm1; bh=KVsxtM+ADy2bX3jic0Wt03C BVvdAitN7H3IAirZnNLA=; b=KE11sHY0dEyvAe24oy30YRdAo3ow1OaYGGs1lX8 aIBKIJROj+1PJbAUyPig9ayhv0xbBPvtTDtA+m95tFIAyDTbUvcSxKu7irQ1vX9X IdXfbPRBKtd8fep7PSYCnpuVhMutrrAElyGPX3CN7xEv1CElspLE5Sh3M5HFTmy2 4QLB+lvqRGzMWavmns6aoWX5so7b4rsgSWkh2o9pkR0wpaUSJbsRExBo910zjW6H ekWPC20a41KPx9Fgrd8eJ48ULE3qeW+53oRpQZPpR0SvxzDhqr28zZF6i9hhaTxl Z3M2FOBBG1lw5YyPVPEHx19vZdiRdr+2BhY3CJTJ1qpqaCg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=KVsxtM +ADy2bX3jic0Wt03CBVvdAitN7H3IAirZnNLA=; b=RuG4YkX0iG1r97SrZkLkGC QsS/oQjOhIrsIq8RegBtSOs0q1mdXo98ajJzawY2uvzSQC3Sie+yCWjB2HvfGD+N VmGMEjRJsINP+mLp6XbRGjdjM1JlI8Hsonpbz7xG/gUjG2lPlL3vWbIfexu6V5V1 bomqCWCRvFGm7yU9uy7bM7YoCdlER5ycBnbefCtft2jBSY+ysWSZPqdebaA2Jvbx Aqm01YXEzQMR1wzSH/xx5yYH5JcfCLRuaAxCH/bqfqStUy6PLlmczlFLq1U7T426 AsJz+ou5+upSRJVzxAT4q0wD0va9YP6et+F7SssF8waOvccOojqlK/EhefHEjvww ==
X-ME-Sender: <xms:6QRsX8s6LTdNGDVSgQmoxuIv-ZwJD-QXw4YBF2zOyNCSrxpyUL3upA> <xme:6QRsX5eGLqbAofRxVkFnA-JKWOC5n5Zc1gmmztoyfv-P-oqLlRiuiYqxTmKOv6NVY LM4yYqlP5O-UxTRSg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhkfgtggfuffgjvfhfofesrgdtmherhhdtjeenucfhrhhomheptehlihhsshgr ucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucggtffrrghtth gvrhhnpeeggefffeduvdfffeelgfehkedtiefghefftdetteeifeefhfefudegudeuvdev hfenucffohhmrghinhepihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddujedrje ejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghl ihhsshgrsegtohhophgvrhifrdhinh
X-ME-Proxy: <xmx:6QRsX3xQT4uE4JBOp3XcvKA_qZfE7fLkgebXfINgk_AgOp-Dl3Px_g> <xmx:6QRsX_MYSJLgHYuevY7iywMvRWK5Sn-lWdSa_5tMrQu9tSUW2Ahbag> <xmx:6QRsX8-1ZAX10fKZ7EnnNAJ_5TjqAUHu70Nh5-YbXmAbfp71UoEY5g> <xmx:6gRsX7b-rgvnDSqCbcBsssqeZ8eEGZByfW5or8sLHjnl9kX4pQcnnA>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.77]) by mail.messagingengine.com (Postfix) with ESMTPA id 581703064674; Wed, 23 Sep 2020 22:31:05 -0400 (EDT)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <1DAF68ED-510B-4960-B1F2-4647073F5274@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_3430C6E0-07F9-4120-AB8B-424CC1C9B27E"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Date: Wed, 23 Sep 2020 22:31:04 -0400
In-Reply-To: <CAKKJt-diqzeNh1jw8M+GKYRWX_1g73LH1tDpQTSW40W1K8bF1Q@mail.gmail.com>
Cc: last-call@ietf.org, gen-art <gen-art@ietf.org>, Codec Encoding for LossLess Archiving and Realtime transmission <cellar@ietf.org>, draft-ietf-cellar-ffv1.all@ietf.org
To: Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com>, Joel Halpern <jmh@joelhalpern.com>
References: <159470027331.24170.16229303627582288772@ietfa.amsl.com> <CAKKJt-diqzeNh1jw8M+GKYRWX_1g73LH1tDpQTSW40W1K8bF1Q@mail.gmail.com>
X-Mailer: Apple Mail (2.3608.120.23.2.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/wIREQT91llEmRzUT0y2n4bnBkME>
Subject: Re: [Cellar] [Gen-art] Genart last call review of draft-ietf-cellar-ffv1-16
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Sep 2020 02:31:10 -0000

Joel, thanks for your review. Spencer, thanks for helping to get Joel’s comments addressed. I entered a No Objection ballot.

Alissa


> On Jul 16, 2020, at 11:17 AM, Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com> wrote:
> 
> Hi, Joel, 
> 
> On Mon, Jul 13, 2020 at 11:17 PM Joel Halpern via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
> Reviewer: Joel Halpern
> Review result: Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>>.
> 
> Document: draft-ietf-cellar-ffv1-16
> Reviewer: Joel Halpern
> Review Date: 2020-07-13
> IETF LC End Date: 2020-07-16
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: This document appears to be ready for publication as an Informational
> RFC.
> 
> *I would have raised question about the intended status, but it appears that
> this is an established IETF convention and I see no reason to argue.)
> 
> Major issues:
> 
> Minor issues:
>     Section 3.4 (Context) introduces the notation Q_{#}[ subscript }.  As that
>     is the first reference to Q_{#}, it is rather confusing to the reader.  I
>     grant that the term is defined in the next section (3.5).  Couldn't they be
>     reversed?
> 
>     Section 3.8.1.1 refers to C(i), C_{i}, and C_i.  Are these all the same
>     thing.
> 
>     Section 3.8.1.2 refers to get-rac (which is treated as a function in the
>     pseudo-code) as being the process described in section 3.8.1.1.  The text
>     in 3.8.1.1 does not call out any of its computed values as an explicit
>     result or return.  While I would guess that the intention is to use the
>     byte stream (B()), the text does not actually say that.  If that is the
>     intention, could the last line of 3.8.1.1 be "get_rac() returns sequential
>     bytes from the Byte Stream (B()) as computed by the computation described
>     in section 3.8.1.1"?
> 
> Nits/editorial comments:
> 
> Thanks for the review! We'll work through these comments.
> 
> Best,
> 
> Spencer 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art