Re: [clue] AD Review: draft-ietf-clue-protocol-13

Adam Roach <adam@nostrum.com> Thu, 09 August 2018 00:58 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: clue@ietfa.amsl.com
Delivered-To: clue@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E9C5130F43 for <clue@ietfa.amsl.com>; Wed, 8 Aug 2018 17:58:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.878
X-Spam-Level:
X-Spam-Status: No, score=-1.878 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7_UEx3r2psyC for <clue@ietfa.amsl.com>; Wed, 8 Aug 2018 17:58:00 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EDB98130F2F for <clue@ietf.org>; Wed, 8 Aug 2018 17:57:59 -0700 (PDT)
Received: from Svantevit.roach.at (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id w790viIG032345 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 8 Aug 2018 19:57:55 -0500 (CDT) (envelope-from adam@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be Svantevit.roach.at
To: Simon Pietro Romano <spromano@unina.it>
Cc: clue@ietf.org, Roberta Presta <roberta.presta@unina.it>
References: <a30828ea-1db8-fccd-9c2b-ddc0a1dcb08d@nostrum.com> <8D2EDAF8-014E-477A-AECD-79D944EA4503@unina.it> <ac30c041-b269-484f-023a-0e8723133a5c@nostrum.com> <216405E3-5A89-4FF2-9C89-CEDA03BF6A04@unina.it> <3fdd8d7e-fcc6-7bac-0d03-3873973a875d@nostrum.com> <8DAFF0AE-34FC-473E-B9F0-31DA32ED22BF@unina.it>
From: Adam Roach <adam@nostrum.com>
Message-ID: <6eed0a22-8864-9631-4ee9-33773e1b6b10@nostrum.com>
Date: Wed, 08 Aug 2018 19:57:39 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <8DAFF0AE-34FC-473E-B9F0-31DA32ED22BF@unina.it>
Content-Type: multipart/alternative; boundary="------------9D02C27149CFF486603F8DE5"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/clue/1XWnBMEEOP7xkDSdDLUWm4_9X68>
Subject: Re: [clue] AD Review: draft-ietf-clue-protocol-13
X-BeenThere: clue@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: CLUE - ControLling mUltiple streams for TElepresence <clue.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/clue>, <mailto:clue-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/clue/>
List-Post: <mailto:clue@ietf.org>
List-Help: <mailto:clue-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/clue>, <mailto:clue-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2018 00:58:09 -0000

Thanks for all the work you've done here; things are looking to be in 
good shape. I just went over all the changes from -13 to -16, and they 
look good to me. I believe that my initial review feedback has been 
addressed, and I have only a small handful of nits that you should 
address when you fix the <sceneViewIDREF> problem you describe below. (I 
see no problem with your proposed solution, but I don't claim to fully 
understand the ramifications).

I'm ready to put this document (and the signaling document) into IETF 
last call as soon as the issue you've identified below has been resolved.

My list of nits with the -16 version follows.

---------------------------------------------------------------------------

Please update the reference to RFC 5226 to instead indicate RFC 8126.

---------------------------------------------------------------------------

Please update the reference to RFC 5117 to instead indicate RFC 7667.

---------------------------------------------------------------------------

§10.2: The title of this section should refer to 'options', not 'option'

---------------------------------------------------------------------------

Figure 15:

 > targetNamespace="http://example.extensions.com/myVideoExtensions"
  ...
 >  xmlns="http://example.extensions.com/myVideoExtensions"

The domain "extensions.com" is owned by the company "Hair Extensions 
Solutions,
LLC" and not appropriate for use in an RFC. Please change to, e.g.,
"extensions.example.com".

---------------------------------------------------------------------------

§12.1:

 >   This section registers a new XML namespace,
 >   ""urn:ietf:params:xml:ns:clue-protocol"".
      ^                                    ^

This line still has too many quotation marks.

---------------------------------------------------------------------------

§12.1:

 >  This section registers the ""application/clue+xml"" MIME type.
                               ^                      ^

This line still has too many quotation marks.

---------------------------------------------------------------------------

/a


On 8/6/18 5:09 AM, Simon Pietro Romano wrote:
> Hello Adam!
>
> version -16 of the draft had just been posted. You’ll find there a 
> whole new section (section 10) about the requested call flow. We have 
> added validated excerpts of all of the messages.
> You’ll notice that we put the following note at the end of the 
> introductory part of section 10:
>
> [[NOTE TO IANA/RFC-EDITOR: For sections 10.1 through 10.9, please 
> replace the clue-protocol xsi:schemaLocation URL (which is currently 
> set to 
> http://wpage.unina.it/spromano/clue-protocol-15-schema-file.xsd) with 
> the right (and final) URL for this specification. The URL ib question 
> is a temporary one, which was published on-line in order to allow for 
> proper validation of the XML excerpts contained in the call flow 
> sections.]]
>
> This was needed because we had to refer to the clue protocol schema 
> file in order to validate the messages.
>
> Please read below for a further (minor) issue we encountered…
>
> ****************************************************************************************************************************************
> NOTE TO THE GROUP, DATA MODEL RELATED:
>
> While doing the call flow homework, we realized there’s a minor 
> modification that would be desirable inside the data model schema. 
> Namely, there is a “sceneViewIDREF” field that we defined ad IDREF (In 
> terms of XML datatypes). This seemed OK at that time. Though, we now 
> realized that it prevents correct validation of CONFIGURE messages, An 
> example of the mentioned issue can be found in the (NOT currently 
> valid) “Conf+Ack” excerpt I am attaching g below (where the culprit is 
> in bold):
>
> <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> <ns2:configure xmlns="urn:ietf:params:xml:ns:clue-info"
>  xmlns:ns2="urn:ietf:params:xml:ns:clue-protocol"
>  xmlns:ns3="urn:ietf:params:xml:ns:vcard-4.0"
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>  xsi:schemaLocation="urn:ietf:params:xml:ns:clue-protocol 
> http://wpage.unina.it/spromano/clue-protocol-15-schema-file.xsd"
>  protocol="CLUE" v="2.7">
>     <ns2:clueId>CP2</ns2:clueId>
>     <ns2:sequenceNr>22</ns2:sequenceNr>
>     <ns2:advSequenceNr>11</ns2:advSequenceNr>
>     <ns2:ack>200</ns2:ack>
>     <ns2:captureEncodings>
>         <captureEncoding ID="ce123">
>            <captureID>AC0</captureID>
>            <encodingID>ENC4</encodingID>
>         </captureEncoding>
>         <captureEncoding ID="ce223">
>            <captureID>VC3</captureID>
>            <encodingID>ENC1</encodingID>
>            <configuredContent>
> * <sceneViewIDREF>SE1</sceneViewIDREF>*
>            </configuredContent>
>        </captureEncoding>
>     </ns2:captureEncodings>
> </ns2:configure>
>
> In order to sort this issue out, it would be sufficient to modify the 
> above mentioned IDREF type and let it become a simpler xs:string. With 
> this modification, we might seamlessly reuse such a data model 
> structure inside CLUE Configure messages (and not just inside 
> Advertisements when describing MCC captures). Do you all agree on this 
> proposal?
>
> ****************************************************************************************************************************************
>
> Cheers,
>
> Simon
>
>
>
>
>          _\\|//_
> ( O-O )
> ~~~~~~~~~~~~~~~~~~~~~~o00~~(_)~~00o~~~~~~~~~~~~~~~~~~~~~~~~
> Simon Pietro Romano
>  Universita' di Napoli Federico II
>    Computer Engineering Department
>            Phone: +39 081 7683823 -- Fax: +39 081 7683816
>                                            e-mail: spromano@unina.it 
> <mailto:spromano@unina.it>
>
>   <<Molti mi dicono che lo scoraggiamento è l'alibi degli
>   idioti. Ci rifletto un istante; e mi scoraggio>>. Magritte.
>                    oooO
>        ~~~~~~~~~~~~~~~~~~~~~~~(   )~~~ Oooo~~~~~~~~~~~~~~~~~~~~~~~~~
>                \ (            (   )
>                                 \_)          ) /
>              (_/
>
>
>
>> Il giorno 18 mag 2018, alle ore 04:54, Adam Roach <adam@nostrum.com 
>> <mailto:adam@nostrum.com>> ha scritto:
>>
>> [re-sending due to an IETF mailing list server outage]
>>
>> On 4/11/18 12:31 PM, Simon Pietro Romano wrote:
>>> Hello Adam!
>>>
>>> We finally managed to get our review done. Please find our answers 
>>> in-line, [SPR]-prefixed, as usual.
>>>
>> ...
>>
>>> [SPR] We have not yet added this consideration to the draft. I 
>>> personally believe this makes sense. Do you think we should add this 
>>> as a general consideration when introducing the overall state machines?
>>
>> That would probably be an improvement, yes.
>>
>> ...
>>
>>> [SPR] We will keep this as an Action Point for us, to be fulfilled 
>>> before submitting the very last version of the draft.
>>
>>
>> Just a heads up that I'm waiting for the document to 
>> incorporate these two open items before progressing it. Thanks!
>>
>> /a
>