Re: [clue] Roman Danyliw's No Objection on draft-ietf-clue-datachannel-15: (with COMMENT)

Roman Danyliw <rdd@cert.org> Thu, 11 April 2019 14:49 UTC

Return-Path: <rdd@cert.org>
X-Original-To: clue@ietfa.amsl.com
Delivered-To: clue@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C39D12025E; Thu, 11 Apr 2019 07:49:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a1N6Ng9uwg6N; Thu, 11 Apr 2019 07:49:48 -0700 (PDT)
Received: from veto.sei.cmu.edu (veto.sei.cmu.edu [147.72.252.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 582BF1200D7; Thu, 11 Apr 2019 07:49:48 -0700 (PDT)
Received: from delp.sei.cmu.edu (delp.sei.cmu.edu [10.64.21.31]) by veto.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x3BEngNk008598; Thu, 11 Apr 2019 10:49:42 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 veto.sei.cmu.edu x3BEngNk008598
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1554994182; bh=g7CG+6MWpfhKuv5YXyRa5fnJiEssvYygoq6unwrsyr4=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=TlTDzyKmnryB8XPIuxXtjLTNXOwH2MicVrPneCyHtFZUEaVE1oRR9HvLrNNXpq0ZG 9XqyDmw3+68nODqms3j6AxUp96ub0NUrprE0HStGrx9ZPxA04K8mmWYG7Ejz7uXgL7 Shg1iy9jBVqjEdogX35OB/eH4H3dNIAxHmzbCH9U=
Received: from CASCADE.ad.sei.cmu.edu (cascade.ad.sei.cmu.edu [10.64.28.248]) by delp.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x3BEneKD019824; Thu, 11 Apr 2019 10:49:40 -0400
Received: from MARCHAND.ad.sei.cmu.edu ([10.64.28.251]) by CASCADE.ad.sei.cmu.edu ([10.64.28.248]) with mapi id 14.03.0435.000; Thu, 11 Apr 2019 10:49:39 -0400
From: Roman Danyliw <rdd@cert.org>
To: Christer Holmberg <christer.holmberg@ericsson.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-clue-datachannel@ietf.org" <draft-ietf-clue-datachannel@ietf.org>, Paul Kyzivat <pkyzivat@alum.mit.edu>, "clue-chairs@ietf.org" <clue-chairs@ietf.org>, "clue@ietf.org" <clue@ietf.org>
Thread-Topic: Roman Danyliw's No Objection on draft-ietf-clue-datachannel-15: (with COMMENT)
Thread-Index: AQHU7/9WxohfpwXWdkKEfznZqLk1w6Y2/uGAgAAMbuA=
Date: Thu, 11 Apr 2019 14:49:38 +0000
Message-ID: <359EC4B99E040048A7131E0F4E113AFC01B3327ECC@marchand>
References: <155494329235.22694.2977698573542744808.idtracker@ietfa.amsl.com> <09C84C5D-E295-479F-B5E6-CA38696E8F00@ericsson.com>
In-Reply-To: <09C84C5D-E295-479F-B5E6-CA38696E8F00@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.22.6]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/clue/EOPm7y7ZNDqu0QTjj9f6G6kXqLI>
Subject: Re: [clue] Roman Danyliw's No Objection on draft-ietf-clue-datachannel-15: (with COMMENT)
X-BeenThere: clue@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: CLUE - ControLling mUltiple streams for TElepresence <clue.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/clue>, <mailto:clue-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/clue/>
List-Post: <mailto:clue@ietf.org>
List-Help: <mailto:clue-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/clue>, <mailto:clue-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2019 14:49:51 -0000


> -----Original Message-----
> From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
> Sent: Thursday, April 11, 2019 6:04 AM
> To: Roman Danyliw <rdd@cert.org>rg>; The IESG <iesg@ietf.org>
> Cc: draft-ietf-clue-datachannel@ietf.org; Paul Kyzivat
> <pkyzivat@alum.mit.edu>du>; clue-chairs@ietf.org; clue@ietf.org
> Subject: Re: Roman Danyliw's No Objection on draft-ietf-clue-datachannel-
> 15: (with COMMENT)
> 
> Hi Roman,
> 
> Thank You for the review! Please see inline.
> 
>     ----------------------------------------------------------------------
>     COMMENT:
>     ----------------------------------------------------------------------
> 
>     A few nits:
> 
> >    (1) Section 1.  Typo (missing space).
> >
> >    s/[I-D.ietf-clue-protocol]messages/
> >    [I-D.ietf-clue-protocol] messages/
> 
> Will fix.
> 
> ---
> 
> >    (2) Section 1. Editorial Nit.
> >
> >    s/data channel Establishment Protocol/
> >    Data Channel Establishment Protocol/
> 
> Will fix.
> 
> ---
> 
> >    (3) Section 3.2.1, Typo
> >
> >    s/(e.g. regarding ordered delivery )/
> >    (e.g., regarding ordered delivery)/
> 
> Will fix.
> 
> ---
> 
> >    (4) Section 3.2.1.  Typo.  s/signalled/signaled/
> 
> Will fix.
> 
> ---
> 
> >    (5) Section 3.2.3, Per “[I-D.ietf-rtcweb-data-channel] also mandates
> support of
> >    the limited retransmission policy defined in [RFC7496].”, I was expecting
> to
> >    read something about how this extension is also not needed by CLUE like
> the
> >    previous part of the paragraph.  Right now the text only states something
> about
> >    rtcweb but not CLUE.
> 
> Good catch! I suggest to modify the text in the following way:
> 
>    "NOTE: [I-D.ietf-rtcweb-data-channel] requires the support of the
>    partial reliability extension defined in [RFC3758] and the limited
>    retransmission policy defined in [RFC7496]. The extensions are not
>    needed for a CLUE data channel, as messages are required to always be
>    sent reliably."
> 
> In addition, I suggest to add a reference to RFC 7496 to the text in the
> paragraph above, in the following way:
> 
>     "A CLUE entity MUST NOT use the partial reliability, defined in [RFC3758],
> or the limited
>     retransmission SCTP extensions, defined in [RFC3758], for the CLUE data
> channel."

Sounds good.  Thanks for making these changes.

Roman

> Thanks!
> 
> Regards,
> 
> Christer
>