Re: [codec] I-D Action: draft-ietf-codec-oggopus-00.txt

"Timothy B. Terriberry" <tterribe@xiph.org> Fri, 24 May 2013 17:19 UTC

Return-Path: <tterribe@xiph.org>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5ECA21F9635 for <codec@ietfa.amsl.com>; Fri, 24 May 2013 10:19:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.677
X-Spam-Level:
X-Spam-Status: No, score=-2.677 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HELO_MISMATCH_ORG=0.611, HOST_MISMATCH_COM=0.311, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lscbzf9tOZqy for <codec@ietfa.amsl.com>; Fri, 24 May 2013 10:19:20 -0700 (PDT)
Received: from smtp.mozilla.org (mx2.corp.phx1.mozilla.com [63.245.216.70]) by ietfa.amsl.com (Postfix) with ESMTP id E270221F96A4 for <codec@ietf.org>; Fri, 24 May 2013 10:19:16 -0700 (PDT)
Received: from [10.250.6.54] (unknown [63.245.220.240]) (Authenticated sender: tterriberry@mozilla.com) by mx2.mail.corp.phx1.mozilla.com (Postfix) with ESMTPSA id 93742F210D for <codec@ietf.org>; Fri, 24 May 2013 10:19:16 -0700 (PDT)
Message-ID: <519FA114.9050002@xiph.org>
Date: Fri, 24 May 2013 10:19:16 -0700
From: "Timothy B. Terriberry" <tterribe@xiph.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 SeaMonkey/2.16.2
MIME-Version: 1.0
To: codec@ietf.org
References: <20121119225213.13225.30835.idtracker@ietfa.amsl.com> <50AABA00.6030102@xiph.org> <515609F7.7090402@jmvalin.ca> <20130330072800.GU19099@audi.shelbyville.oz> <51578F6B.6010202@jmvalin.ca>
In-Reply-To: <51578F6B.6010202@jmvalin.ca>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [codec] I-D Action: draft-ietf-codec-oggopus-00.txt
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/codec>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 May 2013 17:19:44 -0000

Jean-Marc Valin wrote:
>>> +<t>On the last frame of the first stream, encoding an independent frame by
>>> +turning off all forms of inter-frame prediction (de-emphasis is allowed).</t>
>>
>> How do people turn that off?
>
> That's actually something that needs to be cleanly exposed in the
> libopus API. The functionality is already there and you can probably get
> it to work by specifying 100% packet loss, but it needs to be a
> dedicated setting.

Well, I still think you need to explicitly list the SILK and CELT 
features that should be disabled (since, as you say, you don't want to 
refer to the libopus API), not just one feature that you shouldn't disable.

>>> +<t>setting the granulepos of the past page to a point near the end of the last
>>> +frame.</t>
>>
>> How do they determine where that point should be?
>
> I mean that any point near the end would work. Any thoughts on how to
> make this clearer?

I think you need to say more than this. In some contexts you may not be 
able to choose how many samples are in the file (encoding a CD with no 
inter-track gaps, but where you wish to preserve sample-accurate track 
boundaries, for example). That means you may need to do some frame size 
juggling to ensure the end of the track lies at "a point near the end of 
the last frame". How near is enough? The last half? The last quarter? In 
what size frame? Someone without intimate DSP knowledge and knowledge of 
the Opus format is not going to be able to make informed decisions here, 
so we should provide some guidance.