Re: [codec] AD Evaluation of draft-ietf-codec-oggopus-09

"Timothy B. Terriberry" <tterribe@xiph.org> Mon, 21 December 2015 22:45 UTC

Return-Path: <tterribe@xiph.org>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 081761ACE22; Mon, 21 Dec 2015 14:45:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.313
X-Spam-Level:
X-Spam-Status: No, score=-5.313 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_MISMATCH_ORG=0.611, HOST_MISMATCH_COM=0.311, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xVAJqHGbbGZ0; Mon, 21 Dec 2015 14:45:01 -0800 (PST)
Received: from smtp.mozilla.org (mx2.scl3.mozilla.com [63.245.214.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D4A1D1ACE20; Mon, 21 Dec 2015 14:45:01 -0800 (PST)
Received: from localhost (localhost6.localdomain [127.0.0.1]) by mx2.mail.scl3.mozilla.com (Postfix) with ESMTP id 4F34EC0F46; Mon, 21 Dec 2015 22:45:01 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mozilla.org
Received: from smtp.mozilla.org ([127.0.0.1]) by localhost (mx2.mail.scl3.mozilla.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sElwirauaLoZ; Mon, 21 Dec 2015 22:45:01 +0000 (UTC)
Received: from [192.168.11.11] (pool-71-120-21-208.washdc.east.verizon.net [71.120.21.208]) (Authenticated sender: tterriberry@mozilla.com) by mx2.mail.scl3.mozilla.com (Postfix) with ESMTPSA id B5E12C096D; Mon, 21 Dec 2015 22:45:00 +0000 (UTC)
Message-ID: <567880EB.8000904@xiph.org>
Date: Mon, 21 Dec 2015 14:44:59 -0800
From: "Timothy B. Terriberry" <tterribe@xiph.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 SeaMonkey/2.26
MIME-Version: 1.0
To: Ben Campbell <ben@nostrum.com>
References: <86ACD2D0-02B6-473E-9E35-B9980166D9A0@nostrum.com> <566B4B47.9010809@xiph.org> <02FE33D2-476B-4CD5-927C-63BC3D4D4D25@nostrum.com> <56787285.7010803@xiph.org> <9BC52D4B-A133-4A54-8504-E88EEADB8D67@nostrum.com>
In-Reply-To: <9BC52D4B-A133-4A54-8504-E88EEADB8D67@nostrum.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/codec/fPpqjfTaKIhBaAj-nxupEpcDL7E>
Cc: codec@ietf.org, draft-ietf-codec-oggopus.all@ietf.org
Subject: Re: [codec] AD Evaluation of draft-ietf-codec-oggopus-09
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/codec/>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Dec 2015 22:45:03 -0000

Ben Campbell wrote:
> OLD:
> Otherwise, if the hardware’s highest available sample rate is less than
> 48 kHz, decode at the next highest supported rate above this and resample.
> NEW:
> Otherwise, if the hardware’s highest available sample rate is less than
> 48 kHz, decode at the next higher Opus supported rate above the hardware
> rate and resample to the hardware rate.
> END

Okay, I've incorporated these changes into my local edits (though I used 
"above the highest available hardware rate" instead of just "above the 
hardware rate" so that it's extra clear we're talking about the same one).