[core] Chairs' review of draft-ietf-core-stateless-03.txt

Carsten Bormann <cabo@tzi.org> Thu, 31 October 2019 17:08 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 97C0E120831 for <core@ietfa.amsl.com>; Thu, 31 Oct 2019 10:08:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.865
X-Spam-Level:
X-Spam-Status: No, score=-0.865 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FImvb9bw1WrI for <core@ietfa.amsl.com>; Thu, 31 Oct 2019 10:08:32 -0700 (PDT)
Received: from gabriel-vm-2.zfn.uni-bremen.de (gabriel-vm-2.zfn.uni-bremen.de [134.102.50.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B33BE12012E for <core@ietf.org>; Thu, 31 Oct 2019 10:08:32 -0700 (PDT)
Received: from client-0191.vpn.uni-bremen.de (client-0191.vpn.uni-bremen.de [134.102.107.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-vm-2.zfn.uni-bremen.de (Postfix) with ESMTPSA id 473sGl2fT6z101p; Thu, 31 Oct 2019 18:08:31 +0100 (CET)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <157237477119.11043.4363082013315464920@ietfa.amsl.com>
Date: Thu, 31 Oct 2019 18:08:30 +0100
X-Mao-Original-Outgoing-Id: 594234508.803881-28c6fc118871d838a5ccf2c4c7838dcc
Content-Transfer-Encoding: quoted-printable
Message-Id: <F964F5EF-96F7-49EC-BECB-0604B16F31FF@tzi.org>
References: <157237477119.11043.4363082013315464920@ietfa.amsl.com>
To: Core WG mailing list <core@ietf.org>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/-0wJVQst-mGOPLZCQzubHV_wiqE>
Subject: [core] Chairs' review of draft-ietf-core-stateless-03.txt
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2019 17:08:34 -0000

I did a review of draft-ietf-core-stateless-03.txt, with non-trivial results below.
(Editorial nits went directly to the author.)

I haven’t independently verified that all reviewers’ comments were addressed but will do this before we ship to the IESG what likely will be -04.

Grüße, Carsten


## Minor

           The option value MUST NOT be less than 8 or greater than 65804.  If
           an option value outside this range is received, the value MUST be
           clamped to this range.

I am still not a fan of re-interpreting disallowed values.
(Assuming there was later any reason to go beyond 65804, of course allowing
larger values and interpreting these as 65804 because a client knowing
just this specification cannot make use of lengths >65804 makes sense.
Not so sure about the values 0..7 though.)

           have been forwarded by an intermediary.  To ensure that this does not
           lead to inconsistent resource state, a stateless intermediary MUST
           include the Request-Tag Option [I-D.ietf-core-echo-request-tag] in
           block-wise transfers with a value that uniquely identifies the client
           in the intermediary's namespace.

-> To ensure that this does not lead to inconsistent resource state, a
stateless intermediary that wants to forward requests with Block1
options will need to also include a distinguishing option such as the Request-Tag Option
[I-D.ietf-core-echo-request-tag] in a way that uniquely...

           When using AES-CCM, repeated use of the same nonce under the same key

Not just AES-CCM, just about any AEAD.  Maybe say: When using an
encryption mode that depends on a nonce, such as AES-CCM, ...


## Nits

           A client SHOULD NOT assume that extended token lengths are supported
           by a server 60 minutes after receiving a response with an extended
           token length, as network addresses may change.

s/60/later than 60/