Re: [core] [Last-Call] Iotdir telechat review of draft-ietf-core-dev-urn-09
Russ Housley <housley@vigilsec.com> Thu, 07 January 2021 13:14 UTC
Return-Path: <housley@vigilsec.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2A61D3A109D for <core@ietfa.amsl.com>; Thu, 7 Jan 2021 05:14:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.895
X-Spam-Level:
X-Spam-Status: No, score=-1.895 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vRjuldY5KOLY for <core@ietfa.amsl.com>; Thu, 7 Jan 2021 05:14:24 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2428C3A109B for <core@ietf.org>; Thu, 7 Jan 2021 05:14:24 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id A9F3C300BD4 for <core@ietf.org>; Thu, 7 Jan 2021 08:06:37 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id F8eN2zSW9iZF for <core@ietf.org>; Thu, 7 Jan 2021 08:06:33 -0500 (EST)
Received: from a860b60074bd.fios-router.home (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) by mail.smeinc.net (Postfix) with ESMTPSA id 529A3300B03; Thu, 7 Jan 2021 08:06:33 -0500 (EST)
From: Russ Housley <housley@vigilsec.com>
Message-Id: <A1152BE4-410F-4E2B-884D-DD5E62129122@vigilsec.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_C7682BAD-05AB-4FDA-9999-F6AA15CEC64F"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
Date: Thu, 07 Jan 2021 08:06:34 -0500
In-Reply-To: <CALaySJKKEgPRzkG18QAyOutGHO93zP=Hm2bBaF0qvE5j7r_dYw@mail.gmail.com>
Cc: "iot-directorate@ietf.org" <iot-directorate@ietf.org>, draft-ietf-core-dev-urn.all@ietf.org, core@ietf.org, last-call@ietf.org
To: Barry Leiba <barryleiba@computer.org>
References: <160996930502.21827.5533521556349871834@ietfa.amsl.com> <CALaySJKKEgPRzkG18QAyOutGHO93zP=Hm2bBaF0qvE5j7r_dYw@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.104.17)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/E7YH3LwmdC5eM4Qbu9tYZ4E9G_Q>
Subject: Re: [core] [Last-Call] Iotdir telechat review of draft-ietf-core-dev-urn-09
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jan 2021 13:14:26 -0000
Barry: You are, of course, correct. RFC 5234 says: ABNF strings are case insensitive and the character set for these strings is US-ASCII. However, that raises a different issue: The DEV URN syntax allows both upper and lower case characters. The URN-equivalence of the DEV URNs is defined per [RFC8141] Section 3.1, i.e,. two URNs are URN-equivalent if their assigned-name portions are octet-by-octet equal after applying case normalization to the URI scheme ("urn") and namespace identifier ("dev"). So, the ABNF should be changed so that the "mac:", "ow:", "org:", "os:", and "ops:" are required to be lowercase. I guess that means replacing each letter with the appropriate value in the %x61-7A range. That will not be as easy to read... Russ > On Jan 6, 2021, at 4:49 PM, Barry Leiba <barryleiba@computer.org> wrote: > > Thanks for the quick review, Russ, and good catches here. > > On one item, though: > > > If both cases are to be supported, the upper case letters need to be > > added to the ABNF to permit them. > > > Actually not: quoted letters in ABNF are case-insensitive, so “a” matches both lowercase a and uppercase A. > > Barry > > On Wed, Jan 6, 2021 at 4:41 PM Russ Housley via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote: > Reviewer: Russ Housley > Review result: Almost Ready > > I reviewed this document as part of the IoT Directorate's effort to > IoT-related IETF documents being processed by the IESG. These comments > were written primarily for the benefit of the Internet Area Directors. > Document authors, document editors, and WG chairs should treat these > comments just like any other IETF Last Call comments. > > Document: draft-ietf-core-dev-urn-09 > Reviewer: Russ Housley > Review Date: 2021-01-06 > IETF LC End Date: 2020-12-02 > IESG Telechat date: 2021-01-21 > > > A review from the IoT Directorate was requested on 2021-01-05, which is > after the IETF Last Call ended. I assume that the Internet ADs want > this review to help inform them during IESG Evaluation. > > > Summary: Almost Ready > > > Major Concerns: > > Section 3.2 says: > > The optional underscore-separated components following the hexstring > are strings depicting individual aspects of a device. > > Not all of the DEV URN forms contain a hexstring; however, all of them > are allowed to end with underscore-separated components. I suggest: > > The optional underscore-separated components at the end of the > DEV URN depict individual aspects of a device. > > Section 3.2.1 says: > > ... and a MAC address could be represented either with > uppercase or lowercase hexadecimal digits. > > This is not allowed by the ABNF: > > hexstring = 1*(hexdigit hexdigit) > hexdigit = DIGIT / "a" / "b" / "c" / "d" / "e" / "f" > > If both cases are to be supported, the upper case letters need to be > added to the ABNF to permit them. > > Section 4.2 says: > > ... > 64-bit identifier that consists of 8 byte family code, 48 bit > identifier unique within a family, and 8 bit CRC code [OW]. > > The math does not work. I suspect: s/8 byte/8 bit/ > > Section 6 says: > > ... An implementation of the DEV URN MUST NOT > change these properties from what they were intended. > > It is not clear to me the meaning of "they" in this sentence. > Please clarify. > > > Minor Concerns: > > Section 3.2 says: > > DEV URNs do not use r-, q-, or f-components. > > I would have liked a bit more context here. I suggest: > > DEV URNs do not use r-, q-, or f-components as defined in [RFC8141]. > > Section 3.2.1 refers to "BASE64". Please add an informative reference > to RFC 4648 to be clear. > > Section 4.1 uses the term "Ethernet" in two places. I think both of > them should be replaced by "MAC-48". > > > Nits: > > Section 3.2 says: > > However, due to the SenML RFC 8428 Section 4.5.1 rules, DEV URNs > do not support percent-encoding. > > This does not seem like a "however" statement to me. Perhaps, it is > a "Note that" statement. Or, just drop "However". > > Section 4.1: s/rests within the IEEE/ > /rests with the IEEE Registration Authority/ > > Section 7 includes: "publicly available specification that can > be pointed to." It is sufficient to say: ""publicly available > specification." > > > > -- > last-call mailing list > last-call@ietf.org > https://www.ietf.org/mailman/listinfo/last-call
- [core] Iotdir telechat review of draft-ietf-core-… Russ Housley via Datatracker
- Re: [core] Iotdir telechat review of draft-ietf-c… Barry Leiba
- Re: [core] [Last-Call] Iotdir telechat review of … John C Klensin
- Re: [core] [Last-Call] Iotdir telechat review of … Martin J. Dürst
- Re: [core] [Last-Call] Iotdir telechat review of … Russ Housley
- Re: [core] [Last-Call] Iotdir telechat review of … Barry Leiba
- Re: [core] [Last-Call] Iotdir telechat review of … Russ Housley
- Re: [core] Iotdir telechat review of draft-ietf-c… Jari Arkko
- Re: [core] [Last-Call] Iotdir telechat review of … Russ Housley
- Re: [core] [Last-Call] Iotdir telechat review of … Jari Arkko
- Re: [core] [Last-Call] Iotdir telechat review of … Jari Arkko
- Re: [core] [Last-Call] Iotdir telechat review of … Russ Housley
- Re: [core] [Last-Call] Iotdir telechat review of … John C Klensin
- Re: [core] [Last-Call] Iotdir telechat review of … Jari Arkko
- Re: [core] [Last-Call] Iotdir telechat review of … Carsten Bormann
- Re: [core] [Last-Call] Iotdir telechat review of … Jari Arkko
- Re: [core] [Last-Call] Iotdir telechat review of … Russ Housley