Re: [core] AD review of draft-ietf-core-resource-directory-23

"Alexey Melnikov" <alexey.melnikov@isode.com> Wed, 20 November 2019 02:03 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1A91512012C for <core@ietfa.amsl.com>; Tue, 19 Nov 2019 18:03:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.935
X-Spam-Level:
X-Spam-Status: No, score=-1.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_SOFTFAIL=0.665] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=messagingengine.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YuGwGfbqXaxv for <core@ietfa.amsl.com>; Tue, 19 Nov 2019 18:03:32 -0800 (PST)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1265A1200E5 for <core@ietf.org>; Tue, 19 Nov 2019 18:03:32 -0800 (PST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id CD247481; Tue, 19 Nov 2019 21:03:30 -0500 (EST)
Received: from imap1 ([10.202.2.51]) by compute3.internal (MEProxy); Tue, 19 Nov 2019 21:03:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BUc2jmG9mfbtFO0pG1Kf8v2h/0eA4MOK42CrTL4Ty 0o=; b=GqFzGywEXJKN4cwmA6rZodCvUrxd3MhLvTY0mvsC+eeCOVUxoZiZYhi4K tK1MrHGIQb5gntTmO264rgIqZbt+J+K3AnDJWnP+v9v3T402htFE96/6pbUjpADP HubNzuSVs0f/6ttiBgjpKYYK+c6cPC7bHf7RgyUULxLcn7ljg4pSp3V+nxM4lFn8 IBAG7rUW9JVzO1zKr3BMeWOGcruIWNM/M6SZeNn7QnGmw1J7Yso4u/m9RuqmV/h0 YyMLW21o+c3aJNhIfVaJ+M/hKMFKhBUSjtXh/e/u0h6Jai+yW2Yrgh0MazdvNjLI CiXrnZ8tQohPENyfZaCITIh1fXMZQ==
X-ME-Sender: <xms:8Z7UXc32xWtvVn8NbIOIGXGebaXoSICYNl-4AMU07UdzAP0SvVDUbA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudegledggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedftehl vgigvgihucfovghlnhhikhhovhdfuceorghlvgigvgihrdhmvghlnhhikhhovhesihhsoh guvgdrtghomheqnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhgvgigvhidrmhgvlhhn ihhkohhvsehishhouggvrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:8Z7UXbU4J6sA2ZGk_KfKjN9p-h3jA0O5ZK5gvd-MvV7hcMwWKC7n2w> <xmx:8Z7UXf6vLBso7k3Sc30R0tyom4k0Li5Lpyq2U56RIUrmZiYItdpCtA> <xmx:8Z7UXaIsTEnhghPmVmhA1Xz35ycgUkyCCOZFJdFwkoM8ptWlC6o0cw> <xmx:8p7UXSNaKXpqGQxlywviFpyTVfqo-DuNAj4wiyJ91mVDJUQ53yIHDQ>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9E3AAC200A4; Tue, 19 Nov 2019 21:03:29 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-578-g826f590-fmstable-20191119v1
Mime-Version: 1.0
Message-Id: <c29e70d4-7d81-4c89-ad81-62a6132fb3df@www.fastmail.com>
In-Reply-To: <20191119125733.GA8007@hephaistos.amsuess.com>
References: <481f9820-bcea-af6a-d5c4-d713be24d43d@isode.com> <20191119125733.GA8007@hephaistos.amsuess.com>
Date: Wed, 20 Nov 2019 02:03:09 +0000
From: Alexey Melnikov <alexey.melnikov@isode.com>
To: Christian Amsüss <christian@amsuess.com>
Cc: "core@ietf.org" <core@ietf.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/JnAdEVpsMh0_biNHbIRpNBw-aXY>
Subject: Re: [core] AD review of draft-ietf-core-resource-directory-23
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Nov 2019 02:03:33 -0000

Hi Christian,

On Tue, Nov 19, 2019, at 12:57 PM, Christian Amsüss wrote:
> Hello Alexey,
> hello CoRE,
> 
> thank you for your review. I'll only answer to points here that actually
> need responses or further comments from the group. Everything else is
> directly taken up as to be trivially fixed.
> 
> On Mon, Nov 04, 2019 at 05:06:45PM +0000, Alexey Melnikov wrote:
> > In 4.3:
> >   The well-known entry points SHOULD be provided to enable unicast
> > discovery.
> >
> > I don't see a new .well-known value being registered in the IANA
> > Considerations section. Have I misintepreted what this mean?
> 
> This is referring to the existing .well-known/core discovery URI that is
> heavily used in RD.

I think you should update the above sentence to make this clear.

> (The grouping of this requirement in the context of the section can be
> improved still).
>
> > In 4.3, 6th para:
> >
> >    Clients of the RD
> >    SHOULD therefore accept URIs of all schemes they support, both as
> >    URIs and relative references,
> >
> > Did you mean to say "absolute URIs"? Relative URIs are still URIs
> 
> (and later points on "absolute URI" / "relative URI")
> 
> Klaus answered that point very well.
> 
> We've had the "absolute URI" term in there for quite some time until
> exactly what he said was pointed out; the wording should now be
> consistent of "relative references" and "URIs", which are occasionally
> annotate as "full URIs" to emphasise that relative references are not
> meant. The term "path-absolute form" is taken from relative references'
> ABNF, and I did not find any more commmon-language experssion for
> "relative reference and not a URI", especially as more exotic forms like
> "//host/path" are undesirable in those places as well.

Ok, I will review my own comments and cross check the URI RFC. If I have any questions, I will about them separately.

> > In 5.3, 1st para:
> >
> >    This section describes how the registering endpoint can maintain the
> >    registrations that it created.  The registering endpoint can be the
> >    registrant-ep or the CT.  An endpoint SHOULD NOT use this interface
> >
> > Why SHOULD NOT (instead of MUST NOT) and how is this enforced?
> 
> This is more expressing the intention than anything enforcable. Frankly,
> it is a bit imprecise: The goal is to discourage any agents enumerating
> registrations from the endpoint lookup and trying to enhance them.
> Endpoints switching addresses (thus technically becoming different
> endpoints) and updating their registration is encouraged.

More text along the lines of your answer would improve the document.

> There are some cases in the middle we probably don't want to rule out
> but caution against, invoking "SHOULD"'s "know what you're doing" which
> we may not want to rule out (but have not discussed).
> 
> In the end, enforcement is up to the security policy -- if an agent
> knows a registration URI and has the authorization to act on it, that
> will succeed.
> 
> 
> > In 6.2:
> >
> >       search :=  Search criteria for limiting the number of results
> >          (optional).
> >
> > I think this is undespecified.
> >
> > Can you give me an example?
> 
> The description for this is above that interface description in the "A
> link matches a search criterion if" paragraph.
> 
> Is your point about this being underspecified about the description as a
> whole, or just about the discoverability of the text (which should be
> easy to fix with something just a bit more elaborate than "(see above)"
> note)?
> 
> Note that in the URI-Template, it says "search*", with the explode
> modifier ("*") indicating that any otherwise unmatched query parameters
> go into an associative array named "search".
> 
> The first two examples right after that section are "search" examples.
> In the "/rd-lookup/res?rt=temperature" example, search is matched as a
> [("rt", "temperature")] associative array.

When I read the above I started to wonder where search criteria syntax is defined. I am still not entirely clear, so I think this needs to be clarified.

> > In 9.3:
> >
> >    o  validity requirements if any, and
> >
> > Does this include syntax?
> 
> If structured fields are registered, yes -- but I expect most entries to
> be simple like "integer" (implying "ASCII encoded decimal integer").

I suggest changing the above to "syntax and validity requirements if any, and"

> 
> > At the end of section 9.3:
> >    It is expected that the registry will receive between 5 and 50
> > registrations in total over the next years.
> >
> > This will not age well! Maybe remove this text from the document and add it
> > to the spherding write-up?
> 
> Doesn't this need to be in the requesting document, per BCP26's "It is
> also a good idea to include, when possible, a sense of whether many
> registrations are expected over time, or if the registry is expected to
> be updated infrequently or in exceptional circumstances only."?
> 
> But if not, I'll remove the paragraph and alert Jaime as the shepherd.

I suggest this be moved to the shepherding wrtite up.

> > I think the following reference is Normative the way it is used in the
> > document:
> >
> >    [I-D.ietf-core-rd-dns-sd] Stok, P., Koster, M., and C. Amsuess, "CoRE
> > Resource Directory: DNS-SD mapping", draft-ietf-core-rd-dns-sd-05 (work in
> > progress), July 2019.
> 
> <personal>Oh please not</personal>.
> 
> I suppose this is due to "The use of DNS facilities is described in
> [rd-dns-sd]" being listed as a recommended way, or are there more
> aspects to it?
> 
> The DNS-SD component has been holding RD back quite a bit, so if it's that
> recommendation, I assume the group might want to reconsider recommending
> that mechanism for discovering the RD.

The WG started to discuss whether this is truly normative. I am awaiting conclusion of this discussion.

Best Regards,
Alexey