[core] Genart last call review of draft-ietf-core-object-security-08

Joel Halpern <jmh@joelhalpern.com> Thu, 22 February 2018 03:51 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: core@ietf.org
Delivered-To: core@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B7685126D73; Wed, 21 Feb 2018 19:51:43 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joel Halpern <jmh@joelhalpern.com>
To: gen-art@ietf.org
Cc: draft-ietf-core-object-security.all@ietf.org, ietf@ietf.org, core@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.72.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151927150372.21177.1992679615718735268@ietfa.amsl.com>
Date: Wed, 21 Feb 2018 19:51:43 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/X7WM4SUXjeujZxuSEmNrDP9J2OI>
Subject: [core] Genart last call review of draft-ietf-core-object-security-08
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2018 03:51:44 -0000

Reviewer: Joel Halpern
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-core-object-security-08
Reviewer: Joel Halpern
Review Date: 2018-02-21
IETF LC End Date: 2018-03-02
IESG Telechat date: 2018-03-08

Summary: This document is ready for publication as a Proposed Standard RFC

Major issues: N/A

Minor issues:
    In section 8.2 on verifying the request, step 5 says to "compose" the
    Additional Authentication Data.  I would have expected it to be "verify"
    the Additional Authentication Data.  I could imagine that the verification
    consists of composing what it should be, and then comparing with what is
    received.  But I do not see the comparison step.  is it implicit in some
    other step?  This occurs again in 8.4, so I presume I am simply missing
    something.  This may suggest some clarification could be useful.

Nits/editorial comments: N/A