Re: [core] AD review of draft-ietf-core-senml-versions-02

Carsten Bormann <cabo@tzi.org> Mon, 19 April 2021 11:53 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0A8E13A2E96; Mon, 19 Apr 2021 04:53:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.019
X-Spam-Level:
X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5 tests=[RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n1Mwf2RRx8ww; Mon, 19 Apr 2021 04:53:10 -0700 (PDT)
Received: from gabriel-vm-2.zfn.uni-bremen.de (gabriel-vm-2.zfn.uni-bremen.de [134.102.50.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C2A483A2E95; Mon, 19 Apr 2021 04:53:08 -0700 (PDT)
Received: from [192.168.217.118] (p548dcb12.dip0.t-ipconnect.de [84.141.203.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-vm-2.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4FP4vP5ZxYz104S; Mon, 19 Apr 2021 13:53:05 +0200 (CEST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <17E71A76-4839-4A45-9416-38E0B53A9556@ericsson.com>
Date: Mon, 19 Apr 2021 13:53:05 +0200
Cc: "core@ietf.org" <core@ietf.org>, "draft-ietf-core-senml-versions.all@ietf.org" <draft-ietf-core-senml-versions.all@ietf.org>
X-Mao-Original-Outgoing-Id: 640525985.263515-852320697ade4aa1c42b17e9a4c73cfc
Content-Transfer-Encoding: quoted-printable
Message-Id: <92272FFE-2AC7-4932-B2A2-96801E74E9EA@tzi.org>
References: <17E71A76-4839-4A45-9416-38E0B53A9556@ericsson.com>
To: Francesca Palombini <francesca.palombini@ericsson.com>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/Y225F1rbaI885iU5NraZTqJwSts>
Subject: Re: [core] AD review of draft-ietf-core-senml-versions-02
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2021 11:53:15 -0000

On 2021-04-18, at 21:01, Francesca Palombini <francesca.palombini@ericsson.com> wrote:
> 
> Thanks for the work on this document. Two very minor comments below, to take or leave as you see fit. Please handle these comments together with the Last Call comments.
> 
> Francesca
> 
> 1. -----
>                __ 52                      fc
>   version  =  \          present(fc) ⋅ 2
>               /__ fc = 0
> 
> FP: Creative way to express a sumation in text.

Thanks to asciitex, as suggested (and now maintained) by Lars Eggert…

Looks much better in SVG, https://www.ietf.org/archive/id/draft-ietf-core-senml-versions-02.html#section-2-3.1

But the text in the paragraph above already talks about the sum and taking 2 to the power, so the display math is just an illustration.

> Maybe a sentence about the fact that sigma is represented this way in the text might be good. Also, the terminology section states that exponentiation is expressed with superscript notation X^(Y), but that is not used here.

We don’t have a good way to handle the discrepancies between TXT and HTML.
I added a note about the superscript notation to 1.1, but not about the sigma, which is just ascii-art...

> 2. -----
> 
> Since the Secondary Units is defined in RFC 8798, it would make sense in my opinion to add that RFC to the Specification column. In practice, it would make sense to me to add to the specification column not only the document where the feature code number is defined, but also the specification where the feature indicated is defined.

Added.

Also added:

> Where the specification of the feature code is provided in a document
> that is separate from the specification of the feature itself (as with
> feature code 4 above), both specifications should be listed.

Changes are now in https://github.com/core-wg/senml-versions/commit/105c346

Thank you!

Grüße, Carsten