Re: [COSE] Review draft-ietf-cose-webauthn-algorithms-02.txt
Jim Schaad <ietf@augustcellars.com> Sat, 02 November 2019 03:14 UTC
Return-Path: <ietf@augustcellars.com>
X-Original-To: cose@ietfa.amsl.com
Delivered-To: cose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 002F4120A1A for <cose@ietfa.amsl.com>; Fri, 1 Nov 2019 20:14:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.788
X-Spam-Level:
X-Spam-Status: No, score=-1.788 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TqNmZGMCwRfp for <cose@ietfa.amsl.com>; Fri, 1 Nov 2019 20:14:56 -0700 (PDT)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 89E1C120809 for <cose@ietf.org>; Fri, 1 Nov 2019 20:14:27 -0700 (PDT)
Received: from Jude (73.180.8.170) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Nov 2019 20:14:19 -0700
From: Jim Schaad <ietf@augustcellars.com>
To: 'Mike Jones' <Michael.Jones@microsoft.com>, cose@ietf.org
References: <041a01d58e90$9449ff90$bcddfeb0$@augustcellars.com> <MN2PR00MB0574F4672E2BD1F23E074F89F5610@MN2PR00MB0574.namprd00.prod.outlook.com>
In-Reply-To: <MN2PR00MB0574F4672E2BD1F23E074F89F5610@MN2PR00MB0574.namprd00.prod.outlook.com>
Date: Fri, 01 Nov 2019 20:14:16 -0700
Message-ID: <005501d5912b$9e0497a0$da0dc6e0$@augustcellars.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_0056_01D590F0.F1AAEFC0"
X-Mailer: Microsoft Outlook 16.0
Content-Language: en-us
Thread-Index: AQLO0b0mizVkkD0RYgFqUDfnG8tj+gNTZI3upWoWj3A=
X-Originating-IP: [73.180.8.170]
Archived-At: <https://mailarchive.ietf.org/arch/msg/cose/Dewnnq_3L_ebFOqnQn14JeInK5E>
Subject: Re: [COSE] Review draft-ietf-cose-webauthn-algorithms-02.txt
X-BeenThere: cose@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: CBOR Object Signing and Encryption <cose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cose>, <mailto:cose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cose/>
List-Post: <mailto:cose@ietf.org>
List-Help: <mailto:cose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cose>, <mailto:cose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Nov 2019 03:14:59 -0000
From: Mike Jones <Michael.Jones@microsoft.com> Sent: Tuesday, October 29, 2019 4:20 PM To: Jim Schaad <ietf@augustcellars.com>; cose@ietf.org Subject: RE: [COSE] Review draft-ietf-cose-webauthn-algorithms-02.txt Replies are inline, prefixed by Mike>. -----Original Message----- From: COSE <cose-bounces@ietf.org <mailto:cose-bounces@ietf.org> > On Behalf Of Jim Schaad Sent: Tuesday, October 29, 2019 12:39 PM To: cose@ietf.org <mailto:cose@ietf.org> Subject: [COSE] Review draft-ietf-cose-webauthn-algorithms-02.txt 5. I have problems with the following text: "Implementation of this algorithm is RECOMMENDED because of its widespread use in decentralized systems and those that chose it over the NIST curves." Firstly, this is an incorrect use of the RFC 2119 language, this is not a protocol statement. Mike> Ive lowercased recommended. Secondly, this is not what the recommended column in table 2 means and thus is trying to overload that column with something that is not real. Third, the fact that people chose this over the NIST curves is not necessarily a reason for the IETF to recommended its implementation. Mike> Recall that the JOSE algorithms come with Implementation Requirements (see https://tools.ietf.org/html/rfc7518#section-7.1.1), whose values are one of Required, Recommended, Optional, Deprecated, or Prohibited. Its in that sense that the word Recommended is being used more than Optional but less than Required. The COSE registry value that seems to most closely correspond with this is Recommended: True. (As I see it, its unfortunate that COSE compressed these five values down to two, but I realize that thats water under the bridge, unless we want to reconsider this choice in the BIS COSE registry instructions.) [JLS] What COSE does is aligned with what the TLS working group does with this. We do not specify implementation requirements which is what JOSE did. 6. I still want to see in the text the reasoning behind not just using the current ECDSA algorithm in COSE. Mike> I provided the reasoning in my response to your previous review. Having a curve-specific algorithm identifier lets implementations do what you asked about ensuring that the curve associated with a key cannot be changed and the modified key still be used. [JLS] I want to see this in the text itself. Given that this is not the same way that one would expect it to be done in COSE from history that needs to be placed in the document. I would completely disagree with your second statement. 7. Add text on checking point is on the curve to section 5.4 Mike> I assume youre talking about adding text like that in https://tools.ietf.org/html/draft-ietf-oauth-jwt-bcp-07#section-3.4. Ill admit that Im not enough of an expert on secp256k1 usage to know whether an on-curve check is what is called for or a different validation procedure. A definitive reference would be highly appreciated. In particular, I dont know whether the Galois y² = x³ + 7 finite field form used with secp256k1 is amenable to a check that the (x, y) pair are on the curve or whether a different check is needed. [JLS] section 3.2.2 of SEC 1. Thanks again for your detailed reviews, Jim. Ill plan to publish a new draft incorporating these issue resolutions before Mondays submission cutoff. -- Mike -----Original Message----- From: COSE < <mailto:cose-bounces@ietf.org> cose-bounces@ietf.org> On Behalf Of <mailto:internet-drafts@ietf.org> internet-drafts@ietf.org Sent: Thursday, October 24, 2019 2:35 PM To: <mailto:i-d-announce@ietf.org> i-d-announce@ietf.org Cc: <mailto:cose@ietf.org> cose@ietf.org Subject: [COSE] I-D Action: draft-ietf-cose-webauthn-algorithms-02.txt A New Internet-Draft is available from the on-line Internet-Drafts directories. This draft is a work item of the CBOR Object Signing and Encryption WG of the IETF. Title : COSE and JOSE Registrations for WebAuthn Algorithms Author : Michael B. Jones Filename : draft-ietf-cose-webauthn-algorithms-02.txt Pages : 13 Date : 2019-10-24 Abstract: The W3C Web Authentication (WebAuthn) specification and the FIDO Alliance FIDO2 Client to Authenticator Protocol (CTAP) specification use CBOR Object Signing and Encryption (COSE) algorithm identifiers. This specification registers the following algorithms in the IANA "COSE Algorithms" registry, which are used by WebAuthn and CTAP implementations: RSASSA-PKCS1-v1_5 using SHA-256, SHA-384, SHA-512, and SHA-1, and ECDSA using the secp256k1 curve and SHA-256. It registers the secp256k1 elliptic curve in the IANA "COSE Elliptic Curves" registry. Also, for use with JSON Object Signing and Encryption (JOSE), it registers the algorithm ECDSA using the secp256k1 curve and SHA-256 in the IANA "JSON Web Signature and Encryption Algorithms" registry and the secp256k1 elliptic curve in the IANA "JSON Web Key Elliptic Curve" registry. The IETF datatracker status page for this draft is: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatrack er.ietf.org%2Fdoc%2Fdraft-ietf-cose-webauthn-algorithms%2F&data=02%7C01% 7CMichael.Jones%40microsoft.com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f988b f86f141af91ab2d7cd011db47%7C1%7C0%7C637079747916555344&sdata=P5WknFu56wO ZwH1i%2BRJMvqjHYjF9VD32CSrkWBg5bA8%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracke r.ietf.org%2Fdoc%2Fdraft-ietf-cose-webauthn-algorithms%2F&data=02%7C01%7 CMichael.Jones%40microsoft.com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f988bf 86f141af91ab2d7cd011db47%7C1%7C0%7C637079747916555344&sdata=P5WknFu56wOZ wH1i%2BRJMvqjHYjF9VD32CSrkWBg5bA8%3D&reserved=0 There are also htmlized versions available at: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.iet f.org%2Fhtml%2Fdraft-ietf-cose-webauthn-algorithms-02&data=02%7C01%7CMic hael.Jones%40microsoft.com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f988bf86f1 41af91ab2d7cd011db47%7C1%7C0%7C637079747916555344&sdata=ZutAl6JaemEvVdC5 KZFeTthXl75YYP1ebBgrNWcSi1A%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.ietf .org%2Fhtml%2Fdraft-ietf-cose-webauthn-algorithms-02&data=02%7C01%7CMich ael.Jones%40microsoft.com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f988bf86f14 1af91ab2d7cd011db47%7C1%7C0%7C637079747916555344&sdata=ZutAl6JaemEvVdC5K ZFeTthXl75YYP1ebBgrNWcSi1A%3D&reserved=0 <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatrack er.ietf.org%2Fdoc%2Fhtml%2Fdraft-ietf-cose-webauthn-algorithms-02&data=0 2%7C01%7CMichael.Jones%40microsoft.com%7Ce279955f279c4ac5a9a908d75ca7c308%7C 72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637079747916555344&sdata=R%2F Kt7qEM0q3v4%2FFvm0WSLoHPkQP8vHK5I4qXyFQXBIk%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracke r.ietf.org%2Fdoc%2Fhtml%2Fdraft-ietf-cose-webauthn-algorithms-02&data=02 %7C01%7CMichael.Jones%40microsoft.com%7Ce279955f279c4ac5a9a908d75ca7c308%7C7 2f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637079747916555344&sdata=R%2FK t7qEM0q3v4%2FFvm0WSLoHPkQP8vHK5I4qXyFQXBIk%3D&reserved=0 A diff from the previous version is available at: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf. org%2Frfcdiff%3Furl2%3Ddraft-ietf-cose-webauthn-algorithms-02&data=02%7C 01%7CMichael.Jones%40microsoft.com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f9 88bf86f141af91ab2d7cd011db47%7C1%7C0%7C637079747916555344&sdata=Zt9aIA57 AKdF2PlPPtlm2E%2F6OjAvizDxU%2BoRrkpTwKI%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.o rg%2Frfcdiff%3Furl2%3Ddraft-ietf-cose-webauthn-algorithms-02&data=02%7C0 1%7CMichael.Jones%40microsoft.com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f98 8bf86f141af91ab2d7cd011db47%7C1%7C0%7C637079747916555344&sdata=Zt9aIA57A KdF2PlPPtlm2E%2F6OjAvizDxU%2BoRrkpTwKI%3D&reserved=0 Please note that it may take a couple of minutes from the time of submission until the htmlized version and diff are available at tools.ietf.org. Internet-Drafts are also available by anonymous FTP at: <ftp://ftp.ietf.org/internet-drafts/> ftp://ftp.ietf.org/internet-drafts/ _______________________________________________ COSE mailing list <mailto:COSE@ietf.org> COSE@ietf.org <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf. org%2Fmailman%2Flistinfo%2Fcose&data=02%7C01%7CMichael.Jones%40microsoft .com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f988bf86f141af91ab2d7cd011db47%7 C1%7C0%7C637079747916555344&sdata=k6n9t50ylb2R8YbKl6x479T253Zw0iLSMbIex5 nYmV0%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.o rg%2Fmailman%2Flistinfo%2Fcose&data=02%7C01%7CMichael.Jones%40microsoft. com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f988bf86f141af91ab2d7cd011db47%7C 1%7C0%7C637079747916555344&sdata=k6n9t50ylb2R8YbKl6x479T253Zw0iLSMbIex5n YmV0%3D&reserved=0 _______________________________________________ COSE mailing list <mailto:COSE@ietf.org> COSE@ietf.org <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf. org%2Fmailman%2Flistinfo%2Fcose&data=02%7C01%7CMichael.Jones%40microsoft .com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f988bf86f141af91ab2d7cd011db47%7 C1%7C0%7C637079747916555344&sdata=k6n9t50ylb2R8YbKl6x479T253Zw0iLSMbIex5 nYmV0%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.o rg%2Fmailman%2Flistinfo%2Fcose&data=02%7C01%7CMichael.Jones%40microsoft. com%7Ce279955f279c4ac5a9a908d75ca7c308%7C72f988bf86f141af91ab2d7cd011db47%7C 1%7C0%7C637079747916555344&sdata=k6n9t50ylb2R8YbKl6x479T253Zw0iLSMbIex5n YmV0%3D&reserved=0