Re: [Curdle] Genart last call review of draft-ietf-curdle-cms-ecdh-new-curves-07

Russ Housley <housley@vigilsec.com> Sun, 04 June 2017 16:09 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D2BA120727 for <curdle@ietfa.amsl.com>; Sun, 4 Jun 2017 09:09:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level:
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zmvj3ovdeUBI for <curdle@ietfa.amsl.com>; Sun, 4 Jun 2017 09:09:21 -0700 (PDT)
Received: from mail.smeinc.net (x-bolt-wan.smeinc.net [209.135.219.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2FD531277BB for <curdle@ietf.org>; Sun, 4 Jun 2017 09:09:21 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 6EB0130056C for <curdle@ietf.org>; Sun, 4 Jun 2017 12:09:20 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6KFGuwd_ih3H for <curdle@ietf.org>; Sun, 4 Jun 2017 12:09:18 -0400 (EDT)
Received: from a860b60074bd.home (pool-108-45-101-150.washdc.fios.verizon.net [108.45.101.150]) by mail.smeinc.net (Postfix) with ESMTPSA id 4C955300265; Sun, 4 Jun 2017 12:09:18 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <149570983670.8681.5001417855088402577@ietfa.amsl.com>
Date: Sun, 04 Jun 2017 12:09:18 -0400
Cc: IETF Gen-ART <gen-art@ietf.org>, curdle <curdle@ietf.org>, IETF <ietf@ietf.org>
Content-Transfer-Encoding: 7bit
Message-Id: <B182B0C5-DDB8-4CC7-9E64-2A8A5DD43C15@vigilsec.com>
References: <149570983670.8681.5001417855088402577@ietfa.amsl.com>
To: Roni Even <ron.even.tlv@gmail.com>
X-Mailer: Apple Mail (2.3273)
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/8oprMWsFXcnYMHml5dHy_qKbd0o>
Subject: Re: [Curdle] Genart last call review of draft-ietf-curdle-cms-ecdh-new-curves-07
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Jun 2017 16:09:23 -0000

Roni:

Thanks for the review.  I believe that -09 resolves your comments.

Russ


> On May 25, 2017, at 6:57 AM, Roni Even <ron.even.tlv@gmail.com> wrote:
> 
> Reviewer: Roni Even
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-curdle-cms-ecdh-new-curves-??
> Reviewer: Roni Even
> Review Date: 2017-05-25
> IETF LC End Date: 2017-05-28
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> The document is ready for publication as a standard track RFC
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments: 
> 
> In general it was easy to read and follow.  Maybe it will be good to
> repeat in section 3.2 the definition of KeyAgreeRecipientInfo . This
> is done is section 2 for ECC-CMS-SharedInfo but it is not crucial.
> 
> 1. There is no ToC
> 2. In section 2.2 fourth paragraph "is used two places" - "in two .."
> 
> 
> 
> 
> 
> _______________________________________________
> Curdle mailing list
> Curdle@ietf.org
> https://www.ietf.org/mailman/listinfo/curdle