IETF Logo Mail Archive

Re: [Curdle] Genart last call review of draft-ietf-curdle-cms-ecdh-new-curves-07

Daniel Migault <daniel.migault@ericsson.com> Sat, 27 May 2017 01:33 UTC

Return-Path: <mglt.ietf@gmail.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D48C9129B74; Fri, 26 May 2017 18:33:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.399
X-Spam-Level:
X-Spam-Status: No, score=-2.399 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.199, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W19sB5B902U8; Fri, 26 May 2017 18:33:46 -0700 (PDT)
Received: from mail-lf0-x233.google.com (mail-lf0-x233.google.com [IPv6:2a00:1450:4010:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE94312940F; Fri, 26 May 2017 18:33:42 -0700 (PDT)
Received: by mail-lf0-x233.google.com with SMTP id a5so13490855lfh.2; Fri, 26 May 2017 18:33:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=i1nmYy1+l1o03GPXGopcgyBKuHr8MADo1MiSwXgLlFw=; b=hfjAu/iFj2wr2IK6m1b1qZmZn1mesZnCYU+Zk5SyH8MuYUT0+ac1LAldzXlw+u6rn6 qo3P+NprxlfbjyAdyDxcK9ij4lNVej36nfWVTfycZA5wUeAz8q/6wjsHA5eTc/R0hDme 0w+jE3YkBV0ShFHfQ7JJ5Nf7i+d3RQrmvt9f1lzCpuEN4hjQYYOylwP2N4HMBOt3Jc95 CEg2OUO2Df+o6EdueEPe4s9TmHHT6waoGyZCRSwh9I5r1EpDc8WUPlfmX7berZFCOC87 3DPjlOW4i2AUwb+12hDOoh0OrYjuDc+t94nKxyGEE/On9vBtjX4J/2l0iC/0OGz/YZXB nDCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=i1nmYy1+l1o03GPXGopcgyBKuHr8MADo1MiSwXgLlFw=; b=SKx1XCuS1qbINKDNGhoVjvGEmhhWgvufRRzV1nrMXVsiwZc4YK/zFHL2V8if0Avd17 6rrfyNcwz9zP1oz53VDeNChjWJTZF71kVa2aPQ2kJddfX+mdTzvCuUbyu/T6wVTsF9LO xxiedopmDyf3E4g6UuajCXIKlfSq5tlmq99aj/gdUk3XA4Rj0N8ErzGl0LvH6P8DxwBc ugCb08LUmqKYM0qdh63BgYY0GpbQtFlNjrJ2Kni5S9zdnKCDLulX0vPemBx/lBLJqQnl FYv3BQnj326rm0IymW7rhUb3usja4nnMsEtDdxSd7SLKU/cO4MDEGdAqU7cJkIYLwCky nEHA==
X-Gm-Message-State: AODbwcCXspQo5dxcF1RFcQMB/0OXF7gOpbs1+JidhP60OSeUrl+Q09P5 GvPA4TzlSN5YiN2Iwo/eidt6o76s9g==
X-Received: by 10.25.104.5 with SMTP id d5mr1484330lfc.147.1495848821228; Fri, 26 May 2017 18:33:41 -0700 (PDT)
MIME-Version: 1.0
Sender: mglt.ietf@gmail.com
Received: by 10.46.0.14 with HTTP; Fri, 26 May 2017 18:33:40 -0700 (PDT)
In-Reply-To: <149570983670.8681.5001417855088402577@ietfa.amsl.com>
References: <149570983670.8681.5001417855088402577@ietfa.amsl.com>
From: Daniel Migault <daniel.migault@ericsson.com>
Date: Fri, 26 May 2017 21:33:40 -0400
X-Google-Sender-Auth: BsW1gIuTArfSwfSzWZ7rcgrTqZc
Message-ID: <CADZyTkkjsWSJtBQAH8XnKDWLLdd219U4aq+TqLaSMW=Ay=fLmw@mail.gmail.com>
To: Roni Even <ron.even.tlv@gmail.com>
Cc: "gen-art >> General area reviewing team" <gen-art@ietf.org>, draft-ietf-curdle-cms-ecdh-new-curves.all@ietf.org, curdle <curdle@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Content-Type: multipart/alternative; boundary="f403045e589ca08b9f05507771bf"
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/qt62XDHmHH2EDXwpY7s2wihxnfc>
Subject: Re: [Curdle] Genart last call review of draft-ietf-curdle-cms-ecdh-new-curves-07
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 27 May 2017 01:33:48 -0000

Thank you Roni for the review.
Yours,
Daniel

On Thu, May 25, 2017 at 6:57 AM, Roni Even <ron.even.tlv@gmail.com> wrote:

> Reviewer: Roni Even
> Review result: Ready with Nits
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-curdle-cms-ecdh-new-curves-??
> Reviewer: Roni Even
> Review Date: 2017-05-25
> IETF LC End Date: 2017-05-28
> IESG Telechat date: Not scheduled for a telechat
>
> Summary:
> The document is ready for publication as a standard track RFC
>
> Major issues:
>
> Minor issues:
>
> Nits/editorial comments:
>
> In general it was easy to read and follow.  Maybe it will be good to
> repeat in section 3.2 the definition of KeyAgreeRecipientInfo . This
> is done is section 2 for ECC-CMS-SharedInfo but it is not crucial.
>
> 1. There is no ToC
> 2. In section 2.2 fourth paragraph "is used two places" - "in two .."
>
>
>
>
>
> _______________________________________________
> Curdle mailing list
> Curdle@ietf.org
> https://www.ietf.org/mailman/listinfo/curdle
>

v2.23.0 | Report a Bug | By Email