[Curdle] Review of draft-ietf-curdle-cms-chacha20-poly1305-05
Niclas Comstedt <nco@comstedt.net> Thu, 19 January 2017 01:38 UTC
Return-Path: <nco@comstedt.net>
X-Original-To: curdle@ietf.org
Delivered-To: curdle@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4775612948C; Wed, 18 Jan 2017 17:38:36 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Niclas Comstedt <nco@comstedt.net>
To: ops-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.40.3
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <148478991628.2190.10916721959878443239.idtracker@ietfa.amsl.com>
Date: Wed, 18 Jan 2017 17:38:36 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/NTdmbZ3uRSGw_9OM6x_63H8hFno>
Cc: curdle@ietf.org, draft-ietf-curdle-cms-chacha20-poly1305.all@ietf.org
Subject: [Curdle] Review of draft-ietf-curdle-cms-chacha20-poly1305-05
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.17
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jan 2017 01:38:36 -0000
Reviewer: Niclas Comstedt Review result: Has Nits Hi, I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review. Document editors and WG chairs should treat these comments just like any other last call comments. Document reviewed: draft-ietf-curdle-cms-chacha20-poly1305-05 Background: I reviewed 04 and found only minor nits. Summary: Minor nit and incorrect reference - Section 3, still need the 2nd must to all capitals in the following sentence "The AlgorithmIdentifier parameters field MUST be present, and the parameters field must contain a AEADChaCha20Poly1305Nonce:” - Section 6. First paragraph references RFC7534 as if its the same as [FORIETF]. I think the RFC is a typo (and that actual RFC is unrelated). So either needs the corrected RFC or remove that and keep referencing only [FORIETF]. /nco
- [Curdle] Review of draft-ietf-curdle-cms-chacha20… Niclas Comstedt
- Re: [Curdle] Review of draft-ietf-curdle-cms-chac… Russ Housley