Re: [Curdle] Review of draft-ietf-curdle-cms-chacha20-poly1305-05

Russ Housley <housley@vigilsec.com> Thu, 19 January 2017 14:30 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8A8C12961C for <curdle@ietfa.amsl.com>; Thu, 19 Jan 2017 06:30:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pwsvSxomntO6 for <curdle@ietfa.amsl.com>; Thu, 19 Jan 2017 06:30:27 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B717012961A for <curdle@ietf.org>; Thu, 19 Jan 2017 06:30:25 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 7CEBF300290 for <curdle@ietf.org>; Thu, 19 Jan 2017 09:20:09 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id R-gBlKZ1Ywly for <curdle@ietf.org>; Thu, 19 Jan 2017 09:20:08 -0500 (EST)
Received: from [10.85.3.71] (wsip-98-172-24-238.dc.dc.cox.net [98.172.24.238]) by mail.smeinc.net (Postfix) with ESMTPSA id C8E2230026A; Thu, 19 Jan 2017 09:20:07 -0500 (EST)
Content-Type: text/plain; charset="windows-1252"
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <148478991628.2190.10916721959878443239.idtracker@ietfa.amsl.com>
Date: Thu, 19 Jan 2017 09:23:45 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <ADA6ADBA-ACF6-4132-93A9-A8B2A5DD142E@vigilsec.com>
References: <148478991628.2190.10916721959878443239.idtracker@ietfa.amsl.com>
To: Niclas Comstedt <nco@comstedt.net>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/Um6_PYI3K3U9tikm5Hi-Vua_9lA>
Cc: ops-dir@ietf.org, draft-ietf-curdle-cms-chacha20-poly1305.all@ietf.org, curdle@ietf.org
Subject: Re: [Curdle] Review of draft-ietf-curdle-cms-chacha20-poly1305-05
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jan 2017 14:30:28 -0000

Niclas:

Thanks for taking that time to review the document.

> Reviewer: Niclas Comstedt
> Review result: Has Nits
> 
> Hi,
> 
> I have reviewed this document as part of the Operational directorate's
> ongoing effort to review all IETF documents being processed by the
> IESG.  These comments were written with the intent of improving the
> operational aspects of the IETF drafts. Comments that are not
> addressed in last call may be included in AD reviews during the IESG
> review.  Document editors and WG chairs should treat these comments
> just like any other last call comments.
> 
> Document reviewed: draft-ietf-curdle-cms-chacha20-poly1305-05
> 
> Background: I reviewed 04 and found only minor nits.
> 
> Summary: Minor nit and incorrect reference
> 
> - Section 3, still need the 2nd must to all capitals in the following
> sentence 
> "The AlgorithmIdentifier parameters field MUST be present, and the
> parameters field must contain a AEADChaCha20Poly1305Nonce:”

Yes.  I’m pleased to make that change.

> - Section 6. First paragraph references RFC7534 as if its the same as
> [FORIETF]. I think the RFC is a typo (and that actual RFC is
> unrelated). So either needs the corrected RFC or remove that and keep
> referencing only [FORIETF].

I cannot find a reference to RFC 7534.  I see a reference to RFC 7539, which is the correct RFC.

Russ