[Curdle] Genart last call review of draft-ietf-curdle-rsa-sha2-10
Russ Housley <housley@vigilsec.com> Fri, 01 September 2017 13:55 UTC
Return-Path: <housley@vigilsec.com>
X-Original-To: curdle@ietf.org
Delivered-To: curdle@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C91D213328B; Fri, 1 Sep 2017 06:55:48 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley <housley@vigilsec.com>
To: gen-art@ietf.org
Cc: curdle@ietf.org, draft-ietf-curdle-rsa-sha2.all@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.59.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <150427414878.3237.4575033946525642940@ietfa.amsl.com>
Date: Fri, 01 Sep 2017 06:55:48 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/x0P7x-JS-nocSrHKU9Ml2lngGr8>
Subject: [Curdle] Genart last call review of draft-ietf-curdle-rsa-sha2-10
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Sep 2017 13:55:49 -0000
Reviewer: Russ Housley Review result: Almost Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft. For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Document: draft-ietf-curdle-rsa-sha2-10 Reviewer: Russ Housley Review Date: 2017-09-01 IETF LC End Date: 2017-09-11 IESG Telechat date: unknown Summary: Almost Ready Major Concerns: None Minor Concerns: I think that a better title for this document would be: Use of RSA Keys with SHA-256 and SHA-512 in Secure Shell (SSH) These are two of the hash function in the SHA2 family, and there is no ambiguity about them being part of the SHA3 family. Similarly, I think that the Abstract and Section 1 should explicitly names these two hash functions. The current wording seems to include SHA-224 and SHA-384, and that is not the intent of the author. In Section 3, I suggest: s/using SHA-2 [SHS] as hash./using SHA-256 or SHA-512 [SHS] as hash./ s/the hash used is SHA-2 256./the hash used is SHA-256./ s/the hash used is SHA-2 512./the hash used is SHA-512./ Note: I did not propose changing the strings in case people have already implemented against this specification. If no one has implemented yet, then I would change those too. Section 5.1 should be expanded to say that following the NIST advice on key sizes and SHA-1 outside the US Government is prudent. Nits: None
- [Curdle] Genart last call review of draft-ietf-cu… Russ Housley
- Re: [Curdle] Genart last call review of draft-iet… denis bider
- Re: [Curdle] [Gen-art] Genart last call review of… Alissa Cooper
- Re: [Curdle] Genart last call review of draft-iet… Daniel Migault