Re: [dhcwg] Genart last call review of draft-ietf-dhc-mac-assign-06

"Bernie Volz (volz)" <volz@cisco.com> Tue, 26 May 2020 21:10 UTC

Return-Path: <volz@cisco.com>
X-Original-To: dhcwg@ietfa.amsl.com
Delivered-To: dhcwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26A153A07E3; Tue, 26 May 2020 14:10:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.598
X-Spam-Level:
X-Spam-Status: No, score=-9.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=EFyuBdWq; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=Br/1pcHa
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WhILrPk-aUAR; Tue, 26 May 2020 14:10:03 -0700 (PDT)
Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4AC993A07DE; Tue, 26 May 2020 14:10:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3958; q=dns/txt; s=iport; t=1590527403; x=1591737003; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IT05mvLAbn9lkg94DBARE4Ceto5D6kziXhEYBZZk4GU=; b=EFyuBdWqEaCUxEIOEdEF8mbwKP4lqEj7KURS+Mxew4LHZFcF0lsGI5RT jrNH9sSd4VZpcWROwSlaEJXC6NzzoXfrH5MAZiQlAJIjiQLikO9FNOPQE P8DAAdSqRnO4mBTiEdvwR4otM5XKDyBAyCAhAMynSz4IozIkbosIPYYj8 E=;
IronPort-PHdr: =?us-ascii?q?9a23=3AMMhqKxQXsOZJu5+O/x0eCGzREtpsv++ubAcI9p?= =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESQBNmJ5PdNiu6QuKflCiQM4peE5XYFdpEEFx?= =?us-ascii?q?oIkt4fkAFoBsmZQVb6I/jnY21ffoxCWVZp8mv9PR1TH8DzNFLXq3y2qzUVH0?= =?us-ascii?q?a3OQ98PO+gHInUgoy+3Pyz/JuGZQJOiXK9bLp+IQ/wox/Ws5wdgJBpLeA6zR?= =?us-ascii?q?6arw=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CdBQDPhM1e/4gNJK1mHAECAgEHARQ?= =?us-ascii?q?BBAQBQYFHgVRRB29YLywKhBuDRgONQ5g8glIDVQsBAQEMAQElCAIEAQGBUIJ?= =?us-ascii?q?0AheBeCQ4EwIDAQELAQEFAQEBAgEFBG2FVgyFcgEBAQEDEhERDAEBNwELBAI?= =?us-ascii?q?BCA4DAwEBAQMCJgICAjAVCAgCBAENBQgagwWCSwMuAQ6jDwKBOYhhdoEygwE?= =?us-ascii?q?BAQWBNgIBDUGDHxiCDgMGgQ4qgmSJYBqCAIERQ4JNPoJnAgMBgUkagxIzgi2?= =?us-ascii?q?PCIJeoUMKglSIKYtbhHWCY4kCkh2QToFciBKTdAIEAgQFAg4BAQWBaSKBVnA?= =?us-ascii?q?VgyRQGA2EEpAghRSFQnQ3AgYIAQEDCXyLSwGBDwEB?=
X-IronPort-AV: E=Sophos;i="5.73,437,1583193600"; d="scan'208";a="513470532"
Received: from alln-core-3.cisco.com ([173.36.13.136]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 26 May 2020 21:10:02 +0000
Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by alln-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id 04QLA12i014532 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 26 May 2020 21:10:02 GMT
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 26 May 2020 16:10:01 -0500
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 26 May 2020 17:10:00 -0400
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 26 May 2020 16:10:00 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ClE5yhtk0z8SLE39K1WF4nBqGXTrx6dXVRFJUAsMNXAjMjxtvDsOpkh16pAovc55P8tZBdlkN99Xtl1hRxR4cAr0ebN+9aYPJFiugx2hcypivY8yPRZ9wLfHokmqoh6FQQs1mNVx+M9THWvqEyXPaipfs6ptc+caOHPPX/yp4p7aSStxJKcEupnuZJyY+t20ZPzC7QU2pnnlmxlBn1LentvJqQxyzVzImsHn8kBWSXkA7AmGJn8oWaoUdjKS1VdJ6Y5azAnHbnTC4c100Pg7HkyEmle7J9hx3/qVRDmZBDXeV0F5u6Miaz49dfuznYxEZt3Yhr7A01sIUm5h7fbvEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IT05mvLAbn9lkg94DBARE4Ceto5D6kziXhEYBZZk4GU=; b=kt+c+ebICgBS7fr9LZfqmaf/QLjxXc2yrhL3kRppzg6o6AG48YIS3u4zzbvIMRV6QT73iyKr92JwnH9n9f18FAfkrPrY3RWQh5aubYCfD+eSpTO7SSlmymTDCWfGUhzus6iC3iUaL2SPbuVGX371KZ1d6HzH0w+g4KMhvTg2aiy/xs+A3vei8PKyDXwXAhwHheNJiSFwHuCDl9JpkYYiNlPYNfGCtIDCD6l5Cfjhp+7ohnnZ+EWlem5ircIK1i8SPdWUDxUT6za7ZlkUuQgXWKOX2qxHHPQKh/7/d7d3Fa0JxafpRybhgANeYHdd2SxPvJHHTXcVNXz/oEGE6HRrnQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IT05mvLAbn9lkg94DBARE4Ceto5D6kziXhEYBZZk4GU=; b=Br/1pcHa/28pWYlIDOBew8ChO2dasGjHSNBWw6ESra/XxKE6uJaH8z1bF/itFEn0En6wg1IuNAuQWT6BeUEbN+lIOGRqI5Xb4B6IDqtMb0JQZzQ0WM4KdYLg9KuqzCxgAzWxRt6YRJO7LNEyBrXOYOy8jc1XFY8/7UnovOWyat4=
Received: from BN7PR11MB2547.namprd11.prod.outlook.com (2603:10b6:406:af::18) by BN7PR11MB2561.namprd11.prod.outlook.com (2603:10b6:406:af::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Tue, 26 May 2020 21:09:59 +0000
Received: from BN7PR11MB2547.namprd11.prod.outlook.com ([fe80::7d1c:98b:2131:d35]) by BN7PR11MB2547.namprd11.prod.outlook.com ([fe80::7d1c:98b:2131:d35%3]) with mapi id 15.20.3045.016; Tue, 26 May 2020 21:09:59 +0000
From: "Bernie Volz (volz)" <volz@cisco.com>
To: Roni Even <ron.even.tlv@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-dhc-mac-assign.all@ietf.org" <draft-ietf-dhc-mac-assign.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "dhcwg@ietf.org" <dhcwg@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-dhc-mac-assign-06
Thread-Index: AQHWKCmmNtTOse1im02prOPsxCIyt6i68cHg
Date: Tue, 26 May 2020 21:09:59 +0000
Message-ID: <BN7PR11MB2547B6ACBA53E051C8C770F6CFB00@BN7PR11MB2547.namprd11.prod.outlook.com>
References: <158926621972.24137.14737405711720351698@ietfa.amsl.com>
In-Reply-To: <158926621972.24137.14737405711720351698@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [24.233.121.124]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d55a6924-7e1d-4c92-c657-08d801b9261c
x-ms-traffictypediagnostic: BN7PR11MB2561:
x-microsoft-antispam-prvs: <BN7PR11MB256120601C22950D7CA887ADCFB00@BN7PR11MB2561.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 041517DFAB
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 7p3XdSNbBIIpkXKAR6WiqwsZeRSeixKuBFneey3MscbnptRP80b13wgvQpa3Iy945BaJ49hZpIrNLo35VhRiySC1HOoNZntDj7LW18/OPjgCRdwweQkAQDSSM2AboLratanR9iSpyMC21r4tzA9u3w7qNiZjrihNZ4oOUnEnfoydqiS8utE0ev5cgi9va5OcKGMNHPVfMRLNfnlpBnGn+di+66m4jlXjJ3Cuthh88B45m3A/U+2YfnlDqSob7nMEzmxxq/VinTdrEpwQancfVmlsTc6q+p+dSdQqxcBZ1ZNZkCq2mderpxZd7K6/nhkXf7oK0A5BtyG+m48vW8syzaKAy68wPsjogcn0+du3tTTvIkxLIGAyUdtzrIs1wQKni1hacX3xcqfcUteJkyVypQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR11MB2547.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(86362001)(9686003)(8676002)(8936002)(52536014)(33656002)(966005)(186003)(110136005)(5660300002)(66556008)(316002)(478600001)(66446008)(54906003)(66476007)(64756008)(7696005)(26005)(66946007)(4326008)(76116006)(53546011)(6506007)(71200400001)(55016002)(2906002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: UcYUN5bQzkNwz9KKMfvP7h7XZnLz7Ltru5cDC78B4G6L3FgwNk/q3fzw0XB8DK25UOy9Pan6uyOucHxVphMFcZi8AKmUp4tHiwic5UHog/zT49iW7wLQrk76bfFHnSH5s4hITtFogTiiGRP+z7RDIO7NHsGZTNLMJEg1qINfgl0WvkhynPxGXVWGq45pSGDg+KiUh4AK0JYdJI02zMLB3V93+KJHJ4vyf+/Rpp2XKiAcwwglj1yJEaWWYcnYP43f5Dc95A+oQPjnvKiWBEgVjVfHaHBMS08DU1LaqipS3n+jOsyo7YvIABAdBdwpBdUpqjgnXaDSlQQK7qkByXBOwZhLM+18fcAskPzGXFWTFtrcrY0WH6ofviMWEnBGoYYbBqVOAuQJrFtWRLYGFPyPjB6sVw0VEbBJP4EBOrksogdKpqtSz7Io6jRXPnEa6l+euWimBObhrGQeyCbU69Hj4iLnPyXeGG6oA0258/9RpeJ7FIxqNlDx2Ncwgqb0L+u/
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d55a6924-7e1d-4c92-c657-08d801b9261c
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2020 21:09:59.1873 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nOQwTm4j1xR3DLieqhU4uDAtL5z3ZZ1UmXs1kqgcW1544isnrAkWRiAz9ldzxtQm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2561
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.14, xch-aln-004.cisco.com
X-Outbound-Node: alln-core-3.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/dhcwg/6nVYP2e8QofFEe8l2CguQZExS14>
Subject: Re: [dhcwg] Genart last call review of draft-ietf-dhc-mac-assign-06
X-BeenThere: dhcwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <dhcwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dhcwg/>
List-Post: <mailto:dhcwg@ietf.org>
List-Help: <mailto:dhcwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2020 21:10:05 -0000

Hi Roni:

Sorry for the late response to this review. Thanks for doing it!

>1. In the terminology section I was wondering why the client is a device while the server is a software. Any reason for this distinction.

I can easily replace both with "node" as that matches RFC8415:

So:
     client        A device that is interested in obtaining link-layer
...
   server        Software that manages link-layer address allocation and

Replace with:
   client        A node that is interested in obtaining link-layer
...
   server       A node that manages link-layer address allocation and

>2. The server can allocate a smaller size chunk and not the requested size. The allocation policy is up to the server. Should it be required from the server to allocate the largest chunk that is closer to the requested size.

I'm not sure that this would necessarily be the best thing to "require"? It would seem like the most obvious policy, but in the end it really shouldn't matter (i.e., whether the client gets 10% or 90% of what if requested shouldn't matter)? If it needs more, it can send additional requests to get the remaining (in one or more additional requests). And, we generally leave this issues up to the server as policy.


There was another review that raised some issues (see https://datatracker.ietf.org/doc/review-ietf-dhc-mac-assign-06-iotdir-lc-chakrabarti-2020-05-11/) and I had some follow up questions related to it. So, once those get addressed I will likely do an update.

- Bernie

-----Original Message-----
From: Roni Even via Datatracker <noreply@ietf.org> 
Sent: Tuesday, May 12, 2020 2:50 AM
To: gen-art@ietf.org
Cc: draft-ietf-dhc-mac-assign.all@ietf.org; last-call@ietf.org; dhcwg@ietf.org
Subject: Genart last call review of draft-ietf-dhc-mac-assign-06

Reviewer: Roni Even
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-dhc-mac-assign-??
Reviewer: Roni Even
Review Date: 2020-05-11
IETF LC End Date: 2020-05-19
IESG Telechat date: Not scheduled for a telechat

Summary:
The document is ready for publication as a standard track RFC with nits Major issues:

Minor issues:

Nits/editorial comments:
1. In the terminology section I was wondering why the client is a device while the server is a software. Any reason for this distinction.

2. The server can allocate a smaller size chunk and not the requested size. The allocation policy is up to the server. Should it be required from the server to allocate the largest chunk that is closer to the requested size.