Re: [Dime] I-D Action: draft-ietf-dime-doic-rate-control-05.txt

Steve Donovan <srdonovan@usdonovans.com> Wed, 22 March 2017 22:02 UTC

Return-Path: <srdonovan@usdonovans.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C57201293DA for <dime@ietfa.amsl.com>; Wed, 22 Mar 2017 15:02:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.099
X-Spam-Level:
X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, MISSING_HEADERS=1.021, SPF_NEUTRAL=0.779] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iqNt7j5SIIT6 for <dime@ietfa.amsl.com>; Wed, 22 Mar 2017 15:02:57 -0700 (PDT)
Received: from biz131.inmotionhosting.com (biz131.inmotionhosting.com [173.247.247.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E197C129851 for <dime@ietf.org>; Wed, 22 Mar 2017 15:02:57 -0700 (PDT)
Received: from cpe-97-99-50-102.tx.res.rr.com ([97.99.50.102]:64001 helo=Steves-MacBook-Air.local) by biz131.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <srdonovan@usdonovans.com>) id 1cqoL7-001Ebu-Uy for dime@ietf.org; Wed, 22 Mar 2017 15:02:57 -0700
References: <148727508790.1071.1263646507149967833.idtracker@ietfa.amsl.com> <46a97b6d-a4bd-0275-10db-b321dd4d95ed@usdonovans.com> <C306C371-72FB-48D5-BEB4-6910133E112B@gmail.com> <CABPQr24fQjeikXqrx1BBCu_hO61QpT-+wVU74yFeV6n_xDU1uw@mail.gmail.com>
Cc: "dime@ietf.org" <dime@ietf.org>
From: Steve Donovan <srdonovan@usdonovans.com>
Message-ID: <d4bbd443-5b9d-9d50-7698-cf3216858718@usdonovans.com>
Date: Wed, 22 Mar 2017 17:02:45 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CABPQr24fQjeikXqrx1BBCu_hO61QpT-+wVU74yFeV6n_xDU1uw@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------0C8C2FA3EA13BB6314E880E4"
X-OutGoing-Spam-Status: No, score=0.2
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - biz131.inmotionhosting.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - usdonovans.com
X-Get-Message-Sender-Via: biz131.inmotionhosting.com: authenticated_id: srdonovan@usdonovans.com
X-Authenticated-Sender: biz131.inmotionhosting.com: srdonovan@usdonovans.com
X-Source:
X-Source-Args:
X-Source-Dir:
Archived-At: <https://mailarchive.ietf.org/arch/msg/dime/-qfD2N2O1lslWTUTaD-LZRt5MOs>
Subject: Re: [Dime] I-D Action: draft-ietf-dime-doic-rate-control-05.txt
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Mar 2017 22:03:00 -0000

MIsha,

See my comments inline.

Regards,

Steve

On 2/18/17 2:43 AM, Misha Zaytsev wrote:
> Hi Steve,
>
> I'm OK with most your edits, just some extra comments from my side:
>
> The following comment was just partially applied. There are still 
> section titles that are not in an upper case.
> 13. Upper case in section titles for section 7.3.1, 7.3.2, 7.3.3, 8.1 
> and 8.2
> In addition to the listed ones, section 6.3 title is also under the 
> comment.
>
I believe I have captured all of the section titles in the next version. 
   I'm sure the RFC editor will correct any that I missed.
> One new comment:
>
> Following the procedures defined in [draft-ietf-dime-doic]
>
> Are we talking about RFC7683 here?
Yes, change made.
>
> All in all, I'm OK with your edits, but I still have concern about the 
> text taken from SIP RFC.
> As I noted, I think it would be better to have it reworked deeper and 
> not just updated with minor changes to be aligned with DOIC concept. 
> But it looks this is a matter of preference...
Noted.
>
> Best regards,
>
> /Misha
>
>
>
> 2017-02-18 2:23 GMT+03:00 jouni.nospam <jouni.nospam@gmail.com 
> <mailto:jouni.nospam@gmail.com>>:
>
>     Thanks Steve.
>
>     - Jouni
>
>     > On Feb 16, 2017, at 12:00 PM, Steve Donovan
>     <srdonovan@usdonovans.com <mailto:srdonovan@usdonovans.com>> wrote:
>     >
>     > All,
>     >
>     > I've updated the rate control draft based on comments received
>     during the most recent last call.
>     >
>     > I've attached a diff file showing the changes.
>     >
>     > Regards,
>     >
>     > Steve
>     >
>     > On 2/16/17 1:58 PM, internet-drafts@ietf.org
>     <mailto:internet-drafts@ietf.org> wrote:
>     >> A New Internet-Draft is available from the on-line
>     Internet-Drafts directories.
>     >> This draft is a work item of the Diameter Maintenance and
>     Extensions of the IETF.
>     >>
>     >>         Title           : Diameter Overload Rate Control
>     >>         Authors         : Steve Donovan
>     >>                           Eric Noel
>     >>      Filename        : draft-ietf-dime-doic-rate-control-05.txt
>     >>      Pages           : 19
>     >>      Date            : 2017-02-16
>     >>
>     >> Abstract:
>     >>    This specification documents an extension to the Diameter
>     Overload
>     >>    Indication Conveyance (DOIC) [RFC7683] base solution.  This
>     extension
>     >>    adds a new overload control abatement algorithm.  This abatement
>     >>    algorithm allows for a DOIC reporting node to specify a
>     maximum rate
>     >>    at which a DOIC reacting node sends Diameter requests to the
>     DOIC
>     >>    reporting node.
>     >>
>     >> Requirements
>     >>
>     >> The IETF datatracker status page for this draft is:
>     >>
>     https://datatracker.ietf.org/doc/draft-ietf-dime-doic-rate-control/
>     <https://datatracker.ietf.org/doc/draft-ietf-dime-doic-rate-control/>
>     >>
>     >> There's also a htmlized version available at:
>     >>
>     https://tools.ietf.org/html/draft-ietf-dime-doic-rate-control-05
>     <https://tools.ietf.org/html/draft-ietf-dime-doic-rate-control-05>
>     >>
>     >> A diff from the previous version is available at:
>     >>
>     https://www.ietf.org/rfcdiff?url2=draft-ietf-dime-doic-rate-control-05
>     <https://www.ietf.org/rfcdiff?url2=draft-ietf-dime-doic-rate-control-05>
>     >>
>     >>
>     >> Please note that it may take a couple of minutes from the time
>     of submission
>     >> until the htmlized version and diff are available at
>     tools.ietf.org <http://tools.ietf.org>.
>     >>
>     >> Internet-Drafts are also available by anonymous FTP at:
>     >> ftp://ftp.ietf.org/internet-drafts/
>     <ftp://ftp.ietf.org/internet-drafts/>
>     >>
>     >> _______________________________________________
>     >> DiME mailing list
>     >> DiME@ietf.org <mailto:DiME@ietf.org>
>     >> https://www.ietf.org/mailman/listinfo/dime
>     <https://www.ietf.org/mailman/listinfo/dime>
>     >
>     > <Diff_ draft-ietf-dime-doic-rate-control-04.txt -
>     draft-ietf-dime-doic-rate-control-05.txt>_______________________________________________
>     > DiME mailing list
>     > DiME@ietf.org <mailto:DiME@ietf.org>
>     > https://www.ietf.org/mailman/listinfo/dime
>     <https://www.ietf.org/mailman/listinfo/dime>
>
>     _______________________________________________
>     DiME mailing list
>     DiME@ietf.org <mailto:DiME@ietf.org>
>     https://www.ietf.org/mailman/listinfo/dime
>     <https://www.ietf.org/mailman/listinfo/dime>
>
>