Re: [Dime] I-D Action: draft-ietf-dime-doic-rate-control-05.txt

Misha Zaytsev <misha.zaytsev.rus@gmail.com> Sat, 18 February 2017 08:43 UTC

Return-Path: <misha.zaytsev.rus@gmail.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E45321293F0 for <dime@ietfa.amsl.com>; Sat, 18 Feb 2017 00:43:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tU2iawpYlo_B for <dime@ietfa.amsl.com>; Sat, 18 Feb 2017 00:43:35 -0800 (PST)
Received: from mail-lf0-x22b.google.com (mail-lf0-x22b.google.com [IPv6:2a00:1450:4010:c07::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8B7561294C2 for <dime@ietf.org>; Sat, 18 Feb 2017 00:43:34 -0800 (PST)
Received: by mail-lf0-x22b.google.com with SMTP id z134so31463387lff.3 for <dime@ietf.org>; Sat, 18 Feb 2017 00:43:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pOBrAJ33yOTsEr5+xJ2m1aPHixNT37ujDHGrdXKfTvU=; b=TwjJx/yL+fAGWR7W3mTBJrX/pOu0ThAODdtBZWqKk6q1kn2MEpIdtJMCnlrNMvuyxy 7EKDCfjLze5GwcpNr/1uJ524ycs/50bMjpMMOemo3SDHaj/dYOvDNzFQB+IJSwH3H/lZ /mxfvgaDjWzYiu2pJ9U6DRQ+pZfWmjLGdg00UwG9zQ3ADNBbtlHDkq3R9pSCjBfaaDfH dsSmGaaLb8kGB4McnvF6Rkal/hw/jUmgG80FQkDaYeaZlmYSOXN+9TWiMeTOgiUFS9ea M1BGlrqXyk+NrxDiaqk3K7ioJUUjqYAVK3PpjH6LLicvpLZwiL1HgKFk4nqAlhI0ES1D AD7g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pOBrAJ33yOTsEr5+xJ2m1aPHixNT37ujDHGrdXKfTvU=; b=Ct/3y+3fBSTfJyYIxt1AL2FNJoNh+BvozQyooNyhNPYAxNid8tHKY2MKukzKup4HUb lVGB8wW/RB4/pzbne+kLMj0r21KcscZGzVdAjziVGliqD9v3hzbS37K2nsa1En4xaTy4 nYuDmMF+GmTRmNI9do7eGGcpu6ZT7UnC9m1AKWhKPbkHuuxYRlxfhyzGlz7kl7uabUSS 0eXUrzekurC9O6Q9/aQMo8DCUu5cCCa0ja+cz7eijDWkJLLs1wLe7IeQTrcpM28hvlNd Y2dKZlEYWfesS6bgV/w7pyyeggdUtisy9Ht0XXFnWGjFUTjwj/X+TRLAv6bGtsxfLJwq HBCg==
X-Gm-Message-State: AMke39lxUg1W55sGI7dDg7FAN7bgEESgxLk2JDMI3Hp/Q6IC/1W3RSi6FkuM44FYP63XorxyZgNm7qPEw+w90A==
X-Received: by 10.46.20.20 with SMTP id u20mr3215173ljd.61.1487407412641; Sat, 18 Feb 2017 00:43:32 -0800 (PST)
MIME-Version: 1.0
Received: by 10.25.228.12 with HTTP; Sat, 18 Feb 2017 00:43:32 -0800 (PST)
In-Reply-To: <C306C371-72FB-48D5-BEB4-6910133E112B@gmail.com>
References: <148727508790.1071.1263646507149967833.idtracker@ietfa.amsl.com> <46a97b6d-a4bd-0275-10db-b321dd4d95ed@usdonovans.com> <C306C371-72FB-48D5-BEB4-6910133E112B@gmail.com>
From: Misha Zaytsev <misha.zaytsev.rus@gmail.com>
Date: Sat, 18 Feb 2017 11:43:32 +0300
Message-ID: <CABPQr24fQjeikXqrx1BBCu_hO61QpT-+wVU74yFeV6n_xDU1uw@mail.gmail.com>
To: "jouni.nospam" <jouni.nospam@gmail.com>
Content-Type: multipart/alternative; boundary="f403045fc1727788b00548ca068d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dime/Uap8xpmgJUjeAOMPhRh_GTvHvcs>
Cc: "dime@ietf.org" <dime@ietf.org>
Subject: Re: [Dime] I-D Action: draft-ietf-dime-doic-rate-control-05.txt
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Feb 2017 08:43:37 -0000

Hi Steve,

I'm OK with most your edits, just some extra comments from my side:

The following comment was just partially applied. There are still section
titles that are not in an upper case.
13. Upper case in section titles for section 7.3.1, 7.3.2, 7.3.3, 8.1 and
8.2
In addition to the listed ones, section 6.3 title is also under the comment.

One new comment:

Following the procedures defined in [draft-ietf-dime-doic]


Are we talking about RFC7683 here?

All in all, I'm OK with your edits, but I still have concern about the text
taken from SIP RFC.
As I noted, I think it would be better to have it reworked deeper and not
just updated with minor changes to be aligned with DOIC concept. But it
looks this is a matter of preference...

Best regards,

/Misha



2017-02-18 2:23 GMT+03:00 jouni.nospam <jouni.nospam@gmail.com>:

> Thanks Steve.
>
> - Jouni
>
> > On Feb 16, 2017, at 12:00 PM, Steve Donovan <srdonovan@usdonovans.com>
> wrote:
> >
> > All,
> >
> > I've updated the rate control draft based on comments received during
> the most recent last call.
> >
> > I've attached a diff file showing the changes.
> >
> > Regards,
> >
> > Steve
> >
> > On 2/16/17 1:58 PM, internet-drafts@ietf.org wrote:
> >> A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
> >> This draft is a work item of the Diameter Maintenance and Extensions of
> the IETF.
> >>
> >>         Title           : Diameter Overload Rate Control
> >>         Authors         : Steve Donovan
> >>                           Eric Noel
> >>      Filename        : draft-ietf-dime-doic-rate-control-05.txt
> >>      Pages           : 19
> >>      Date            : 2017-02-16
> >>
> >> Abstract:
> >>    This specification documents an extension to the Diameter Overload
> >>    Indication Conveyance (DOIC) [RFC7683] base solution.  This extension
> >>    adds a new overload control abatement algorithm.  This abatement
> >>    algorithm allows for a DOIC reporting node to specify a maximum rate
> >>    at which a DOIC reacting node sends Diameter requests to the DOIC
> >>    reporting node.
> >>
> >> Requirements
> >>
> >> The IETF datatracker status page for this draft is:
> >> https://datatracker.ietf.org/doc/draft-ietf-dime-doic-rate-control/
> >>
> >> There's also a htmlized version available at:
> >> https://tools.ietf.org/html/draft-ietf-dime-doic-rate-control-05
> >>
> >> A diff from the previous version is available at:
> >> https://www.ietf.org/rfcdiff?url2=draft-ietf-dime-doic-rate-control-05
> >>
> >>
> >> Please note that it may take a couple of minutes from the time of
> submission
> >> until the htmlized version and diff are available at tools.ietf.org.
> >>
> >> Internet-Drafts are also available by anonymous FTP at:
> >> ftp://ftp.ietf.org/internet-drafts/
> >>
> >> _______________________________________________
> >> DiME mailing list
> >> DiME@ietf.org
> >> https://www.ietf.org/mailman/listinfo/dime
> >
> > <Diff_ draft-ietf-dime-doic-rate-control-04.txt -
> draft-ietf-dime-doic-rate-control-05.txt>_______________
> ________________________________
> > DiME mailing list
> > DiME@ietf.org
> > https://www.ietf.org/mailman/listinfo/dime
>
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime
>