Re: [Dime] AD review of draft-ietf-dime-4over6-provisioning-03

"Zhouqian (Cathy)" <cathy.zhou@huawei.com> Thu, 09 July 2015 06:37 UTC

Return-Path: <cathy.zhou@huawei.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DC6B71A92DE for <dime@ietfa.amsl.com>; Wed, 8 Jul 2015 23:37:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PsDGE9rq13H9 for <dime@ietfa.amsl.com>; Wed, 8 Jul 2015 23:37:12 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CA98B1A92BB for <dime@ietf.org>; Wed, 8 Jul 2015 23:37:10 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml402-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BYO06662; Thu, 09 Jul 2015 06:37:09 +0000 (GMT)
Received: from SZXEMA412-HUB.china.huawei.com (10.82.72.71) by lhreml402-hub.china.huawei.com (10.201.5.241) with Microsoft SMTP Server (TLS) id 14.3.158.1; Thu, 9 Jul 2015 07:37:08 +0100
Received: from SZXEMA512-MBX.china.huawei.com ([169.254.7.22]) by SZXEMA412-HUB.china.huawei.com ([10.82.72.71]) with mapi id 14.03.0158.001; Thu, 9 Jul 2015 14:37:01 +0800
From: "Zhouqian (Cathy)" <cathy.zhou@huawei.com>
To: Stephen Farrell <stephen.farrell@cs.tcd.ie>, "dime@ietf.org" <dime@ietf.org>
Thread-Topic: [Dime] AD review of draft-ietf-dime-4over6-provisioning-03
Thread-Index: AQHQt9l2u8LOq0lkNkeTATlbAO4Q1p3PlHjA
Date: Thu, 09 Jul 2015 06:37:01 +0000
Message-ID: <A6A061BEE5DDC94A9692D9D81AF776DF409748E3@SZXEMA512-MBX.china.huawei.com>
References: <559A5D34.2040807@cs.tcd.ie>
In-Reply-To: <559A5D34.2040807@cs.tcd.ie>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.66.77.95]
Content-Type: multipart/alternative; boundary="_000_A6A061BEE5DDC94A9692D9D81AF776DF409748E3SZXEMA512MBXchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <http://mailarchive.ietf.org/arch/msg/dime/cymNjSC-fgXMWPMQJi-Lotsx6m8>
Subject: Re: [Dime] AD review of draft-ietf-dime-4over6-provisioning-03
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2015 06:37:15 -0000

Dear Stephen,

Thank you for your comments, my reply is in line with [CZ]..





-----Original Message-----

From: DiME [mailto:dime-bounces@ietf.org] On Behalf Of Stephen Farrell

Sent: Monday, July 06, 2015 6:49 PM

To: dime@ietf.org

Subject: [Dime] AD review of draft-ietf-dime-4over6-provisioning-03





Hiya,



I've done my AD review of draft-ietf-dime-4over6-provisioning-03



Seems to me like all's well. I'll start IETF LC shortly. My few nitty comments are below, please treat then as IETF LC comments.



Thanks,

S.



- intro, 3rd last para: You use both MAP-E and MAP (without a -E) here. Are they the same or is that an implicit subtlty that'd be better explicit? I'd say either use MAP-E in both cases, or explain in general what's meant when you use each.



[CZ]: It should be MAP-E in both cases.



- intro; The last para is very unclear. What does "doesn't specify <x> and that the AVPs...." mean? I'd say split into two sentences.

[CZ]: We will split it as " This document doesn't specify any new commands or Application-Ids. The AVPs specified could be used for any Diameter application suitable for provisioning."



- section 2, 2nd para: Why "allowed to use"? That's wrong anyway, a customer could do other things as well as what one operator provisions for that customer.  S/is allowed/wants/ would be fine.



[CZ]: We will change "allowed" to "wants".



- 2.2 and 2.3: Are we only talking source ports for outgoing traffic here, or is this the list of all ports on which this customer can receive inbound traffic? Would it help to say, since the latter can be bigger than the former? I assume we mean the latter anyway. (This may be a dumb question - sorry if my ignorance of LW4over6 and MAP-E is showing there:-)

[CZ]: We are talking about the source ports here. As defined in LW4over6, when the CE receives an IPv4 packet from the user, it performs a NAPT44 function on the source address and port by using the public IPv4 address and a port number from the allocated port-set.



- 2.5, typo: s/Pv4/IPv4/

[CZ]We will fix it in next version.



- 3.1, I'm surprised there wasn't already an AVP for that. If there is one, or a similar one, it might be good to say and give a bit of a hint when to use which.
[CZ]: There is already an IP-Address-Range AVP defined in [rfc5777], however, there is no definition of the real IP prefix length AVP when it is in a grouped AVP. As also noted in this document, "the IP-Prefix-Length AVP is only relevant when associated with an IP-Address AVP in a Grouped AVP."





- 8.1: the softwire I-D references are outdated. Does everything still work ok with the latest draft versions?

[CZ]: We will update the references in the next version and this dime-provisioning document is consistent with the latest versions.





Best Regards,

Cathy

_______________________________________________

DiME mailing list

DiME@ietf.org

https://www.ietf.org/mailman/listinfo/dime