Re: [Dime] WLGC #2 for draft-ietf-dime-ovli-06

Steve Donovan <srdonovan@usdonovans.com> Thu, 22 January 2015 14:38 UTC

Return-Path: <srdonovan@usdonovans.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D1381ACCD9 for <dime@ietfa.amsl.com>; Thu, 22 Jan 2015 06:38:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.079
X-Spam-Level:
X-Spam-Status: No, score=0.079 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, J_CHICKENPOX_35=0.6, J_CHICKENPOX_38=0.6, SPF_NEUTRAL=0.779] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tTLIy7laX1-l for <dime@ietfa.amsl.com>; Thu, 22 Jan 2015 06:38:28 -0800 (PST)
Received: from biz131.inmotionhosting.com (biz131.inmotionhosting.com [173.247.247.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D22561ACCD8 for <dime@ietf.org>; Thu, 22 Jan 2015 06:38:27 -0800 (PST)
Received: from cpe-76-187-100-94.tx.res.rr.com ([76.187.100.94]:60409 helo=Steves-MacBook-Air-2.local) by biz131.inmotionhosting.com with esmtpsa (UNKNOWN:RC4-SHA:128) (Exim 4.82) (envelope-from <srdonovan@usdonovans.com>) id 1YEIts-000C9F-SL for dime@ietf.org; Thu, 22 Jan 2015 06:38:27 -0800
Message-ID: <54C10B60.7010405@usdonovans.com>
Date: Thu, 22 Jan 2015 08:38:24 -0600
From: Steve Donovan <srdonovan@usdonovans.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: dime@ietf.org
References: <54B5399D.3020600@gmail.com> <AEE2E3C8-9ADF-4D0F-9793-B1F15A0EFDBA@nostrum.com> <54BEA19E.80309@usdonovans.com> <444F5015-38E2-4D19-A5F8-EBC32BAD38F6@nostrum.com> <54BEC3E7.40703@usdonovans.com>
In-Reply-To: <54BEC3E7.40703@usdonovans.com>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
X-OutGoing-Spam-Status: No, score=-2.9
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - biz131.inmotionhosting.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - usdonovans.com
X-Get-Message-Sender-Via: biz131.inmotionhosting.com: authenticated_id: srd+usdonovans.com/only user confirmed/virtual account not confirmed
Archived-At: <http://mailarchive.ietf.org/arch/msg/dime/he0sRRIizydh--gfQCWXhyUTguo>
Subject: Re: [Dime] WLGC #2 for draft-ietf-dime-ovli-06
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jan 2015 14:38:30 -0000

All,

We need to close these two issues to finish WGLC #2.

Please review an let me know if the alternatives I have outlined below 
are acceptable.

Thanks,

Steve

On 1/20/15 3:08 PM, Steve Donovan wrote:
>
> On 1/20/15 1:20 PM, Ben Campbell wrote:
>>> On Jan 20, 2015, at 12:42 PM, Steve Donovan 
>>> <srdonovan@usdonovans.com> wrote:
>>>
>>> The following is the resolution of Ben's issues that were not 
>>> addressed directly in an email thread started by Ulrich.
>>>
>>> Regards,
>>>
>>> Steve
>>>
>>>> -- 5.3, 4th paragraph:
>>>>
>>>> As I mentioned in previous discussion, after re-reading the related 
>>>> text in 6733, it's no longer clear to me this works like we thought 
>>>> it did. That is, I think any attempt to make sub-AVPs mandatory 
>>>> risks causing errors in the enclosing Diameter transaction. I don't 
>>>> know how to solve this, other just disallowing mandatory sub-AVPs. 
>>>> (Jouni previously convinced me 6733 treatment of the m-bit in 
>>>> sub-avps worked like we wanted--perhaps he can re-convince me :-)
>>>>
>>> SRD>Given that Jouni successfully convinced Ben about the 6733 
>>> treatment, I'm not planning to make any changes, as I'm assuming he 
>>> can be just as successful the second time.
>> I think that's a bad assumption.
>>
>> We had previously assumed that if a node receives a grouped AVP 
>> (without the m-bit set) that includes an unrecognized sub-avp with 
>> the m-bit set, then the receiver could just ignore the entire grouped 
>> AVP, and otherwise process the transaction. But 6733 actually says 
>> the following:
>>
>> "Receivers of a Grouped AVP that
>>     does not have the 'M' (mandatory) bit set and one or more of the
>>     encapsulated AVPs within the group has the 'M' (mandatory) bit set
>>     MAY simply be ignored if the Grouped AVP itself is unrecognized.  
>> The
>>     rule applies even if the encapsulated AVP with its 'M' (mandatory)
>>     bit set is further encapsulated within other sub-groups, i.e., other
>>     Grouped AVPs embedded within the Grouped AVP."
>>
>> Note the "... if the Grouped AVP itself is unrecognized." clause.
>>
>> The case we have in mind is when you receive a _recognized_ grouped 
>> AVP (that is, you implement DOIC), but it includes an unrecognized 
>> sub-avp with the M-bit set. This is not covered by the exception. 
>> This would seem to indicate that the entire request must fail. I 
>> don't think that's what we want.
> SRD> I see how it could be interpreted that way.
>>
>> At this point, I think we need to either say that sub-avps of DOIC 
>> grouped AVPs either 1) MUST NOT have the m-bit set, or 2) MUST NOT 
>> have the m-bit set unless the sub-avp is part of an extension 
>> explicitly negotiated in the feature vector.
> SRD> I'm ok either way but prefer number 2).
>>
>>
>>
> [...]
>>>> Paragraph 5:
>>>>
>>>> Is this redundant to the last paragraph of 5.2.2?
>>>>
>>> SRD> I don't see an issue.  One is general and the other specific to 
>>> the loss algorithm.  They don't conflict.
>> The one in 5.2.2 is specific to situations where an OLR quenches all 
>> requests, and says MUST. So is this, and says RECOMMENDED (which 
>> means SHOULD in 2119).
> SRD>Actually 5.2.2 isn't only about quenching.  It's also about the 
> reacting node having sent no traffic, because it had no traffic to 
> send, and now needs to send traffic soon after the OCS expires. The 
> reporting node might still be in an overload state but the reacting 
> node doesn't know until the first request is sent.
>>
>> If the idea is that the text in 6.3 is the recommended way to fulfill 
>> the MUST in 5.2.2, then that's okay I guess (although I would prefer 
>> one of the two to be non-normative.)
> SRD> 6.3 deals specifically with quenching, thus is a little different 
> than 5.2.2, although there is overlap.
>>
>> Another approach would to leave this to 6.3, and add something to the 
>> effect that any new algorithm that can cause total quenching of 
>> requests must address how the reacting node restarts from that state.
> SRD> I prefer to leave it as it currently is.
>>
>> [...]
>
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime
>