Re: [dns-privacy] Martin Duke's No Objection on draft-ietf-dprive-xfr-over-tls-11: (with COMMENT)

Sara Dickinson <sara@sinodun.com> Wed, 28 April 2021 10:27 UTC

Return-Path: <sara@sinodun.com>
X-Original-To: dns-privacy@ietfa.amsl.com
Delivered-To: dns-privacy@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA5203A23F4; Wed, 28 Apr 2021 03:27:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.4
X-Spam-Level:
X-Spam-Status: No, score=-4.4 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=sinodun.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ldoxstnKxrUG; Wed, 28 Apr 2021 03:27:51 -0700 (PDT)
Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D8003A23F2; Wed, 28 Apr 2021 03:27:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sinodun.com ; s=mythic-beasts-k1; h=To:Date:From:Subject; bh=xNvSIH87bm6ETLgL725p740x8vVfDek9k1vpxnTnbDw=; b=qsEVZny7KbXLJQoqnwyrD0TH1J gWDo/Dcg2SBKWI6IpKPb9kUW4GotdYM0zkOtZ2Tx2cQKvcpwrHOuyQlIVOlT/EE60bgL+gX1JKQUw F+SvRGfH/gYBzhj7P/kD4aNslaw31sNTGeJ18aqdbLEPlyN9e9z59H/rhpMo1GhigIAqtIGcmssQ1 a/+9YEZBNEvDSs+gEkWbOkZpO8BQ4Wep16qHZTYOXrC7zvoxrvDqluH2nfrqD5viQYGqmMRjINlFv VImDl1El3oJcewN7A3V9sdxY0/6Jp9ETXikN4HBLnkY1UE2MVmDdRf95n/orCh2xKheV9dmiJdbY6 YZZl+s+A==;
Received: from [2a02:8010:6126:0:947f:b00f:8d05:b89e] (port=61981) by balrog.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from <sara@sinodun.com>) id 1lbhQ0-0003pQ-QM; Wed, 28 Apr 2021 11:27:48 +0100
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
From: Sara Dickinson <sara@sinodun.com>
In-Reply-To: <161921129877.20343.10624609154750488813@ietfa.amsl.com>
Date: Wed, 28 Apr 2021 11:27:35 +0100
Cc: The IESG <iesg@ietf.org>, draft-ietf-dprive-xfr-over-tls@ietf.org, dprive-chairs@ietf.org, dns-privacy@ietf.org, tjw.ietf@gmail.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <034F6C49-0195-4FAF-9EF2-1E39E809F902@sinodun.com>
References: <161921129877.20343.10624609154750488813@ietfa.amsl.com>
To: Martin Duke <martin.h.duke@gmail.com>
X-Mailer: Apple Mail (2.3445.104.17)
X-BlackCat-Spam-Score: 4
Archived-At: <https://mailarchive.ietf.org/arch/msg/dns-privacy/O2em8LyW_lnycXDw2pWMHo4axhU>
Subject: Re: [dns-privacy] Martin Duke's No Objection on draft-ietf-dprive-xfr-over-tls-11: (with COMMENT)
X-BeenThere: dns-privacy@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <dns-privacy.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dns-privacy>, <mailto:dns-privacy-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dns-privacy/>
List-Post: <mailto:dns-privacy@ietf.org>
List-Help: <mailto:dns-privacy-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dns-privacy>, <mailto:dns-privacy-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2021 10:27:57 -0000


> On 23 Apr 2021, at 21:54, Martin Duke via Datatracker <noreply@ietf.org> wrote:
> 
> Martin Duke has entered the following ballot position for
> draft-ietf-dprive-xfr-over-tls-11: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-dprive-xfr-over-tls/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ———————————————————————————————————

Martin, 

Many thanks for the review.

> 
> - Please explicitly state that, IIUC, these XoT connections use the DoT ALPN.

That is not actually the case, but even so, we should probably add text to clarify the matter. 

An early version of this specification proposed a XoT specific ALPN in order to distinguish this from a connection intended to perform recursive to authoritative DoT (often called ADoT). ADoT is not yet specified, but is the subject of ongoing discussions in DPRIVE. The working group rejected this idea for XoT and switched to the current spec which does not use an ALPN at all. Note that one of the proposals for how DoT support by authoritatives for ADoT would be signalled does use the DoT ALPN. 

> 
> - There ought to be a warning somewhere that mTLS verifies that the CA has
> verified identity, while IP ACLs merely prove that the bearer can observe the
> path to the address. The former is much stronger than the latter, unless there
> are more mechanisms built into the ACL than are obvious from the text here.

Agreed, and this follows up on a previous similar comment. We could add text to section 10.4 at the end of the second paragraph along the lines:

“Is should also be noted that mTLS provides a stronger authentication of the client than an IP ACL because the former is based directly on a verified identity.”

We could also add something to the security considerations but I struggled to find a good reference for the issues with IP address validation?

> 
> - Please educate me: from my skim of the RFCs AXFR has message IDs, but IFXR
> does not. So how would a client demux IFXR responses?

IXFRs do use message IDs - they are defined as just ’normal’ DNS messages with the IXFR query type in RFC1995 and so inherit that requirement (although on re-reading it isn’t _explicitly_ described there).  In that original specification IXFRs can use UDP (or TCP) and so would definitely require message IDs for UDP. I’m not aware of any implementation that omits message IDs for IXFRs. Is there something else you saw that lead you to think otherwise?

I think the confusion could arise because in RFC1034/1035 only AXFR was defined and was required to use TCP, in contrast to other DNS queries at that time. The description of message exchange is vague and apparently lead to some implementations doing only a single AXFR transaction per TCP connection and therefore omitting the transaction ID.  The 2010 update to the AXFR specification (RFC5936) notes and corrects this confusion in section 4.1. 

Best regards

Sara.