Re: [dns-privacy] [Ext] Intdir telechat review of draft-ietf-dprive-unilateral-probing-12

Paul Hoffman <paul.hoffman@icann.org> Thu, 07 September 2023 23:25 UTC

Return-Path: <paul.hoffman@icann.org>
X-Original-To: dns-privacy@ietfa.amsl.com
Delivered-To: dns-privacy@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 10D2BC14CE38; Thu, 7 Sep 2023 16:25:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.906
X-Spam-Level:
X-Spam-Status: No, score=-1.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cswK2iao9dna; Thu, 7 Sep 2023 16:25:20 -0700 (PDT)
Received: from ppa2.lax.icann.org (ppa2.lax.icann.org [192.0.33.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1A9B5C14F6EC; Thu, 7 Sep 2023 16:25:20 -0700 (PDT)
Received: from MBX112-W2-CO-2.pexch112.icann.org (out.mail.icann.org [64.78.33.6]) by ppa2.lax.icann.org (8.17.1.19/8.17.1.19) with ESMTPS id 387NPHFT010496 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 7 Sep 2023 23:25:17 GMT
Received: from MBX112-W2-CO-1.pexch112.icann.org (10.226.41.128) by MBX112-W2-CO-1.pexch112.icann.org (10.226.41.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Thu, 7 Sep 2023 16:25:16 -0700
Received: from MBX112-W2-CO-1.pexch112.icann.org ([10.226.41.128]) by MBX112-W2-CO-1.pexch112.icann.org ([10.226.41.128]) with mapi id 15.02.1118.037; Thu, 7 Sep 2023 16:25:16 -0700
From: Paul Hoffman <paul.hoffman@icann.org>
To: Tommy Pauly <tpauly@apple.com>
CC: "int-dir@ietf.org" <int-dir@ietf.org>, "dns-privacy@ietf.org" <dns-privacy@ietf.org>, "draft-ietf-dprive-unilateral-probing.all@ietf.org" <draft-ietf-dprive-unilateral-probing.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: [Ext] Intdir telechat review of draft-ietf-dprive-unilateral-probing-12
Thread-Index: AQHZ4d2ViZTB9ukYK0KmRZ440HXiVrAQdrqA
Date: Thu, 07 Sep 2023 23:25:16 +0000
Message-ID: <296EB3F1-D8AC-4B67-8AA2-31CF83D4456E@icann.org>
References: <169412697520.52202.16327544275558835903@ietfa.amsl.com>
In-Reply-To: <169412697520.52202.16327544275558835903@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [192.0.32.234]
x-source-routing-agent: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <EAA456EAD53A2D4BA651F918E83EBF7F@pexch112.icann.org>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-07_13,2023-09-05_01,2023-05-22_02
Archived-At: <https://mailarchive.ietf.org/arch/msg/dns-privacy/e0yw9huNwv5ueBT7aX_eKCrpSwo>
Subject: Re: [dns-privacy] [Ext] Intdir telechat review of draft-ietf-dprive-unilateral-probing-12
X-BeenThere: dns-privacy@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Addition of privacy to the DNS protocol <dns-privacy.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dns-privacy>, <mailto:dns-privacy-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dns-privacy/>
List-Post: <mailto:dns-privacy@ietf.org>
List-Help: <mailto:dns-privacy-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dns-privacy>, <mailto:dns-privacy-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Sep 2023 23:25:25 -0000

Thanks for the review!

On Sep 7, 2023, at 3:49 PM, Tommy Pauly via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Tommy Pauly
> Review result: Ready with Nits
> 
> I am an assigned INT directorate reviewer for
> draft-ietf-dprive-unilateral-probing. These comments were written primarily for
> the benefit of the Internet Area Directors. Document editors and shepherd(s)
> should treat these comments just like they would treat comments from any other
> IETF contributors and resolve them along with any other Last Call comments that
> have been received. For more details on the INT Directorate, see
> https://urldefense.com/v3/__https://datatracker.ietf.org/group/intdir/about/__;!!PtGJab4!4iLY4CWNWu6jI6uPwY9s6SVNFub8COCEk2E3QqLGvwi22RztZ1ttsbFRlcFmC02uvF3D6rUSk3aev2LDnYem1JJF$ [datatracker[.]ietf[.]org]
> <https://urldefense.com/v3/__https://datatracker.ietf.org/group/intdir/about/__;!!PtGJab4!4iLY4CWNWu6jI6uPwY9s6SVNFub8COCEk2E3QqLGvwi22RztZ1ttsbFRlcFmC02uvF3D6rUSk3aev2LDnYem1JJF$ [datatracker[.]ietf[.]org]>."
> 
> Thanks for a well-written and valuable document. The privacy benefits of this
> opportunistic approach represent an important step. I have a few comments/nits,
> but none are major.
> 
> Comments:
> - In Section 3.1, “Pooled Authoritative Servers Behind a Single IP Address”, is
> it truly always a single IP address? I would assume that there could be a
> load-balancer that has both an IPv4 and an IPv6 address that forwards to a
> pool. Would it be more accurate to call this “…Behind a Load Balancer”?
> 

Good catch, yes.

> Nits:
> 
> - It would be nice to add some text in the body of Section 2 (before Section
> 2.1) to explain what is meant by “priorities”, rather than having a bare
> section heading. For example, “The protocol described in this document is based
> on prioritizing the following features.” - In Section 2.2, should future
> protocols other than DoT/DoQ be mentioned as being appropriate for this
> mechanism (or not)? - It would be nice if the examples in Section 4.5 that
> don’t list both IPv4 and IPv6 example addresses chose IPv6 as the primary
> example.
> 

Yeah, that section got sidetracked. Can fix.

--Paul Hoffman