Re: [DNSOP] Incompatibility with indicating client support for EDE (draft-ietf-dnsop-structured-dns-error)

tirumal reddy <kondtir@gmail.com> Thu, 25 May 2023 14:48 UTC

Return-Path: <kondtir@gmail.com>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84224C13AE2B for <dnsop@ietfa.amsl.com>; Thu, 25 May 2023 07:48:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.095
X-Spam-Level:
X-Spam-Status: No, score=-7.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ghJ6NwveZRgc for <dnsop@ietfa.amsl.com>; Thu, 25 May 2023 07:48:26 -0700 (PDT)
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AF94BC13AE29 for <dnsop@ietf.org>; Thu, 25 May 2023 07:48:26 -0700 (PDT)
Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2af214a1929so3770151fa.0 for <dnsop@ietf.org>; Thu, 25 May 2023 07:48:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685026104; x=1687618104; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gkErsOwu69e5mJzzFkEKlb5LsjIDhSET4HyAn1b524s=; b=Z722+Ps45UaEX8TWHCPKIrM4k27L3zhsn5T5D3eRhiNMWzsizFeQ2Ze6Lyl0wkJNSQ Ie6m+d5RvHL09DywqtWSJ+ToENCrB1r5nhLg5f7TUg+T9kTgNsjmDAsBI9bi9WCBIkQR UW1GM1nYjQVyGlZynx+opA4dLSEeU5V1hBfSletXuh/gcvATmEaWxqqCFVVkJsxMQTXj WhjBiJpylNEs5hQdl/yJgJBt/+HVXcU+VXiZ4dHHwsh7I5HTviJY8W+uwL4iAqsENWqy CuFiea3jKu66pGdniksHYSs6sh+3LH1I8dPLAOQz2+jZcOTgoQeOirjpj3CLGe9/1C7D YZQA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685026104; x=1687618104; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gkErsOwu69e5mJzzFkEKlb5LsjIDhSET4HyAn1b524s=; b=HeIYLgbA+DNoWFyn6bo/IqBnfyEZ6ZYasruoxDJXfurlaQHMN7A6yV9YylA/4oA9Rw 34K03RZRyEYYi1d9Bhj6DP95CLTOE4TxoBro9BMgSsm4ECYR9Gv+H0LDdbY4Kei6xlUs EGU0zFnUykQHmifiClcOf0eK6AYRw+DXdifazPLxtvii2eZO1F/GUOkNMhrSSpfq9aQD wHOl2BBPBm+P64XD3y4DcB4KRSXym4jlX1RyCbWbTVkTa3hi5NV3j3vCY7Qu4EQ5Us4G tv994UxkqSU7h1WILplHihCEN0qPZ/tIe5KLMUJ0V2r4ST+ZkKiq61SuYCa7Yji5y+sI pXFw==
X-Gm-Message-State: AC+VfDzs2F9nzxeTFY5p2L5DjD9ncTwuML1xszTtarePJUONCtbRasgf 9Ia19GQIZmCU1TzX8VgirvqOLDDhJCCMS+6yL3c=
X-Google-Smtp-Source: ACHHUZ74J2uthAYd1ebnr9SH6DaZM+RFvMIs2x7A5kT8m8PWkWFnYB37y7jFYq4bAM1FJUSorohttTH+Hp7SwSJdplY=
X-Received: by 2002:a2e:a37a:0:b0:2af:150f:d421 with SMTP id i26-20020a2ea37a000000b002af150fd421mr7620329ljn.5.1685026103810; Thu, 25 May 2023 07:48:23 -0700 (PDT)
MIME-Version: 1.0
References: <1BE5004E-B64D-407D-80F5-EB25D7BB671C@apple.com> <4A22932F-1980-438E-9B6A-176B82CECE50@isc.org> <A474412D-191B-48BD-8FC4-E07578E9C487@apple.com> <A79A4C21-43FD-4CC1-91C8-73F0F1C4BF28@gmail.com> <3255E1FA-0864-4BA6-A131-B478938714AE@apple.com> <CAFpG3gd3iJjAcAHL_0bvy9Tmhvm1POUd8YM7iuUsUhgg0YEidg@mail.gmail.com> <5CCD101E-8CC1-4557-80A3-6E4FEDD29F92@apple.com>
In-Reply-To: <5CCD101E-8CC1-4557-80A3-6E4FEDD29F92@apple.com>
From: tirumal reddy <kondtir@gmail.com>
Date: Thu, 25 May 2023 20:18:12 +0530
Message-ID: <CAFpG3gcCVxeW+hf3AD9Yyx3wV3Vv_5URgbAquYsuGdX0pnkXUw@mail.gmail.com>
To: Tommy Pauly <tpauly@apple.com>
Cc: Dan Wing <danwing@gmail.com>, DNSOP WG <dnsop@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000005ae04205fc85b6b0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/TVVOvz2RV1oVGCBy5FP55gRxd8o>
Subject: Re: [DNSOP] Incompatibility with indicating client support for EDE (draft-ietf-dnsop-structured-dns-error)
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2023 14:48:30 -0000

On Wed, 24 May 2023 at 19:30, Tommy Pauly <tpauly@apple.com> wrote:

>
>
> On May 24, 2023, at 12:00 AM, tirumal reddy <kondtir@gmail.com> wrote:
>
> On Wed, 24 May 2023 at 01:48, Tommy Pauly <tpauly=
> 40apple.com@dmarc.ietf.org> wrote:
>
>> Using length=2 and INFO-CODE=0 sounds fine to me.
>>
>> For the dependency on draft-ietf-add-resolver-info, I don't think we need
>> to impose that dependency. I'd much prefer to allow clients to look at that
>> optionally, but still be able to include the hint and use the extra text if
>> it parses correctly.
>>
>
> Dependency on draft-ietf-add-resolver-info was added to address the threat
> where an attacker might inject (or modify) the EDE EXTRA-TEXT field with an
> DNS proxy or DNS forwarder that is unaware of EDE.More details are
> discussed in Section 10 of the draft.
>
>
> Using encrypted DNS to a known/trusted resolver can achieve this as well,
> so I think it is better as a recommendation of one way, but not a required
> way.
>

Works for me, we will update the draft.

-Tiru


>
> Tommy
>
>
> Cheers,
> -Tiru
>
>
>>
>> Tommy
>>
>> On May 23, 2023, at 9:52 AM, Dan Wing <danwing@gmail.com> wrote:
>>
>> EDE length=2 with INFO-CODE=0 works nicely.
>>
>> Also because non-EDE-aware DNS responders can be vulnerable to attacks
>> described in Security Considerations, the Security Considerations section
>> currently suggests clients use draft-ietf-add-resolver-info to check if
>> server supports EDE. This needs better clarification in the document that
>> client has to check draft-ietf-add-resolver-info before including EDE OPT
>> in its DNS query. This check will further help interop by only sending EDE
>> in requests to servers that indicated support via
>> draft-ietf-add-resolver-info. However, it creates
>> draft-ietf-add-resolver-info as another hurdle to deployment of Structured
>> DNS error.  Thoughts?
>>
>> (I also put the above text into our github issues; I don't know which
>> folks prefer.
>> https://github.com/ietf-wg-dnsop/draft-ietf-dnsop-structured-dns-error/issues/26
>> )
>>
>> -d
>>
>>
>> On May 22, 2023, at 7:44 PM, Tommy Pauly <tpauly=
>> 40apple.com@dmarc.ietf.org> wrote:
>>
>> Thanks, Mark.
>>
>> For what it's worth, I just ran two other tests, and for both of these
>> cases, all of the resolvers I tried did accept the request:
>> - Choose a new EDNS option code point (I just tested 50, randomly)
>> - Use EDE but set the length to 2 and the error to 0 (other error),
>> rather than a length of 0
>>
>> Both of these seem viable, and I’ll let the authors and WG decide which
>> is the right way forward.
>>
>> Best,
>> Tommy
>>
>> On May 22, 2023, at 5:00 PM, Mark Andrews <marka@isc.org> wrote:
>>
>>
>>
>> On 23 May 2023, at 02:20, Tommy Pauly <tpauly=40apple.com@dmarc.ietf.org>
>> wrote:
>>
>> Hello DNSOP,
>>
>> In draft-ietf-dnsop-structured-dns-error, there’s a description of how
>> clients should indicate that they understand extended DNS errors (EDE) by
>> sending an empty EDE option.
>>
>>
>> https://www.ietf.org/archive/id/draft-ietf-dnsop-structured-dns-error-02.html#name-client-generating-request
>>
>> This is something that makes a lot of sense to me, and provides a great
>> way to indicate that a client would prefer to receive proper
>> blocked/filtered errors (with possible extra text) as opposed to a forged
>> answer.
>>
>> However, in testing this out, I’m seeing inconsistent compatibility with
>> some public resolvers. I was testing enabling this for encrypted resolvers
>> only, and I see the following behavior for a sampling of resolvers using
>> DoH:
>>
>> 1.1.1.1 - NOERROR, works fine!
>> 9.9.9.9 - NOERROR, works fine!
>> 8.8.8.8 - FORMERR on all responses
>> dns.adguard-dns.com - SERVFAIL on all responses
>>
>> Do we think that this should be allowed in queries (and thus this is a
>> bug in resolvers like 8.8.8.8 or AdGuard)? Or is there a problem with the
>> approach this document is suggesting?
>>
>>
>> RFC 8914 left whether EDE in requests was permitted or not undefined.  I
>> can see an EDE implementation making the option parser return FORMERR if
>> the EDE option length was less than 2 and applying that to both requests
>> and responses.  RFC 8914 really should have said that EDE in requests
>> should be ignored and then there would have been a possibility on extending
>> behaviour based on adding EDE to a request.  We are already 10 years into
>> trying to fix unknown EDNS option behaviour and are still getting FORMERR
>> on unknown EDNS options in requests.  If the working group want to allow
>> extending EDE by adding it to a request is should obsolete RFC 8914 now
>> with RFC8914bis that specifies that EDE in requests are to be ignored.
>>
>> At the moment draft-ietf-dnsop-structured-dns-error-02 really should use
>> another EDNS option code point.  It really is not backwards compatible with
>> EDE the way it is currently specified.
>>
>>
>> Best,
>> Tommy
>> _______________________________________________
>> DNSOP mailing list
>> DNSOP@ietf.org
>> https://www.ietf.org/mailman/listinfo/dnsop
>>
>>
>> --
>> Mark Andrews, ISC
>> 1 Seymour St., Dundas Valley, NSW 2117, Australia
>> PHONE: +61 2 9871 4742              INTERNET: marka@isc.org
>>
>> _______________________________________________
>> DNSOP mailing list
>> DNSOP@ietf.org
>> https://www.ietf.org/mailman/listinfo/dnsop
>>
>>
>> _______________________________________________
>> DNSOP mailing list
>> DNSOP@ietf.org
>> https://www.ietf.org/mailman/listinfo/dnsop
>>
>>
>> _______________________________________________
>> DNSOP mailing list
>> DNSOP@ietf.org
>> https://www.ietf.org/mailman/listinfo/dnsop
>>
>>
>> _______________________________________________
>> DNSOP mailing list
>> DNSOP@ietf.org
>> https://www.ietf.org/mailman/listinfo/dnsop
>
>
>