Re: [Doh] [Ext] Warren Kumari's No Objection on draft-ietf-doh-dns-over-https-13: (with COMMENT)

Paul Hoffman <paul.hoffman@icann.org> Wed, 15 August 2018 16:47 UTC

Return-Path: <paul.hoffman@icann.org>
X-Original-To: doh@ietfa.amsl.com
Delivered-To: doh@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8026130E68; Wed, 15 Aug 2018 09:47:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E0WlqQbLaJcD; Wed, 15 Aug 2018 09:47:17 -0700 (PDT)
Received: from out.west.pexch112.icann.org (out.west.pexch112.icann.org [64.78.40.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D44C130DC8; Wed, 15 Aug 2018 09:47:17 -0700 (PDT)
Received: from PMBX112-W1-CA-1.pexch112.icann.org (64.78.40.21) by PMBX112-W1-CA-1.pexch112.icann.org (64.78.40.21) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 15 Aug 2018 09:47:15 -0700
Received: from PMBX112-W1-CA-1.pexch112.icann.org ([64.78.40.21]) by PMBX112-W1-CA-1.PEXCH112.ICANN.ORG ([64.78.40.21]) with mapi id 15.00.1367.000; Wed, 15 Aug 2018 09:47:15 -0700
From: Paul Hoffman <paul.hoffman@icann.org>
To: Warren Kumari <warren@kumari.net>
CC: The IESG <iesg@ietf.org>, "draft-ietf-doh-dns-over-https@ietf.org" <draft-ietf-doh-dns-over-https@ietf.org>, "doh-chairs@ietf.org" <doh-chairs@ietf.org>, DoH WG <doh@ietf.org>
Thread-Topic: [Ext] Warren Kumari's No Objection on draft-ietf-doh-dns-over-https-13: (with COMMENT)
Thread-Index: AQHUNLR9c2LKZrGOCU+EIZwTmqypNKTBeywA
Date: Wed, 15 Aug 2018 16:47:15 +0000
Message-ID: <041E52A4-E854-4D06-A25D-5C50762DCFCF@icann.org>
References: <153435028609.14458.3744003304771066071.idtracker@ietfa.amsl.com>
In-Reply-To: <153435028609.14458.3744003304771066071.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [192.0.32.234]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5D7723963EBBEF45A19425A62899B7BF@pexch112.icann.org>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/doh/eYtkOr99_dQt4X0hncrDWNK2I0Y>
Subject: Re: [Doh] [Ext] Warren Kumari's No Objection on draft-ietf-doh-dns-over-https-13: (with COMMENT)
X-BeenThere: doh@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: DNS Over HTTPS <doh.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/doh>, <mailto:doh-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/doh/>
List-Post: <mailto:doh@ietf.org>
List-Help: <mailto:doh-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/doh>, <mailto:doh-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Aug 2018 16:47:19 -0000

On Aug 15, 2018, at 9:24 AM, Warren Kumari <warren@kumari.net> wrote:
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thank you -- I've been following this work, and so only have a few minor
> comments at this point...
> 
> Section 3. Protocol Requirements
> I really think that this section should remain - it is helpful to people new to
> the technology to understand how and why design decisions were made. If you are
> not comfortable with it in the body of the document, perhaps it could be made
> an Appendix.

We've now heard this from a bunch of the IETF-wide reviewers. Patrick pointed out earlier that the WG has seen this section as "will be removed" during the later part of the WG process, and that it was not meant to limit future work on DoH. Having said that, making it an appendix with some wording to not limit future work could be nearly harmless. We'll look at that.

> Section 5.1.  The HTTP Request
> " In order to maximize cache friendliness, DoH clients using media formats that
> include DNS ID, such as application/dns-message, SHOULD use a DNS ID of 0 in
> every DNS request." While this should be obvious, as this document is talking
> about both DNS and HTTP it would be helpful to clarify **which** cache.

This was already caught by earlier reviewers. Our working copy now says which cache is being discussed in a more places, including here.

> Section 6.1.  Cache Interaction
> "This requirement helps assure that none of the RRsets contained in a DNS
> response are served stale from an HTTP cache." The wording of this feels a
> little "clunky", but I don't really have a suggested fix. I also think that it
> would be helpful if the "served stale" term could be changed, but this might
> just be because I think of draft-ietf-dnsop-serve-stale when I see that.

Based on an earlier comment, we made it clear that this was about unintentionally serving stale. I agree that "stale" is not really the right word here; RFC 1035 uses "expired", so we can use it here.

> General:
> You *might* want RFC 8446 instead of 5077, 5246, but I'm not sure.

Yes, definitely.

--Paul Hoffman