Re: [Dots] Nits on draft-ietf-dots-signal-channel-23

Roman Danyliw <rdd@cert.org> Tue, 04 September 2018 15:39 UTC

Return-Path: <rdd@cert.org>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 41C86130F23 for <dots@ietfa.amsl.com>; Tue, 4 Sep 2018 08:39:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GmctiG_ByDmX for <dots@ietfa.amsl.com>; Tue, 4 Sep 2018 08:39:24 -0700 (PDT)
Received: from taper.sei.cmu.edu (taper.sei.cmu.edu [147.72.252.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7445412426A for <dots@ietf.org>; Tue, 4 Sep 2018 08:39:24 -0700 (PDT)
Received: from korb.sei.cmu.edu (korb.sei.cmu.edu [10.64.21.30]) by taper.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id w84FdK5d006720; Tue, 4 Sep 2018 11:39:21 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 taper.sei.cmu.edu w84FdK5d006720
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1536075561; bh=44ynd3UbCeEJApoVCcoc/GMnLslm/ZQvBwEOVPkI1Yc=; h=From:To:Subject:Date:References:In-Reply-To:From; b=asd1gR6u41CklWxSwZQzFbUjmoAbylLOfVR5QjC8YT+NQRZG272M0Z5y53tsIoumT lgW24eAynJh7O9NStZoFzEhanqMoCSutiePwXbvu4SqJniE2hJb10InoCEy3OGhjMN wIXGQmTGCtqdUK++HYuNvkrGAFwuReVYeWhiswIM=
Received: from CASSINA.ad.sei.cmu.edu (cassina.ad.sei.cmu.edu [10.64.28.249]) by korb.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id w84FdE5J015426; Tue, 4 Sep 2018 11:39:14 -0400
Received: from MARATHON.ad.sei.cmu.edu ([10.64.28.250]) by CASSINA.ad.sei.cmu.edu ([10.64.28.249]) with mapi id 14.03.0399.000; Tue, 4 Sep 2018 11:39:13 -0400
From: Roman Danyliw <rdd@cert.org>
To: "Konda, Tirumaleswar Reddy" <TirumaleswarReddy_Konda@McAfee.com>, "dots@ietf.org" <dots@ietf.org>
Thread-Topic: Nits on draft-ietf-dots-signal-channel-23
Thread-Index: AdQ5kM7ZOpfgZnNuTgGjXF3yS4ya6QAP26tgABYlfNAAIFUNYAJuwxPw
Date: Tue, 04 Sep 2018 15:39:13 +0000
Message-ID: <359EC4B99E040048A7131E0F4E113AFC014C43DE4F@marathon>
References: <359EC4B99E040048A7131E0F4E113AFC014C432BE6@marathon> <BN6PR16MB142595C15EAB7EB6B40E7707EA300@BN6PR16MB1425.namprd16.prod.outlook.com> <359EC4B99E040048A7131E0F4E113AFC014C4335A3@marathon> <BN6PR16MB14253B033A51EBB8057E19EFEA370@BN6PR16MB1425.namprd16.prod.outlook.com>
In-Reply-To: <BN6PR16MB14253B033A51EBB8057E19EFEA370@BN6PR16MB1425.namprd16.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.22.6]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/G2Q4rsq6kntBAaIc3f8yuLB77lE>
Subject: Re: [Dots] Nits on draft-ietf-dots-signal-channel-23
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Sep 2018 15:39:26 -0000

Hello Tiru!

> -----Original Message-----
> From: Dots [mailto:dots-bounces@ietf.org] On Behalf Of Konda,
> Tirumaleswar Reddy
> Sent: Thursday, August 23, 2018 2:27 AM
> To: Roman Danyliw <rdd@cert.org>; dots@ietf.org
> Subject: Re: [Dots] Nits on draft-ietf-dots-signal-channel-23
> 
> > -----Original Message-----
> > From: Roman Danyliw <rdd@cert.org>
> > Sent: Wednesday, August 22, 2018 9:02 PM
> > To: Konda, Tirumaleswar Reddy
> <TirumaleswarReddy_Konda@McAfee.com>;
> > dots@ietf.org
> > Subject: RE: Nits on draft-ietf-dots-signal-channel-23
> >
> > This email originated from outside of the organization. Do not click
> > links or open attachments unless you recognize the sender and know the
> content is safe.
> >
> > Hi Tiru!
> >
> > > -----Original Message-----
> > > From: Konda, Tirumaleswar Reddy
> > > [mailto:TirumaleswarReddy_Konda@mcafee.com]
> > > Sent: Wednesday, August 22, 2018 1:30 AM
> > > To: Roman Danyliw <rdd@cert.org>; dots@ietf.org
> > > Subject: RE: Nits on draft-ietf-dots-signal-channel-23
> > >
> > > > -----Original Message-----
> > > > From: Dots <dots-bounces@ietf.org> On Behalf Of Roman Danyliw
> > > > Sent: Wednesday, August 22, 2018 3:34 AM
> > > > To: dots@ietf.org
> > > > Subject: [Dots] Nits on draft-ietf-dots-signal-channel-23
> > > >
> > > > (5) Registration guidance for DOTS Signal Channel CBOR Mapping
> > > > Registry is precise.  However, I'm left seeking guidance on how to
> > > > process messages with fields not specified in this draft (i.e.,
> > > > fields registered after this draft is published).  The closest I
> > > > can find is language in Section 6 that states "[t]he recipient of
> > > > the payload MAY reject the  information if it is not suitably mapped."
> > > > I would also benefited from a preamble describing the purpose of
> > > > the registry -- is it a
> > > way to extend the protocol with new optional fields?
> > >
> > > Yes, we will have to request IANA to create "DOTS Signal Channel Claims"
> > > registry (just like it's done in https://tools.ietf.org/html/rfc8392
> > > and new drafts like
> > > https://tools.ietf.org/html/draft-ietf-ace-oauth-authz-13#section-
> > > 8.12  are using the registry defined in RFC8392 to add new claims).
> > > "Parameter Name" in the table 6 needs to be changed to "Claim Name".
> > >
> > > In addition, to accommodate future drafts to add new fields, the
> > > fields should be classified into " comprehension-optional" and
> > > "comprehension- required" for DOTS agents to ignore or reject
> > > unknown fields. The key value range can be further split to
> > > accommodate vendor-specific, comprehension- optional and
> > > comprehension-required attributes. The fields defined in this spec
> > > will be of type comprehension-
> > required.
> >
> > We're in complete agreement on the purpose of the registry.  It's the
> > explanation of the registry I'm proposing is missing.
> >
> > IMO, the draft would benefit from explicitly stating (1) the
> > processing implications of this registry (just as you stated above so
> > that the DOTS agents knows what to reject); and (2) noting that the
> > registry is a general means for extensibility. We have had several
> > ideas or individual drafts come to the WG requesting the addition of
> > new, optional fields to the protocol (e.g., draft-yang-
> > dos-type-for-dots-00 at IETF 102; draft-doron-dots-telemetry-00 at IETF 97).
> > The WG deferred them but we never explicitly resolved the issue of
> > extensibility. The registry addresses the issue of extensibility.  I'm
> > proposed as few words that state that.
> 
> Sure, will update draft.

Thanks for the new text in -24.  IMO this new partitioned registry provides the needed extensibility.

The language in -24 addresses my feedback. 

Roman