[Dots] Nits on draft-ietf-dots-signal-channel-23

Roman Danyliw <rdd@cert.org> Tue, 21 August 2018 22:04 UTC

Return-Path: <rdd@cert.org>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CBAC130DC6 for <dots@ietfa.amsl.com>; Tue, 21 Aug 2018 15:04:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BXFwALPPoeHG for <dots@ietfa.amsl.com>; Tue, 21 Aug 2018 15:04:00 -0700 (PDT)
Received: from taper.sei.cmu.edu (taper.sei.cmu.edu [147.72.252.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5ADAE130E93 for <dots@ietf.org>; Tue, 21 Aug 2018 15:04:00 -0700 (PDT)
Received: from delp.sei.cmu.edu (delp.sei.cmu.edu [10.64.21.31]) by taper.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id w7LM3ucc027617 for <dots@ietf.org>; Tue, 21 Aug 2018 18:03:57 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 taper.sei.cmu.edu w7LM3ucc027617
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1534889037; bh=HioI2Ps5Dg3wyaYrMbhMcihRY6eDYFxoQu48Jz2il64=; h=From:To:Subject:Date:From; b=f0GiJ04sWdhn/KnihZWfJ1NhgnlFR1nYtQXBnrn0TSXHAMciK28K+KNjPLMhTRAEz YJWv+rM9Bo97MA/y/NMt4Xu9+fsCPN4uulZpW7ucEQ4hXe2n3H8q3B6yhlgQa8LpEF Xch6SKbAlfOLWoUX9jYhO028nouY96v92lHCFjGY=
Received: from CASSINA.ad.sei.cmu.edu (cassina.ad.sei.cmu.edu [10.64.28.249]) by delp.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id w7LM3tLl026426 for <dots@ietf.org>; Tue, 21 Aug 2018 18:03:55 -0400
Received: from MARATHON.ad.sei.cmu.edu ([10.64.28.250]) by CASSINA.ad.sei.cmu.edu ([10.64.28.249]) with mapi id 14.03.0399.000; Tue, 21 Aug 2018 18:03:55 -0400
From: Roman Danyliw <rdd@cert.org>
To: "dots@ietf.org" <dots@ietf.org>
Thread-Topic: Nits on draft-ietf-dots-signal-channel-23
Thread-Index: AdQ5kM7ZOpfgZnNuTgGjXF3yS4ya6Q==
Date: Tue, 21 Aug 2018 22:03:54 +0000
Message-ID: <359EC4B99E040048A7131E0F4E113AFC014C432BE6@marathon>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.22.6]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/jdmkom5Jeren-xrNszad79NCMGM>
Subject: [Dots] Nits on draft-ietf-dots-signal-channel-23
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Aug 2018 22:04:02 -0000

Hello!

I did another review on -23 of the signal channel draft:

No action required
===============
(1) Idnits -- nothing actionable
(2) YANG module (Section 6) IS consistent with initial IANA table (Section 9.3.2) 

Discussion
========
(3) Figure 5 and 6 are inconsistent.  Figure 5 uses 'Uri-Path: "version"' and Figure 6 (and all subsequent figures) uses 'Uri-Path: "v1"'.  It seems like Figure 5 should also use "v1".

(4) Section 4.4.1 states that "major and minor version nomenclature to manage versioning; DOTS signal channel in this specification uses 'v1' major version."   No example shows how a minor version should be expressed.  Is it the obvious "v1.0"?

(5) Registration guidance for DOTS Signal Channel CBOR Mapping Registry is precise.  However, I'm left seeking guidance on how to process messages with fields not specified in this draft (i.e., fields registered after this draft is published).  The closest I can find is language in Section 6 that states "[t]he recipient of the payload MAY reject the  information if it is not suitably mapped."  I would also benefited from a preamble describing the purpose of the registry -- is it a way to extend the protocol with new optional fields?

Roman